From: L A Walsh <email@example.com> To: Karel Zak <firstname.lastname@example.org> Cc: "Theodore Ts'o" <email@example.com>, firstname.lastname@example.org, LKML <email@example.com> Subject: Re: [PATCH] build-sys: fix configure --without-systemd Date: Tue, 28 Jan 2020 16:15:07 -0800 Message-ID: <5E30CE8B.firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On 2020/01/28 04:07, Karel Zak wrote: > On Fri, Jan 24, 2020 at 12:29:47PM -0500, Theodore Ts'o wrote: > >> AC_ARG_WITH([systemd], >> AS_HELP_STRING([--without-systemd], [do not build with systemd support]), >> - , [with_systemd=check] >> + , [with_systemd=no] >> > > The current default is to check for the libraries, if installed than > enable systemd support. This is generic way we use for many libs and > features. Why do you think that explicit --enable-* will be better? > --- Perhaps Ted didn't realize that the line he replaced was only the default action (1st bracket pair empty => no option). Initially, I thought the same until I read further down (two lines): have_systemd=no AS_IF([test "x$with_systemd" != xno], [ ... test for positive case ] If any of the tests fail, then 'have_systemd=no' is the option passed along. I don't _think_ Ted is asking for for the default to be changed, as the subject of his note states it is to fix the "--without-systemd" case, but a fix was added for a bug that wasn't present, so I don't think he knowingly did what he intended to do.
prev parent reply index Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-24 17:29 Theodore Ts'o 2020-01-28 12:07 ` Karel Zak 2020-01-29 0:15 ` L A Walsh [this message]
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5E30CE8B.firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Util-Linux Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/util-linux/0 util-linux/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 util-linux util-linux/ https://lore.kernel.org/util-linux \ firstname.lastname@example.org public-inbox-index util-linux Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.util-linux AGPL code for this site: git clone https://public-inbox.org/public-inbox.git