Util-Linux Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] build-sys: fix configure --without-systemd
@ 2020-01-24 17:29 Theodore Ts'o
  2020-01-28 12:07 ` Karel Zak
  0 siblings, 1 reply; 3+ messages in thread
From: Theodore Ts'o @ 2020-01-24 17:29 UTC (permalink / raw)
  To: kzak; +Cc: util-linux, Theodore Ts'o

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 84b375543..595d57cf1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2215,7 +2215,7 @@ AM_CONDITIONAL([HAVE_BTRFS], [test "x$have_btrfs" = xyes])
 
 AC_ARG_WITH([systemd],
   AS_HELP_STRING([--without-systemd], [do not build with systemd support]),
-  [], [with_systemd=check]
+  [], [with_systemd=no]
 )
 
 have_systemd=no
-- 
2.24.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] build-sys: fix configure --without-systemd
  2020-01-24 17:29 [PATCH] build-sys: fix configure --without-systemd Theodore Ts'o
@ 2020-01-28 12:07 ` Karel Zak
  2020-01-29  0:15   ` L A Walsh
  0 siblings, 1 reply; 3+ messages in thread
From: Karel Zak @ 2020-01-28 12:07 UTC (permalink / raw)
  To: Theodore Ts'o; +Cc: util-linux

On Fri, Jan 24, 2020 at 12:29:47PM -0500, Theodore Ts'o wrote:
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 84b375543..595d57cf1 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2215,7 +2215,7 @@ AM_CONDITIONAL([HAVE_BTRFS], [test "x$have_btrfs" = xyes])
>  
>  AC_ARG_WITH([systemd],
>    AS_HELP_STRING([--without-systemd], [do not build with systemd support]),
> -  [], [with_systemd=check]
> +  [], [with_systemd=no]

The current default is to check for the libraries, if installed than
enable systemd support. This is generic way we use for many libs and
features. Why do you think that explicit --enable-* will be better?

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] build-sys: fix configure --without-systemd
  2020-01-28 12:07 ` Karel Zak
@ 2020-01-29  0:15   ` L A Walsh
  0 siblings, 0 replies; 3+ messages in thread
From: L A Walsh @ 2020-01-29  0:15 UTC (permalink / raw)
  To: Karel Zak; +Cc: Theodore Ts'o, util-linux, LKML

On 2020/01/28 04:07, Karel Zak wrote:
> On Fri, Jan 24, 2020 at 12:29:47PM -0500, Theodore Ts'o wrote:
>   
>>  AC_ARG_WITH([systemd],
>>    AS_HELP_STRING([--without-systemd], [do not build with systemd support]),
>> -  [], [with_systemd=check]
>> +  [], [with_systemd=no]
>>     
>
> The current default is to check for the libraries, if installed than
> enable systemd support. This is generic way we use for many libs and
> features. Why do you think that explicit --enable-* will be better?
>   
---

    Perhaps Ted didn't realize that the line he replaced
was only the default action (1st bracket pair empty => no option).
Initially, I thought the same until I read further
down (two lines):

have_systemd=no
AS_IF([test "x$with_systemd" != xno], [ ...
   test for positive case ]

If any of the tests fail, then 'have_systemd=no'
is the option passed along.

I don't _think_ Ted is asking for for the default to be
changed, as the subject of his note states it is
to fix the "--without-systemd" case, but a
fix was added for a bug that wasn't present,
so I don't think he knowingly did what he
intended to do.








^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-24 17:29 [PATCH] build-sys: fix configure --without-systemd Theodore Ts'o
2020-01-28 12:07 ` Karel Zak
2020-01-29  0:15   ` L A Walsh

Util-Linux Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/util-linux/0 util-linux/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 util-linux util-linux/ https://lore.kernel.org/util-linux \
		util-linux@vger.kernel.org
	public-inbox-index util-linux

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.util-linux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git