From: David Howells <dhowells@redhat.com>
To: Karel Zak <kzak@redhat.com>
Cc: dhowells@redhat.com, "Eric W. Biederman" <ebiederm@xmission.com>,
linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
Miklos Szeredi <miklos@szeredi.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
util-linux@vger.kernel.org, Andy Lutomirski <luto@amacapital.net>
Subject: Re: [RFD] A mount api that notices previous mounts
Date: Wed, 30 Jan 2019 13:01:54 +0000 [thread overview]
Message-ID: <9871.1548853314@warthog.procyon.org.uk> (raw)
In-Reply-To: <20190130120654.q5zqcexquca7u337@ws.net.home>
Karel Zak <kzak@redhat.com> wrote:
> It seems more elegant is to ask for Nth option as expected by fsinfo().
More elegant yes, but there's an issue with atomiticity[*]. I'm in the
process of switching to something that returns you a single buffer with all
the options in, but each key and each value is preceded by a length count.
The reasons for not using separator characters are:
(1) There's no separator char that cannot validly occur within an option[**].
(2) Makes it possible to return binary values if we need to.
David
[*] Atomic with respect to remount calls, that is.
[**] Oh, and look at cifs where you can *change* the separator char during
option parsing ("sep=<char>").
next prev parent reply other threads:[~2019-01-30 13:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 21:44 [RFD] A mount api that notices previous mounts Eric W. Biederman
2019-01-29 23:01 ` Casey Schaufler
2019-01-30 1:15 ` Eric W. Biederman
2019-01-30 1:23 ` Eric W. Biederman
2019-01-30 12:47 ` Eric W. Biederman
2019-01-30 16:19 ` Casey Schaufler
2019-01-30 12:06 ` Karel Zak
2019-01-30 13:45 ` Eric W. Biederman
2019-01-30 12:50 ` David Howells
2019-01-30 13:24 ` Eric W. Biederman
2019-01-30 13:01 ` David Howells [this message]
2019-01-30 13:35 ` Eric W. Biederman
2019-01-30 18:00 ` Karel Zak
2019-01-30 17:43 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9871.1548853314@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kzak@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
--cc=util-linux@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).