Util-Linux Archive on lore.kernel.org
 help / color / Atom feed
* util-linux-2.35.2 test failures
@ 2020-05-26 22:34 Bruce Dubbs
  2020-05-26 23:07 ` Aurélien Lajoie
  2020-05-27 13:11 ` Karel Zak
  0 siblings, 2 replies; 9+ messages in thread
From: Bruce Dubbs @ 2020-05-26 22:34 UTC (permalink / raw)
  To: Util-Linux

I'm getting three test failures and hope I can get someone to help.

The test failures are  ipcs/mk-rm-msg, ipcs/mk-rm-sem, and ipcs/mk-rm-shm.

Concentrating on mk-rm-msg, I found on the system:

./tests/output/ipcs/mk-rm-msg
./tests/ts/ipcs/mk-rm-msg
./tests/expected/ipcs/mk-rm-msg

The contents of the output and the expected files are identical:

Message queue id: <was_number>
1
Message queue id: <was_number>

I am running the tests as a non-privileged user.

If I run the commands:

$ ipcmk -Q  (returns 24)
$ ipcs -q -i 24
$ ipcrm -q 24
$ echo $?
0

Everything looks OK.  Does anyone have an idea why this test (these 
tests) are failing?

   -- Bruce Dubbs
      LFS

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: util-linux-2.35.2 test failures
  2020-05-26 22:34 util-linux-2.35.2 test failures Bruce Dubbs
@ 2020-05-26 23:07 ` Aurélien Lajoie
  2020-05-26 23:36   ` Bruce Dubbs
  2020-05-27 13:11 ` Karel Zak
  1 sibling, 1 reply; 9+ messages in thread
From: Aurélien Lajoie @ 2020-05-26 23:07 UTC (permalink / raw)
  To: Util-Linux; +Cc: Bruce Dubbs

On Wed, May 27, 2020 at 12:34 AM Bruce Dubbs <bruce.dubbs@gmail.com> wrote:
>
> I'm getting three test failures and hope I can get someone to help.
>
> The test failures are  ipcs/mk-rm-msg, ipcs/mk-rm-sem, and ipcs/mk-rm-shm.
>
> Concentrating on mk-rm-msg, I found on the system:
>
> ./tests/output/ipcs/mk-rm-msg
> ./tests/ts/ipcs/mk-rm-msg
> ./tests/expected/ipcs/mk-rm-msg
>
> The contents of the output and the expected files are identical:

How have you checked it ?
Can be trailing spaces, final break line or other thing like this.
Can you share the files and the result of ./run.sh ipcs launch from
tests directory?


>
> Message queue id: <was_number>
> 1
> Message queue id: <was_number>
>
> I am running the tests as a non-privileged user.
>
> If I run the commands:
>
> $ ipcmk -Q  (returns 24)
> $ ipcs -q -i 24
> $ ipcrm -q 24
> $ echo $?
> 0
>
> Everything looks OK.  Does anyone have an idea why this test (these
> tests) are failing?
>
>    -- Bruce Dubbs
>       LFS


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: util-linux-2.35.2 test failures
  2020-05-26 23:07 ` Aurélien Lajoie
@ 2020-05-26 23:36   ` Bruce Dubbs
  2020-05-27  3:11     ` Aurélien Lajoie
  0 siblings, 1 reply; 9+ messages in thread
From: Bruce Dubbs @ 2020-05-26 23:36 UTC (permalink / raw)
  To: Aurélien Lajoie, Util-Linux

On 5/26/20 6:07 PM, Aurélien Lajoie wrote:
> On Wed, May 27, 2020 at 12:34 AM Bruce Dubbs <bruce.dubbs@gmail.com> wrote:
>>
>> I'm getting three test failures and hope I can get someone to help.
>>
>> The test failures are  ipcs/mk-rm-msg, ipcs/mk-rm-sem, and ipcs/mk-rm-shm.
>>
>> Concentrating on mk-rm-msg, I found on the system:
>>
>> ./tests/output/ipcs/mk-rm-msg
>> ./tests/ts/ipcs/mk-rm-msg
>> ./tests/expected/ipcs/mk-rm-msg
>>
>> The contents of the output and the expected files are identical:
> 
> How have you checked it ?

Yes.  cmp ./tests/output/ipcs/mk-rm-msg ./tests/expected/ipcs/mk-rm-msg 
gives no output.

> Can be trailing spaces, final break line or other thing like this.
> Can you share the files and the result of ./run.sh ipcs launch from
> tests directory?

-------------------- util-linux regression tests --------------------

                     For development purpose only.
                  Don't execute on production system!

        kernel: 5.6.11-lfs-9.1

       options: --srcdir=/sources/util-linux-2.35.2/tests/.. \
                --builddir=/sources/util-linux-2.35.2/tests/..

          ipcs: headers                        ... OK
          ipcs: limits overflow 
.../sources/util-linux-2.35.2/tests/../tests/ts/ipcs/limits: line 42: 
echo: write error: Invalid argument
  OK
          ipcs: basic limits               ... OK
          ipcs: mk-rm-msg                  ... FAILED (ipcs/mk-rm-msg)
          ipcs: mk-rm-sem                  ... FAILED (ipcs/mk-rm-sem)
          ipcs: mk-rm-shm                  ... FAILED (ipcs/mk-rm-shm)

---------------------------------------------------------------------
   3 tests of 6 FAILED

I'll note that I am not running as root, line 42 of ts/ipcs/limits seems 
to want to write to:

$ ls -l /proc/sys/kernel/shm*
-rw-r--r-- 1 root root 0 May 26 18:27 /proc/sys/kernel/shm_rmid_forced
-rw-r--r-- 1 root root 0 May 26 14:32 /proc/sys/kernel/shmall
-rw-r--r-- 1 root root 0 May 26 14:32 /proc/sys/kernel/shmmax
-rw-r--r-- 1 root root 0 May 26 14:32 /proc/sys/kernel/shmmni


   -- Bruce





^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: util-linux-2.35.2 test failures
  2020-05-26 23:36   ` Bruce Dubbs
@ 2020-05-27  3:11     ` Aurélien Lajoie
  2020-05-27  3:43       ` Bruce Dubbs
  0 siblings, 1 reply; 9+ messages in thread
From: Aurélien Lajoie @ 2020-05-27  3:11 UTC (permalink / raw)
  To: Util-Linux; +Cc: Bruce Dubbs

On Wed, May 27, 2020 at 1:36 AM Bruce Dubbs <bruce.dubbs@gmail.com> wrote:
>
> On 5/26/20 6:07 PM, Aurélien Lajoie wrote:
> > On Wed, May 27, 2020 at 12:34 AM Bruce Dubbs <bruce.dubbs@gmail.com> wrote:
> >>
> >> I'm getting three test failures and hope I can get someone to help.
> >>
> >> The test failures are  ipcs/mk-rm-msg, ipcs/mk-rm-sem, and ipcs/mk-rm-shm.
> >>
> >> Concentrating on mk-rm-msg, I found on the system:
> >>
> >> ./tests/output/ipcs/mk-rm-msg
> >> ./tests/ts/ipcs/mk-rm-msg
> >> ./tests/expected/ipcs/mk-rm-msg
> >>
> >> The contents of the output and the expected files are identical:
> >
> > How have you checked it ?
>
> Yes.  cmp ./tests/output/ipcs/mk-rm-msg ./tests/expected/ipcs/mk-rm-msg
> gives no output.
>
> > Can be trailing spaces, final break line or other thing like this.
> > Can you share the files and the result of ./run.sh ipcs launch from
> > tests directory?
>
> -------------------- util-linux regression tests --------------------
>
>                      For development purpose only.
>                   Don't execute on production system!
>
>         kernel: 5.6.11-lfs-9.1
>
>        options: --srcdir=/sources/util-linux-2.35.2/tests/.. \
>                 --builddir=/sources/util-linux-2.35.2/tests/..
>
>           ipcs: headers                        ... OK
>           ipcs: limits overflow
> .../sources/util-linux-2.35.2/tests/../tests/ts/ipcs/limits: line 42:
> echo: write error: Invalid argument
>   OK
>           ipcs: basic limits               ... OK
>           ipcs: mk-rm-msg                  ... FAILED (ipcs/mk-rm-msg)
>           ipcs: mk-rm-sem                  ... FAILED (ipcs/mk-rm-sem)
>           ipcs: mk-rm-shm                  ... FAILED (ipcs/mk-rm-shm)
>
> ---------------------------------------------------------------------
>    3 tests of 6 FAILED
>
> I'll note that I am not running as root, line 42 of ts/ipcs/limits seems
> to want to write to:
>
> $ ls -l /proc/sys/kernel/shm*
> -rw-r--r-- 1 root root 0 May 26 18:27 /proc/sys/kernel/shm_rmid_forced
> -rw-r--r-- 1 root root 0 May 26 14:32 /proc/sys/kernel/shmall
> -rw-r--r-- 1 root root 0 May 26 14:32 /proc/sys/kernel/shmmax
> -rw-r--r-- 1 root root 0 May 26 14:32 /proc/sys/kernel/shmmni
>
I get this output as a non root user
 ./run.sh ipcs

-------------------- util-linux regression tests --------------------

                    For development purpose only.
                 Don't execute on production system!

       kernel: 5.3.0-53-generic

      options: --srcdir=/home/aurelienl/dev/util-linux/tests/.. \
               --builddir=/home/aurelienl/dev/util-linux/tests/..

         ipcs: headers                        ... OK
         ipcs: limits overflow                ... SKIPPED (no root permissions)
         ipcs: basic limits                   ... OK
         ipcs: mk-rm-msg                      ... OK
         ipcs: mk-rm-sem                      ... OK
         ipcs: mk-rm-shm                      ... OK

---------------------------------------------------------------------
  All 6 tests PASSED
---------------------------------------------------------------------


>
>    -- Bruce
>
>
>
>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: util-linux-2.35.2 test failures
  2020-05-27  3:11     ` Aurélien Lajoie
@ 2020-05-27  3:43       ` Bruce Dubbs
  2020-05-27  5:13         ` Bruce Dubbs
  0 siblings, 1 reply; 9+ messages in thread
From: Bruce Dubbs @ 2020-05-27  3:43 UTC (permalink / raw)
  To: Aurélien Lajoie, Util-Linux

On 5/26/20 10:11 PM, Aurélien Lajoie wrote:
> On Wed, May 27, 2020 at 1:36 AM Bruce Dubbs <bruce.dubbs@gmail.com> wrote:
>>
>> On 5/26/20 6:07 PM, Aurélien Lajoie wrote:
>>> On Wed, May 27, 2020 at 12:34 AM Bruce Dubbs <bruce.dubbs@gmail.com> wrote:
>>>>
>>>> I'm getting three test failures and hope I can get someone to help.
>>>>
>>>> The test failures are  ipcs/mk-rm-msg, ipcs/mk-rm-sem, and ipcs/mk-rm-shm.
>>>>
>>>> Concentrating on mk-rm-msg, I found on the system:
>>>>
>>>> ./tests/output/ipcs/mk-rm-msg
>>>> ./tests/ts/ipcs/mk-rm-msg
>>>> ./tests/expected/ipcs/mk-rm-msg
>>>>
>>>> The contents of the output and the expected files are identical:
>>>
>>> How have you checked it ?
>>
>> Yes.  cmp ./tests/output/ipcs/mk-rm-msg ./tests/expected/ipcs/mk-rm-msg
>> gives no output.
>>
>>> Can be trailing spaces, final break line or other thing like this.
>>> Can you share the files and the result of ./run.sh ipcs launch from
>>> tests directory?
>>
>> -------------------- util-linux regression tests --------------------
>>
>>                       For development purpose only.
>>                    Don't execute on production system!
>>
>>          kernel: 5.6.11-lfs-9.1
>>
>>         options: --srcdir=/sources/util-linux-2.35.2/tests/.. \
>>                  --builddir=/sources/util-linux-2.35.2/tests/..
>>
>>            ipcs: headers                        ... OK
>>            ipcs: limits overflow
>> .../sources/util-linux-2.35.2/tests/../tests/ts/ipcs/limits: line 42:
>> echo: write error: Invalid argument
>>    OK
>>            ipcs: basic limits               ... OK
>>            ipcs: mk-rm-msg                  ... FAILED (ipcs/mk-rm-msg)
>>            ipcs: mk-rm-sem                  ... FAILED (ipcs/mk-rm-sem)
>>            ipcs: mk-rm-shm                  ... FAILED (ipcs/mk-rm-shm)
>>
>> ---------------------------------------------------------------------
>>     3 tests of 6 FAILED
>>
>> I'll note that I am not running as root, line 42 of ts/ipcs/limits seems
>> to want to write to:
>>
>> $ ls -l /proc/sys/kernel/shm*
>> -rw-r--r-- 1 root root 0 May 26 18:27 /proc/sys/kernel/shm_rmid_forced
>> -rw-r--r-- 1 root root 0 May 26 14:32 /proc/sys/kernel/shmall
>> -rw-r--r-- 1 root root 0 May 26 14:32 /proc/sys/kernel/shmmax
>> -rw-r--r-- 1 root root 0 May 26 14:32 /proc/sys/kernel/shmmni
>>
> I get this output as a non root user
>   ./run.sh ipcs
> 
> -------------------- util-linux regression tests --------------------
> 
>                      For development purpose only.
>                   Don't execute on production system!
> 
>         kernel: 5.3.0-53-generic
> 
>        options: --srcdir=/home/aurelienl/dev/util-linux/tests/.. \
>                 --builddir=/home/aurelienl/dev/util-linux/tests/..
> 
>           ipcs: headers                        ... OK
>           ipcs: limits overflow                ... SKIPPED (no root permissions)
>           ipcs: basic limits                   ... OK
>           ipcs: mk-rm-msg                      ... OK
>           ipcs: mk-rm-sem                      ... OK
>           ipcs: mk-rm-shm                      ... OK
> 
> ---------------------------------------------------------------------
>    All 6 tests PASSED
> ---------------------------------------------------------------------

OK, thanks. Some very minor progress:


   ipcs: headers                        ... OK
   ipcs: limits overflow                ... SKIPPED (no root permissions)
   ipcs: basic limits                   ... OK
   ipcs: mk-rm-msg                      ... FAILED (ipcs/mk-rm-msg)
   ipcs: mk-rm-sem                      ... FAILED (ipcs/mk-rm-sem)
   ipcs: mk-rm-shm                      ... FAILED (ipcs/mk-rm-shm)

   3 tests of 6 FAILED

But I did find

$ cat diff/ipcs/*
--- /dev/null   2020-05-13 00:30:52.352031152 -0500
+++ /sources/util-linux-2.35.2/tests/output/ipcs/mk-rm-msg.err 
2020-05-26 22:26:15.955322405 -0500
@@ -0,0 +1,2 @@
+ipcrm: failed to parse argument: '0xa12709c3
+0xa12709c3'
--- /dev/null   2020-05-13 00:30:52.352031152 -0500
+++ /sources/util-linux-2.35.2/tests/output/ipcs/mk-rm-sem.err 
2020-05-26 22:26:15.984321830 -0500
@@ -0,0 +1,3 @@
+ipcrm: failed to parse argument: '0x1e5d8a7d
+0x1e5d8a7d
+0x1e5d8a7d'
--- /dev/null   2020-05-13 00:30:52.352031152 -0500
+++ /sources/util-linux-2.35.2/tests/output/ipcs/mk-rm-shm.err 
2020-05-26 22:26:16.012321273 -0500
@@ -0,0 +1,2 @@
+ipcrm: failed to parse argument: '0x12dec276
+0x12dec276'

I just don't know what argument it was trying to pass.

   -- Bruce

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: util-linux-2.35.2 test failures
  2020-05-27  3:43       ` Bruce Dubbs
@ 2020-05-27  5:13         ` Bruce Dubbs
  0 siblings, 0 replies; 9+ messages in thread
From: Bruce Dubbs @ 2020-05-27  5:13 UTC (permalink / raw)
  To: Aurélien Lajoie, Util-Linux

On 5/26/20 10:43 PM, Bruce Dubbs wrote:
> On 5/26/20 10:11 PM, Aurélien Lajoie wrote:
>> On Wed, May 27, 2020 at 1:36 AM Bruce Dubbs <bruce.dubbs@gmail.com> 
>> wrote:
>>>
>>> On 5/26/20 6:07 PM, Aurélien Lajoie wrote:
>>>> On Wed, May 27, 2020 at 12:34 AM Bruce Dubbs <bruce.dubbs@gmail.com> 
>>>> wrote:
>>>>>
>>>>> I'm getting three test failures and hope I can get someone to help.
>>>>>
>>>>> The test failures are  ipcs/mk-rm-msg, ipcs/mk-rm-sem, and 
>>>>> ipcs/mk-rm-shm.
>>>>>
>>>>> Concentrating on mk-rm-msg, I found on the system:
>>>>>
>>>>> ./tests/output/ipcs/mk-rm-msg
>>>>> ./tests/ts/ipcs/mk-rm-msg
>>>>> ./tests/expected/ipcs/mk-rm-msg
>>>>>
>>>>> The contents of the output and the expected files are identical:
>>>>
>>>> How have you checked it ?
>>>
>>> Yes.  cmp ./tests/output/ipcs/mk-rm-msg ./tests/expected/ipcs/mk-rm-msg
>>> gives no output.
>>>
>>>> Can be trailing spaces, final break line or other thing like this.
>>>> Can you share the files and the result of ./run.sh ipcs launch from
>>>> tests directory?
>>>
>>> -------------------- util-linux regression tests --------------------
>>>
>>>                       For development purpose only.
>>>                    Don't execute on production system!
>>>
>>>          kernel: 5.6.11-lfs-9.1
>>>
>>>         options: --srcdir=/sources/util-linux-2.35.2/tests/.. \
>>>                  --builddir=/sources/util-linux-2.35.2/tests/..
>>>
>>>            ipcs: headers                        ... OK
>>>            ipcs: limits overflow
>>> .../sources/util-linux-2.35.2/tests/../tests/ts/ipcs/limits: line 42:
>>> echo: write error: Invalid argument
>>>    OK
>>>            ipcs: basic limits               ... OK
>>>            ipcs: mk-rm-msg                  ... FAILED (ipcs/mk-rm-msg)
>>>            ipcs: mk-rm-sem                  ... FAILED (ipcs/mk-rm-sem)
>>>            ipcs: mk-rm-shm                  ... FAILED (ipcs/mk-rm-shm)
>>>
>>> ---------------------------------------------------------------------
>>>     3 tests of 6 FAILED
>>>
>>> I'll note that I am not running as root, line 42 of ts/ipcs/limits seems
>>> to want to write to:
>>>
>>> $ ls -l /proc/sys/kernel/shm*
>>> -rw-r--r-- 1 root root 0 May 26 18:27 /proc/sys/kernel/shm_rmid_forced
>>> -rw-r--r-- 1 root root 0 May 26 14:32 /proc/sys/kernel/shmall
>>> -rw-r--r-- 1 root root 0 May 26 14:32 /proc/sys/kernel/shmmax
>>> -rw-r--r-- 1 root root 0 May 26 14:32 /proc/sys/kernel/shmmni
>>>
>> I get this output as a non root user
>>   ./run.sh ipcs
>>
>> -------------------- util-linux regression tests --------------------
>>
>>                      For development purpose only.
>>                   Don't execute on production system!
>>
>>         kernel: 5.3.0-53-generic
>>
>>        options: --srcdir=/home/aurelienl/dev/util-linux/tests/.. \
>>                 --builddir=/home/aurelienl/dev/util-linux/tests/..
>>
>>           ipcs: headers                        ... OK
>>           ipcs: limits overflow                ... SKIPPED (no root 
>> permissions)
>>           ipcs: basic limits                   ... OK
>>           ipcs: mk-rm-msg                      ... OK
>>           ipcs: mk-rm-sem                      ... OK
>>           ipcs: mk-rm-shm                      ... OK
>>
>> ---------------------------------------------------------------------
>>    All 6 tests PASSED
>> ---------------------------------------------------------------------
> 
> OK, thanks. Some very minor progress:
> 
> 
>    ipcs: headers                        ... OK
>    ipcs: limits overflow                ... SKIPPED (no root permissions)
>    ipcs: basic limits                   ... OK
>    ipcs: mk-rm-msg                      ... FAILED (ipcs/mk-rm-msg)
>    ipcs: mk-rm-sem                      ... FAILED (ipcs/mk-rm-sem)
>    ipcs: mk-rm-shm                      ... FAILED (ipcs/mk-rm-shm)
> 
>    3 tests of 6 FAILED
> 
> But I did find
> 
> $ cat diff/ipcs/*
> --- /dev/null   2020-05-13 00:30:52.352031152 -0500
> +++ /sources/util-linux-2.35.2/tests/output/ipcs/mk-rm-msg.err 
> 2020-05-26 22:26:15.955322405 -0500
> @@ -0,0 +1,2 @@
> +ipcrm: failed to parse argument: '0xa12709c3
> +0xa12709c3'
> --- /dev/null   2020-05-13 00:30:52.352031152 -0500
> +++ /sources/util-linux-2.35.2/tests/output/ipcs/mk-rm-sem.err 
> 2020-05-26 22:26:15.984321830 -0500
> @@ -0,0 +1,3 @@
> +ipcrm: failed to parse argument: '0x1e5d8a7d
> +0x1e5d8a7d
> +0x1e5d8a7d'
> --- /dev/null   2020-05-13 00:30:52.352031152 -0500
> +++ /sources/util-linux-2.35.2/tests/output/ipcs/mk-rm-shm.err 
> 2020-05-26 22:26:16.012321273 -0500
> @@ -0,0 +1,2 @@
> +ipcrm: failed to parse argument: '0x12dec276
> +0x12dec276'
> 
> I just don't know what argument it was trying to pass.

I figured out what is happening.

The code in question is doing:

$TS_CMD_IPCMK -Q 2>>$TS_OUTPUT | ipcmk_output_handler $TS_OUTPUT 
$TS_OUTDIR/id-msg

$TS_CMD_IPCRM -Q "$(
         $TS_CMD_IPCS -q |
         awk -v id=$(cat $TS_OUTDIR/id-msg) '{if ($2 == id){print $1}}'
)" >> $TS_OUTPUT 2>> $TS_ERRLOG

ipcs -q gives output like:

0x96067edf 52         tester     644        0            0
0x96067edf 52         tester     644        0            0

so it is trying to run:

ipcrm -Q 0x25cee277\n0x96067edf

which gives:
ipcrm: failed to parse argument: '0x25cee277'
'0x25cee277'

The question is why there are two identical entries in the ipcs output. 
Could this be a kernel issue?  Code or configuration?  My kernel is 5.6.11.

   -- Bruce

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: util-linux-2.35.2 test failures
  2020-05-26 22:34 util-linux-2.35.2 test failures Bruce Dubbs
  2020-05-26 23:07 ` Aurélien Lajoie
@ 2020-05-27 13:11 ` Karel Zak
  2020-05-27 15:55   ` Bruce Dubbs
  1 sibling, 1 reply; 9+ messages in thread
From: Karel Zak @ 2020-05-27 13:11 UTC (permalink / raw)
  To: Bruce Dubbs; +Cc: Util-Linux

On Tue, May 26, 2020 at 05:34:13PM -0500, Bruce Dubbs wrote:
> I'm getting three test failures and hope I can get someone to help.
> 
> The test failures are  ipcs/mk-rm-msg, ipcs/mk-rm-sem, and ipcs/mk-rm-shm.
> 
> Concentrating on mk-rm-msg, I found on the system:
> 
> ./tests/output/ipcs/mk-rm-msg
> ./tests/ts/ipcs/mk-rm-msg
> ./tests/expected/ipcs/mk-rm-msg
> 
> The contents of the output and the expected files are identical:
> 
> Message queue id: <was_number>
> 1
> Message queue id: <was_number>
> 
> I am running the tests as a non-privileged user.
> 
> If I run the commands:
> 
> $ ipcmk -Q  (returns 24)
> $ ipcs -q -i 24
> $ ipcrm -q 24
> $ echo $?
> 0
> 
> Everything looks OK.  Does anyone have an idea why this test (these tests)
> are failing?

I had no time to play with it yet, but according to feedback from 
https://github.com/karelzak/util-linux/issues/1042 there is some kernel
regression:

 The ipcs tests are failing due to a regression in kernels 5.6.8
 through 5.6.13. Or mainline commits between
 89163f93c6f969da5811af5377cc10173583123b and
 5e698222c70257d13ae0816720dde57c56f81e15 (apparently including your
 5.7.0-rc0).


    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: util-linux-2.35.2 test failures
  2020-05-27 13:11 ` Karel Zak
@ 2020-05-27 15:55   ` Bruce Dubbs
  2020-05-27 18:07     ` Bruce Dubbs
  0 siblings, 1 reply; 9+ messages in thread
From: Bruce Dubbs @ 2020-05-27 15:55 UTC (permalink / raw)
  To: Karel Zak; +Cc: Util-Linux

On 5/27/20 8:11 AM, Karel Zak wrote:
> On Tue, May 26, 2020 at 05:34:13PM -0500, Bruce Dubbs wrote:
>> I'm getting three test failures and hope I can get someone to help.
>>
>> The test failures are  ipcs/mk-rm-msg, ipcs/mk-rm-sem, and ipcs/mk-rm-shm.
>>
>> Concentrating on mk-rm-msg, I found on the system:
>>
>> ./tests/output/ipcs/mk-rm-msg
>> ./tests/ts/ipcs/mk-rm-msg
>> ./tests/expected/ipcs/mk-rm-msg
>>
>> The contents of the output and the expected files are identical:
>>
>> Message queue id: <was_number>
>> 1
>> Message queue id: <was_number>
>>
>> I am running the tests as a non-privileged user.
>>
>> If I run the commands:
>>
>> $ ipcmk -Q  (returns 24)
>> $ ipcs -q -i 24
>> $ ipcrm -q 24
>> $ echo $?
>> 0
>>
>> Everything looks OK.  Does anyone have an idea why this test (these tests)
>> are failing?
> 
> I had no time to play with it yet, but according to feedback from
> https://github.com/karelzak/util-linux/issues/1042 there is some kernel
> regression:
> 
>   The ipcs tests are failing due to a regression in kernels 5.6.8
>   through 5.6.13. Or mainline commits between
>   89163f93c6f969da5811af5377cc10173583123b and
>   5e698222c70257d13ae0816720dde57c56f81e15 (apparently including your
>   5.7.0-rc0).

Thanks.  I'll try 5.6.14 and report back.

   -- Bruce


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: util-linux-2.35.2 test failures
  2020-05-27 15:55   ` Bruce Dubbs
@ 2020-05-27 18:07     ` Bruce Dubbs
  0 siblings, 0 replies; 9+ messages in thread
From: Bruce Dubbs @ 2020-05-27 18:07 UTC (permalink / raw)
  To: Karel Zak; +Cc: Util-Linux

On 5/27/20 10:55 AM, Bruce Dubbs wrote:
> On 5/27/20 8:11 AM, Karel Zak wrote:
>> On Tue, May 26, 2020 at 05:34:13PM -0500, Bruce Dubbs wrote:
>>> I'm getting three test failures and hope I can get someone to help.
>>>
>>> The test failures are  ipcs/mk-rm-msg, ipcs/mk-rm-sem, and 
>>> ipcs/mk-rm-shm.
>>>
>>> Concentrating on mk-rm-msg, I found on the system:
>>>
>>> ./tests/output/ipcs/mk-rm-msg
>>> ./tests/ts/ipcs/mk-rm-msg
>>> ./tests/expected/ipcs/mk-rm-msg
>>>
>>> The contents of the output and the expected files are identical:
>>>
>>> Message queue id: <was_number>
>>> 1
>>> Message queue id: <was_number>
>>>
>>> I am running the tests as a non-privileged user.
>>>
>>> If I run the commands:
>>>
>>> $ ipcmk -Q  (returns 24)
>>> $ ipcs -q -i 24
>>> $ ipcrm -q 24
>>> $ echo $?
>>> 0
>>>
>>> Everything looks OK.  Does anyone have an idea why this test (these 
>>> tests)
>>> are failing?
>>
>> I had no time to play with it yet, but according to feedback from
>> https://github.com/karelzak/util-linux/issues/1042 there is some kernel
>> regression:
>>
>>   The ipcs tests are failing due to a regression in kernels 5.6.8
>>   through 5.6.13. Or mainline commits between
>>   89163f93c6f969da5811af5377cc10173583123b and
>>   5e698222c70257d13ae0816720dde57c56f81e15 (apparently including your
>>   5.7.0-rc0).
> 
> Thanks.  I'll try 5.6.14 and report back.

Indeed updating to kernel 5.6.14 fixed the ipcs test issues.  Thanks for 
the help.

Additionally I'd like to report one minor warning when building with gcc10:

login-utils/logindefs.c: In function ‘get_hushlogin_status’:
login-utils/logindefs.c:370:20: warning: ‘%s’ directive writing likely 
15 or more bytes into a region of size between 9 and 8191 
[-Wformat-overflow=]
   370 |   sprintf(buf, "%s/%s", pwd->pw_dir, file);
       |                    ^~
login-utils/logindefs.c:370:16: note: assuming directive output of 15 bytes
   370 |   sprintf(buf, "%s/%s", pwd->pw_dir, file);
       |                ^~~~~~~
login-utils/logindefs.c:370:3: note: ‘sprintf’ output 2 or more bytes 
(assuming 8199) into a destination of size 8192
   370 |   sprintf(buf, "%s/%s", pwd->pw_dir, file);
       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   -- Bruce

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-26 22:34 util-linux-2.35.2 test failures Bruce Dubbs
2020-05-26 23:07 ` Aurélien Lajoie
2020-05-26 23:36   ` Bruce Dubbs
2020-05-27  3:11     ` Aurélien Lajoie
2020-05-27  3:43       ` Bruce Dubbs
2020-05-27  5:13         ` Bruce Dubbs
2020-05-27 13:11 ` Karel Zak
2020-05-27 15:55   ` Bruce Dubbs
2020-05-27 18:07     ` Bruce Dubbs

Util-Linux Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/util-linux/0 util-linux/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 util-linux util-linux/ https://lore.kernel.org/util-linux \
		util-linux@vger.kernel.org
	public-inbox-index util-linux

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.util-linux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git