irqtop todo note

irqtop todo note

[Sami Kerola]

Hello,

I notice irqtop to todo file, so I decided to look into that. Changes
in my branch are nowhere near ready to be considered to upstream
ready, so no pull request yet maybe sometime later January or early
February. Meanwhile if someone else is working with the same I'm sure
efforts can be combined.

https://github.com/kerolasa/util-linux/commits/irqtop

Things to fix with my work.

* Save git history from https://github.com/pacepi/irqtop
* Write proper commit messages
* Use smartcolums
* Change output header to include hostname and iso timestamp
* Use signalfd to catch signals
* Use timerfd  for periodic execution
* Make main() shorter / simpler by moving bits and bobs to functions
* And the things I don't know yet, but without doubt there will be some

-- 
Sami Kerola
http://www.iki.fi/kerolasa/

Re: [Phishing Risk] [External] irqtop todo note

[Karel Zak]

On Sun, Jan 05, 2020 at 11:36:26AM +0800, zhenwei pi wrote:
> On 1/4/20 6:20 PM, Sami Kerola wrote:
> 
> > Hello,
> > 
> > I notice irqtop to todo file, so I decided to look into that. Changes
> > in my branch are nowhere near ready to be considered to upstream
> > ready, so no pull request yet maybe sometime later January or early
> > February. Meanwhile if someone else is working with the same I'm sure
> > efforts can be combined.
> > 
> > https://github.com/kerolasa/util-linux/commits/irqtop
> > 
> > Things to fix with my work.
> > 
> > * Save git history from https://github.com/pacepi/irqtop
> > * Write proper commit messages
> > * Use smartcolums
> > * Change output header to include hostname and iso timestamp
> > * Use signalfd to catch signals
> > * Use timerfd  for periodic execution
> > * Make main() shorter / simpler by moving bits and bobs to functions
> > * And the things I don't know yet, but without doubt there will be some
> > 
> Thanks for these works. Maybe it's ready to be merged into upstream.
> Hey, Karel, how do you think about this?

Later, for v2.35 is too late ;-)

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: [Phishing Risk] [External] irqtop todo note

[zhenwei pi]

On 1/6/20 6:52 PM, Karel Zak wrote:
> On Sun, Jan 05, 2020 at 11:36:26AM +0800, zhenwei pi wrote:
>> On 1/4/20 6:20 PM, Sami Kerola wrote:
>>
>>> Hello,
>>>
>>> I notice irqtop to todo file, so I decided to look into that. Changes
>>> in my branch are nowhere near ready to be considered to upstream
>>> ready, so no pull request yet maybe sometime later January or early
>>> February. Meanwhile if someone else is working with the same I'm sure
>>> efforts can be combined.
>>>
>>> https://github.com/kerolasa/util-linux/commits/irqtop
>>>
>>> Things to fix with my work.
>>>
>>> * Save git history from https://github.com/pacepi/irqtop
>>> * Write proper commit messages
>>> * Use smartcolums
>>> * Change output header to include hostname and iso timestamp
>>> * Use signalfd to catch signals
>>> * Use timerfd  for periodic execution
>>> * Make main() shorter / simpler by moving bits and bobs to functions
>>> * And the things I don't know yet, but without doubt there will be some
>>>
>> Thanks for these works. Maybe it's ready to be merged into upstream.
>> Hey, Karel, how do you think about this?
> 
> Later, for v2.35 is too late ;-)
> 
>      Karel
> 

Hey, I notice that v2.35 has been released. How about continuing this work?

-- 
zhenwei pi

Re: [Phishing Risk] [External] irqtop todo note

[Sami Kerola]

On Thu, 6 Feb 2020 at 01:23, zhenwei pi <pizhenwei@bytedance.com> wrote:
> Hey, I notice that v2.35 has been released. How about continuing this work?

Yes, that's the plan: https://github.com/karelzak/util-linux/pull/952

-- 
Sami Kerola
http://www.iki.fi/kerolasa/