From: Eric Van Hensbergen <ericvh@kernel.org>
To: Latchesar Ionkov <lucho@ionkov.net>,
Dominique Martinet <asmadeus@codewreck.org>,
Christian Schoenebeck <linux_oss@crudebyte.com>
Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel@pengutronix.de, stable@vger.kernel.org,
Robert Schwebel <r.schwebel@pengutronix.de>,
Eric Van Hensbergen <ericvh@kernel.org>
Subject: [PATCH v3 3/4] fs/9p: fix type mismatch in file cache mode helper
Date: Wed, 19 Jul 2023 15:17:07 +0000 [thread overview]
Message-ID: <20230716-fixes-overly-restrictive-mmap-v3-3-769791f474fd@kernel.org> (raw)
In-Reply-To: <20230716-fixes-overly-restrictive-mmap-v3-0-769791f474fd@kernel.org>
There were two flags (s_flags and s_cache) which had incorrect signed
type in the parameters of the file cache mode helper function.
Fixes: 1543b4c5071c ("fs/9p: remove writeback fid and fix per-file modes")
Link: https://lore.kernel.org/v9fs/ZK25XZ%2BGpR3KHIB%2F@pengutronix.de/
Reviewed-by: Dominique Martinet <asmadeus@codewreck.org>
Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
---
fs/9p/fid.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/9p/fid.h b/fs/9p/fid.h
index 297c2c377e3d..29281b7c3887 100644
--- a/fs/9p/fid.h
+++ b/fs/9p/fid.h
@@ -46,8 +46,8 @@ static inline struct p9_fid *v9fs_fid_clone(struct dentry *dentry)
* NOTE: these are set after open so only reflect 9p client not
* underlying file system on server.
*/
-static inline void v9fs_fid_add_modes(struct p9_fid *fid, int s_flags,
- int s_cache, unsigned int f_flags)
+static inline void v9fs_fid_add_modes(struct p9_fid *fid, unsigned int s_flags,
+ unsigned int s_cache, unsigned int f_flags)
{
if (fid->qid.type != P9_QTFILE)
return;
--
2.39.2
next prev parent reply other threads:[~2023-07-19 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 15:17 [PATCH v3 0/4] fs/9p: fix mmap regression Eric Van Hensbergen
2023-07-19 15:17 ` [PATCH v3 1/4] fs/9p: remove unnecessary and overrestrictive check Eric Van Hensbergen
2023-07-19 15:39 ` Greg KH
2023-07-19 15:17 ` [PATCH v3 2/4] fs/9p: fix typo in comparison logic for cache mode Eric Van Hensbergen
2023-07-19 15:40 ` Greg KH
2023-07-19 15:17 ` Eric Van Hensbergen [this message]
2023-07-19 15:40 ` [PATCH v3 3/4] fs/9p: fix type mismatch in file cache mode helper Greg KH
2023-07-19 15:17 ` [PATCH v3 4/4] fs/9p: remove unnecessary invalidate_inode_pages2 Eric Van Hensbergen
2023-07-19 15:40 ` Greg KH
2023-07-24 21:17 ` [PATCH v3 0/4] fs/9p: fix mmap regression Robert Schwebel
2023-07-24 21:39 ` Eric Van Hensbergen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230716-fixes-overly-restrictive-mmap-v3-3-769791f474fd@kernel.org \
--to=ericvh@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=r.schwebel@pengutronix.de \
--cc=stable@vger.kernel.org \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).