v9fs.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Eric Van Hensbergen <ericvh@kernel.org>
To: Latchesar Ionkov <lucho@ionkov.net>,
	 Dominique Martinet <asmadeus@codewreck.org>,
	 Christian Schoenebeck <linux_oss@crudebyte.com>
Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
	 Eric Van Hensbergen <ericvh@kernel.org>
Subject: [PATCH v2 8/8] fs/9p: fix dups even in uncached mode
Date: Mon, 08 Jan 2024 15:18:24 +0000	[thread overview]
Message-ID: <20240108-ericvh-fix-cache-dups-v2-8-a73f8822838c@kernel.org> (raw)
In-Reply-To: <20240108-ericvh-fix-cache-dups-v2-0-a73f8822838c@kernel.org>

In uncached mode we were still seeing duplicate getattr requests
because of aggressive dropping of inodes.  Inode "freshness" is
guarded by other mechanisms when caches are disabled so this
is unnecessary and increases overhead of almost every operation.

Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
---
 fs/9p/vfs_super.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/fs/9p/vfs_super.c b/fs/9p/vfs_super.c
index 6d9a98c57185..a898dbf97710 100644
--- a/fs/9p/vfs_super.c
+++ b/fs/9p/vfs_super.c
@@ -244,21 +244,6 @@ static int v9fs_statfs(struct dentry *dentry, struct kstatfs *buf)
 	return res;
 }
 
-static int v9fs_drop_inode(struct inode *inode)
-{
-	struct v9fs_session_info *v9ses;
-
-	v9ses = v9fs_inode2v9ses(inode);
-	if (v9ses->cache & (CACHE_META|CACHE_LOOSE))
-		return generic_drop_inode(inode);
-	/*
-	 * in case of non cached mode always drop the
-	 * inode because we want the inode attribute
-	 * to always match that on the server.
-	 */
-	return 1;
-}
-
 static int v9fs_write_inode(struct inode *inode,
 			    struct writeback_control *wbc)
 {
@@ -303,7 +288,6 @@ static const struct super_operations v9fs_super_ops_dotl = {
 	.alloc_inode = v9fs_alloc_inode,
 	.free_inode = v9fs_free_inode,
 	.statfs = v9fs_statfs,
-	.drop_inode = v9fs_drop_inode,
 	.evict_inode = v9fs_evict_inode,
 	.show_options = v9fs_show_options,
 	.umount_begin = v9fs_umount_begin,

-- 
2.41.0


      parent reply	other threads:[~2024-01-08 15:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-08 15:18 [PATCH v2 0/8] fs/9p: simplify inode lookup operations Eric Van Hensbergen
2024-01-08 15:18 ` [PATCH v2 1/8] fs/9p: switch vfsmount to use v9fs_get_new_inode Eric Van Hensbergen
2024-01-08 15:18 ` [PATCH v2 2/8] fs/9p: convert mkdir to use get_new_inode Eric Van Hensbergen
2024-01-08 15:18 ` [PATCH v2 3/8] fs/9p: remove walk and inode allocation from symlink Eric Van Hensbergen
2024-01-08 15:18 ` [PATCH v2 4/8] fs/9p: Eliminate redundant non-cache path in mknod Eric Van Hensbergen
2024-01-08 15:18 ` [PATCH v2 5/8] fs/9p: Eliminate now unused v9fs_get_inode Eric Van Hensbergen
2024-01-08 15:18 ` [PATCH v2 6/8] fs/9p: rework qid2ino logic Eric Van Hensbergen
2024-01-08 15:18 ` [PATCH v2 7/8] fs/9p: simplify iget to remove unnecessary paths Eric Van Hensbergen
2024-01-08 15:18 ` Eric Van Hensbergen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240108-ericvh-fix-cache-dups-v2-8-a73f8822838c@kernel.org \
    --to=ericvh@kernel.org \
    --cc=asmadeus@codewreck.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux_oss@crudebyte.com \
    --cc=lucho@ionkov.net \
    --cc=v9fs@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).