From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 684F8C76195 for ; Wed, 22 Mar 2023 16:53:35 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id B8A4975984 for ; Wed, 22 Mar 2023 16:53:34 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id AD042986463 for ; Wed, 22 Mar 2023 16:53:34 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id A372C98644E; Wed, 22 Mar 2023 16:53:34 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 93EA1986450 for ; Wed, 22 Mar 2023 16:53:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: jO6J5nTJMA-W_4qCvXsyOg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679504010; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mnICd+2COAiNCYaGUXzuaNjX8uOlmsLgwvvcqjYHdCc=; b=W8gqUUiOCxjSER3xV3aQj2qe6tGaqdjwvZ1FCNgdkeQh1/Ou1QNNy2sM51W0UNXqSW 2cAo82bjCCv3jMp67JAzBFa4By3rJ7mzU/S0+tQLqCJHhc6+mF+yzcfV09zGoDTHZb9W AXH32i2/lwr8IIt6wbzU12YJFb61r8AwJ6Jkh+bDM3Y9P7w4xmLzrxYqMFk+Gqxm7rKd MC7GLATEj4bVvwpFwybnk6b0Z/K3lVVKFb+PlxlrDGcWcMmyVy3IIl5NCVgBlYBXb6Ax DigiC4zhgIbq7ZWL2AT/G5MKx7UkXlV9txb27XzlJwBbd0Am634ihE3pIQ4XoH11iWNb asGg== X-Gm-Message-State: AO0yUKVMM+peSXrt1zK6xN1ABq5XBLj+9yYBboNqHmd4duQD6SK5q9I0 eXd0+Yk21ekPVZxgfQ1ivV5IAkG7ACigDutl6BH2L1uGsJGhZl4O2rTVGw5IQblFSfWeKU7/yic tjzGZyL3RT42JD62shZphe44CzPzfKxeeRw== X-Received: by 2002:a17:906:a855:b0:931:8e8c:2db5 with SMTP id dx21-20020a170906a85500b009318e8c2db5mr7599613ejb.69.1679504010619; Wed, 22 Mar 2023 09:53:30 -0700 (PDT) X-Google-Smtp-Source: AK7set+aTfvYprcWYRljW5GlaXu8PK7R4q4bDkFvhBB1kkTUKYIgrLnLYLOahX949+ZWv8nxio4YKg== X-Received: by 2002:a17:906:a855:b0:931:8e8c:2db5 with SMTP id dx21-20020a170906a85500b009318e8c2db5mr7599587ejb.69.1679504010320; Wed, 22 Mar 2023 09:53:30 -0700 (PDT) Date: Wed, 22 Mar 2023 12:53:26 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Cornelia Huck , Heng Qi , "virtio-dev@lists.oasis-open.org" , "virtio-comment@lists.oasis-open.org" , Jason Wang , Alvaro Karsz , David Edmondson , Xuan Zhuo Message-ID: <20230322125058-mutt-send-email-mst@kernel.org> References: <20230322125153.128385-1-hengqi@linux.alibaba.com> <87sfdwhkxq.fsf@redhat.com> <87pm90hhew.fsf@redhat.com> <87jzz8hh1w.fsf@redhat.com> <20230322124508-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: Re: [virtio-comment] RE: [PATCH v13] virtio-net: support the virtqueue coalescing moderation On Wed, Mar 22, 2023 at 04:49:58PM +0000, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, March 22, 2023 12:47 PM > > > > I agree with Cornelia here. Yes if devices do not want to trust drivers then they > > will validate input but what exactly happens then is currently up to device. > > If we want to try and specify devices in all cases of out of spec input that's a big > > project, certainly doable but I would rather not connect it to this, rather > > boutique, feature. > Both of your and Cornelia's comment is abstract to me. > We cannot change past. But we can make sure things are consistent. Currently we don't describe device behaviour if driver is out of spec and I see 0 reasons to start doing it with coalescing commands specifically. > For the new command of interest here, hen driver supplied incorrect values, the device will return error. It might be easier for device to just set NEEDS_RESET and stop responding. For a hypervisor implementation that's often better than returning error since device state is then preserved making things easier to debug. > How to implement is upto the device to figure out. what to do is also up to the device. -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/