From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>,
<pasic@linux.ibm.com>, <cohuck@redhat.com>
Cc: <virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
Parav Pandit <parav@nvidia.com>
Subject: [virtio-comment] [PATCH v6 5/8] transport-ccw: Rename queue depth/size to other transports
Date: Fri, 24 Mar 2023 04:04:29 +0300 [thread overview]
Message-ID: <20230324010432.280330-6-parav@nvidia.com> (raw)
In-Reply-To: <20230324010432.280330-1-parav@nvidia.com>
max_num field reflects the maximum queue size/depth. Hence align name of
this field with similar field in PCI and MMIO transport to
max_queue_size.
Similarly rename 'num' to 'size'.
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
v3->v4:
- moved note to comment
---
transport-ccw.tex | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/transport-ccw.tex b/transport-ccw.tex
index c492cb9..b4bc83b 100644
--- a/transport-ccw.tex
+++ b/transport-ccw.tex
@@ -237,12 +237,12 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
\begin{lstlisting}
struct vq_config_block {
be16 index;
- be16 max_num;
+ be16 max_queue_size; /* Previously named as max_num */
};
\end{lstlisting}
The requested number of buffers for queue \field{index} is returned in
-\field{max_num}.
+\field{max_queue_size}.
Afterwards, CCW_CMD_SET_VQ is issued by the driver to inform the
device about the location used for its queue. The transmitted
@@ -253,7 +253,7 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
be64 desc;
be32 res0;
be16 index;
- be16 num;
+ be16 size; /* Previously named as num */
be64 driver;
be64 device;
};
@@ -262,7 +262,8 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
\field{desc}, \field{driver} and \field{device} contain the guest
addresses for the descriptor area,
available area and used area for queue \field{index}, respectively. The actual
-virtqueue size (number of allocated buffers) is transmitted in \field{num}.
+virtqueue size (number of allocated buffers) is transmitted in
+\field{size}.
\devicenormative{\paragraph}{Configuring a Virtqueue}{Virtio Transport Options / Virtio over channel I/O / Device Initialization / Configuring a Virtqueue}
@@ -278,11 +279,12 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
be64 queue;
be32 align;
be16 index;
- be16 num;
+ be16 size; /* Previously named as num */
};
\end{lstlisting}
-\field{queue} contains the guest address for queue \field{index}, \field{num} the number of buffers
+\field{queue} contains the guest address for queue \field{index},
+\field{size} the number of buffers
and \field{align} the alignment. The queue layout follows \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Legacy Interfaces: A Note on Virtqueue Layout}~\nameref{sec:Basic Facilities of a Virtio Device / Virtqueues / Legacy Interfaces: A Note on Virtqueue Layout}.
\subsubsection{Communicating Status Information}\label{sec:Virtio Transport Options / Virtio over channel I/O / Device Initialization / Communicating Status Information}
--
2.26.2
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2023-03-24 1:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 1:04 [virtio-comment] [PATCH v6 0/8] Rename queue index to queue number Parav Pandit
2023-03-24 1:04 ` [virtio-comment] [PATCH v6 1/8] content: Add vq number text Parav Pandit
2023-03-24 1:04 ` [virtio-comment] [PATCH v6 2/8] transport-pci: Refer to the vq by its number Parav Pandit
2023-03-24 1:04 ` [virtio-comment] [PATCH v6 3/8] transport-mmio: Rename QueueNum register Parav Pandit
2023-03-24 1:04 ` [virtio-comment] [PATCH v6 4/8] transport-mmio: Refer to the vq by its number Parav Pandit
2023-03-27 10:03 ` Stefano Garzarella
2023-03-27 13:41 ` Parav Pandit
2023-03-27 13:58 ` Stefano Garzarella
2023-03-27 14:14 ` Parav Pandit
2023-03-24 1:04 ` Parav Pandit [this message]
2023-03-24 1:04 ` [virtio-comment] [PATCH v6 6/8] transport-ccw: " Parav Pandit
2023-03-24 1:04 ` [virtio-comment] [PATCH v6 7/8] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-03-24 1:04 ` [virtio-comment] [PATCH v6 8/8] virtio-net: Describe RSS using rss rq id Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324010432.280330-6-parav@nvidia.com \
--to=parav@nvidia.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).