From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33C65C6FD1F for ; Wed, 22 Mar 2023 16:44:34 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 81A8A2AF86 for ; Wed, 22 Mar 2023 16:44:33 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 6B09698645C for ; Wed, 22 Mar 2023 16:44:33 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 5F84798644E; Wed, 22 Mar 2023 16:44:33 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 4E844986450 for ; Wed, 22 Mar 2023 16:44:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: ApCGrDBwNc-8HibCCzB1iQ-1 From: Cornelia Huck To: Parav Pandit , Heng Qi , "virtio-dev@lists.oasis-open.org" , "virtio-comment@lists.oasis-open.org" Cc: "Michael S . Tsirkin" , Jason Wang , Alvaro Karsz , David Edmondson , Xuan Zhuo In-Reply-To: Organization: Red Hat GmbH References: <20230322125153.128385-1-hengqi@linux.alibaba.com> <87sfdwhkxq.fsf@redhat.com> <87pm90hhew.fsf@redhat.com> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Date: Wed, 22 Mar 2023 17:44:27 +0100 Message-ID: <87jzz8hh1w.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [virtio-comment] RE: [PATCH v13] virtio-net: support the virtqueue coalescing moderation On Wed, Mar 22 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Wednesday, March 22, 2023 12:37 PM >> >> On Wed, Mar 22 2023, Parav Pandit wrote: >> >> >> From: Cornelia Huck >> >> Sent: Wednesday, March 22, 2023 11:21 AM >> >> >> >> On Wed, Mar 22 2023, Heng Qi wrote: >> >> >> >> > +The driver MUST NOT set \field{vqn} to any value other than an >> >> > +enabled >> >> transmit or receive virtqueue number. >> >> >> > Why do you suggest a negative statement here? >> > How is it better than, >> > The driver MUST set ... >> >> So make it >> >> "The driver MUST set \field{vqn} to the virtqueue number of an enabled >> transmit or receive virtqueue." ? >> > Looks good. > >> > The device will anyway have to check and apply the parameter to the right >> virtqueue. >> > And if the vq is not enabled or vq is not tx or rx vq, it needs to fail the >> command. >> >> Well, I think we want to avoid having to add a normative statement for the >> device, so we need to be strict with what the driver is allowed to do. > Drivers are untrusted entities. > device normative statement is needed, it will do the checks anyway where it is applying the config. But isn't that implementation specific? I.e. if the driver sends junk, the device needs to be able to deal with it in any case. This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/