virtio-comment.lists.oasis-open.org archive mirror
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: Heng Qi <hengqi@linux.alibaba.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: "virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	Jason Wang <jasowang@redhat.com>,
	Yuri Benditovich <yuri.benditovich@daynix.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [virtio-comment] RE: [virtio-dev] Re: [PATCH v11] virtio-net: support inner header hash
Date: Tue, 21 Mar 2023 04:19:17 +0000	[thread overview]
Message-ID: <PH0PR12MB5481C6A8454381F508A30387DC819@PH0PR12MB5481.namprd12.prod.outlook.com> (raw)
In-Reply-To: <3a1969e7-2c4d-b64e-33b2-57311d73fb45@linux.alibaba.com>


> From: Heng Qi <hengqi@linux.alibaba.com>
> Sent: Monday, March 20, 2023 11:56 PM

> > the same flow?  If enough people agree this is needed we can accept this
> > but did you at all consider using something programmable like BPF for
> 
> I think the problem is that our virtio device cannot support ebpf, we
> can also ask Alvaro, Parav if their virtio devices can support ebpf
> offloading. :)

tc qdisc offload for qos is a better choice than ebpf to me given the role is more than just drop action.
It requires many calculations across many queues.
But such qos is orthogonal to what is being proposed here.

One (this proposal) is solving spread to different RSS queues.
Another one is finding out which exact packet to drop/pass when queue usage is high. (ebpf/tc other ways to solve it).

Ebpf sounds cooler than the real offload implementation in the hw device at the current level.
I remember Jason's good talk on the ebpf a few years back, which is possible when done in sw on the hypervisor.

On mlx5 device inner hash is supported for IPnIP and GRE tunnels.
None of the existing users see tunnel attacks when used as forwarding plane.

  reply	other threads:[~2023-03-21  4:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 11:18 [virtio-comment] [PATCH v11] virtio-net: support inner header hash Heng Qi
2023-03-20 19:43 ` [virtio-comment] " Michael S. Tsirkin
2023-03-20 21:07   ` Michael S. Tsirkin
2023-03-21  3:35   ` Jason Wang
2023-03-21  5:12     ` [virtio-comment] Re: [virtio-dev] " Heng Qi
2023-03-21  3:56   ` Heng Qi
2023-03-21  4:19     ` Parav Pandit [this message]
2023-03-21  7:37       ` Michael S. Tsirkin
2023-03-21 19:46         ` [virtio-comment] " Parav Pandit
2023-03-21 21:32           ` [virtio-comment] " Michael S. Tsirkin
2023-03-21  7:34     ` Michael S. Tsirkin
2023-03-21 14:49       ` Heng Qi
2023-03-21 15:58         ` Michael S. Tsirkin
2023-03-22 12:49           ` Heng Qi
2023-03-22 16:42             ` Michael S. Tsirkin
2023-03-23  3:13               ` [virtio-comment] " Parav Pandit
2023-03-23  3:58                 ` [virtio-comment] " Heng Qi
2023-03-23  5:03                   ` Heng Qi
2023-03-23  2:52         ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR12MB5481C6A8454381F508A30387DC819@PH0PR12MB5481.namprd12.prod.outlook.com \
    --to=parav@nvidia.com \
    --cc=alvaro.karsz@solid-run.com \
    --cc=hengqi@linux.alibaba.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=xuanzhuo@linux.alibaba.com \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).