From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 21 Feb 2023 12:13:55 -0500 From: "Michael S. Tsirkin" Subject: Re: [virtio-dev] RE: [virtio-comment] RE: [PATCH v9] virtio-net: support inner header hash Message-ID: <20230221121312-mutt-send-email-mst@kernel.org> References: <20230218143715.841-1-hengqi@linux.alibaba.com> <9ff76a6e-fd77-4cf3-a9ad-546696ab843d@linux.alibaba.com> <85de2618-6018-5436-6e8a-4d5253b42e64@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit To: Parav Pandit Cc: Heng Qi , "virtio-comment@lists.oasis-open.org" , "virtio-dev@lists.oasis-open.org" , Jason Wang , Yuri Benditovich , Cornelia Huck , Xuan Zhuo List-ID: On Tue, Feb 21, 2023 at 04:50:56PM +0000, Parav Pandit wrote: > > > From: Heng Qi > > Sent: Tuesday, February 21, 2023 11:44 AM > > > > Patch-1 to introduce the feature bit, description, and link to CVQ dependency. > > > Patch-2 for its link in virtio_net_config structure and description. > > > Patch-3 for new command touching control VQ pieces. > > > > Yes, and you seem to have missed my other replies in this thread:), I rephrased > Was it comment "And virtio_net_hash_config seems to suffice except for le16 reserved[4]." ? > I don’t see these reserved fields in the current structure. > > > it here: > > virtio_net_hash_config seems to be reusable, as the v9 patch is doing, why > > don't we re-use it? > > The reason I can think of is to not expand the virtio_net_hash_config structure, > > just set a separate structure for VIRTIO_NET_F_HASH_TUNNEL and include > > hash_tunnel_types? > > The part that I am missing is, how do to reuse virtio_net_hash_config and say ignore all the existing fields related to rss, but only consider hash_tunnel_types? Like a union? The answer is, don't. Just lay out fields one after another. -- MST