From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 21 Feb 2023 12:44:18 -0500 From: "Michael S. Tsirkin" Subject: Re: [virtio-dev] RE: [virtio-comment] RE: [PATCH v9] virtio-net: support inner header hash Message-ID: <20230221124233-mutt-send-email-mst@kernel.org> References: <20230218143715.841-1-hengqi@linux.alibaba.com> <9ff76a6e-fd77-4cf3-a9ad-546696ab843d@linux.alibaba.com> <85de2618-6018-5436-6e8a-4d5253b42e64@linux.alibaba.com> <20230221121312-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit To: Parav Pandit Cc: Heng Qi , "virtio-comment@lists.oasis-open.org" , "virtio-dev@lists.oasis-open.org" , Jason Wang , Yuri Benditovich , Cornelia Huck , Xuan Zhuo List-ID: On Tue, Feb 21, 2023 at 05:40:51PM +0000, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Tuesday, February 21, 2023 12:14 PM > > > The part that I am missing is, how do to reuse virtio_net_hash_config and say > > ignore all the existing fields related to rss, but only consider > > hash_tunnel_types? > > > > Like a union? The answer is, don't. Just lay out fields one after another. > > > In that case driver needs to fill up all the fields which are not > related to hash_tunnel_types and the device also needs to compare with > the previous config and ignore it. Doesn’t look like a good use of > existing commands and sw/fw usage for it. Shouldn’t we have the > explicit command for setting tunnel types? I don't know what's proposed at this point, this is too vague. I feel which tunnels to hash for inner header is not different from which transports to hash. If device wants to know what changes it can compare. I expect generally devices will just apply the new config without caring what changed exactly. -- MST