From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [virtio-dev] Re: [PATCH 3/3] transport-pci: Improve queue msix vector register desc
Date: Tue, 4 Apr 2023 15:08:18 -0400 [thread overview]
Message-ID: <20230404150555-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB548194B8F1C22EEB74164ABCDC939@PH0PR12MB5481.namprd12.prod.outlook.com>
On Tue, Apr 04, 2023 at 06:14:20PM +0000, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Tuesday, April 4, 2023 3:21 AM
>
> > Ok but "receiving" is confusing here. And the verb writes seems to ask for
> > direction, look at queue_desc as an example.
> >
> What is the confusion in receiving?
> Driver some reason is configuring queue's vector even if it doesn't want to "receive" interrupts?
> Do you mean it is more verbose?
I mean driver does not even receive interrupts, APIC does.
> Word here "here" isn't necessary when describing the register itself, though it exists at other places.
if nothing else let's be consistent. without here it is not immediately clear
weather it's the register that is written to or the value specified
is written somewhere else.
> > Following that example:
> >
> > The driver writes the MSI-X vector number used for virtqueue
> > interrupts here.
> >
> Since a specific number is used here, article "an" is appropriate one.
No because it's the specific value used for interrupts.
Again, check other examples.
> > would you agree?
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-04-04 19:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 1:35 [virtio-dev] [PATCH 0/3] transport-pci: msix summary update Parav Pandit
2023-03-24 1:35 ` [virtio-dev] [PATCH 1/3] transport-pci: Remove empty line at end of file Parav Pandit
2023-03-27 14:57 ` [virtio-dev] Re: [virtio-comment] " David Edmondson
2023-04-04 7:22 ` [virtio-dev] " Michael S. Tsirkin
2023-03-24 1:35 ` [virtio-dev] [PATCH 2/3] transport-pci: Improve config msix vector description Parav Pandit
2023-03-24 1:35 ` [virtio-dev] [PATCH 3/3] transport-pci: Improve queue msix vector register desc Parav Pandit
2023-04-04 7:20 ` [virtio-dev] " Michael S. Tsirkin
2023-04-04 18:14 ` [virtio-dev] " Parav Pandit
2023-04-04 19:08 ` Michael S. Tsirkin [this message]
2023-03-27 6:09 ` [virtio-dev] Re: [virtio-comment] [PATCH 0/3] transport-pci: msix summary update Xuan Zhuo
2023-04-03 22:39 ` [virtio-dev] " Parav Pandit
2023-04-04 8:28 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404150555-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=mgurtovoy@nvidia.com \
--cc=parav@nvidia.com \
--cc=pasic@linux.ibm.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).