From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D192AC761AF for ; Tue, 4 Apr 2023 08:15:18 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 243012B03C for ; Tue, 4 Apr 2023 08:15:18 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 04A229863FE for ; Tue, 4 Apr 2023 08:15:18 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id E0DDA9863E4; Tue, 4 Apr 2023 08:15:17 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id CE1A29863E5 for ; Tue, 4 Apr 2023 08:15:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: HGB1506yO4SAzZLBwt-ppg-1 From: Cornelia Huck To: Parav Pandit , "mst@redhat.com" , "virtio-dev@lists.oasis-open.org" , "pasic@linux.ibm.com" Cc: "sgarzare@redhat.com" , "virtio-comment@lists.oasis-open.org" , Shahaf Shuler In-Reply-To: Organization: Red Hat GmbH References: <20230329212341.465843-1-parav@nvidia.com> <20230329212341.465843-9-parav@nvidia.com> <87tty2fvjj.fsf@redhat.com> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Date: Tue, 04 Apr 2023 10:15:14 +0200 Message-ID: <87edp0jc6l.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: [virtio-dev] Re: [virtio-comment] RE: [PATCH v10 8/8] virtio-net: Describe RSS using rss rq id On Mon, Apr 03 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Thursday, March 30, 2023 5:17 AM >> > +Field \field{indirection_table} is an array of receive virtqueues. >> >> "an array of receive virtqueues identified via their rss_rq_id" ? > No need to make it this verbose. It is evident from the definition itself. > >> >> > >> > A driver sets \field{max_tx_vq} to inform a device how many transmit >> virtqueues it may use (transmitq1\ldots transmitq \field{max_tx_vq}). >> > >> > @@ -1455,7 +1465,8 @@ \subsubsection{Control >> > Virtqueue}\label{sec:Device Types / Network Device / Devi >> > >> > A driver MUST NOT send the VIRTIO_NET_CTRL_MQ_RSS_CONFIG command >> if the feature VIRTIO_NET_F_RSS has not been negotiated. >> > >> > -A driver MUST fill the \field{indirection_table} array only with indices of >> enabled queues. Index 0 corresponds to receiveq1. >> > +A driver MUST fill the \field{indirection_table} array only with >> > +enabled receive virtqueues. >> >> "only with rss_rq_id references to enabled receive virtqueues" ? >> > In this field and other fields, we just refer to the receive virtqueues as rss_rq_id parent structure itself is describing what it is. > Hence, we omit re-iterating rss_rq_id at multiple places. Personally, I'd prefer to spell it out, as it is a specific way to refer to a virtqueue. --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org