From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57104C761A6 for ; Mon, 27 Mar 2023 13:58:58 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 8226177BE6 for ; Mon, 27 Mar 2023 13:58:57 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 727C89862BC for ; Mon, 27 Mar 2023 13:58:57 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 5B266983BC4; Mon, 27 Mar 2023 13:58:57 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 4992E986260 for ; Mon, 27 Mar 2023 13:58:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: _xTRsHxhOTKvn4M_cBFqhg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679925535; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YPfhbi4ppX7g1qo8+ecVLetzD3bvlLf5CF/fjOmYMPg=; b=65UvduYcI+gbn1B+H0+f36bZn4orbr0stfMp6M5GyThbEiaqRciUvKCmbGH4+KGrXC PpwOJunVB2mtMGXNEssLP86kraIJgzv2QLbhSCaxwNlRDlIHImv91AKgTx+xdlLs61vb wqYCU3icgZBz1xL2+wVklFBJyVsK603R/YSB09tYehwiv/dzHp65WvYMa8VD+70jptho NYSqjRtQricgyByAk3vzFpJ9wxSeqcCiM+7a35/W2v3w35w6mm1u6MZOQJGQ0I5M5TDP FhFeep+vNSMJ4rS1IUraeO0h1/QedjFEzF0rG4acgpOqQyb18coW+EsFbmZ8clyB97f+ T8cg== X-Gm-Message-State: AAQBX9dlBgOtlUfWq12Yyhk06wARabxMPRiYAYh0g8pTB6LXiBPq2Ltl Qy6GKT8kliU6F8UeBarC+tcc9I5qOlXPUZUKMf0PLgQIVhDAB8zgl50OGScCKsbJzA+Yh2Njk8e bKjIHKF5RVPAkAkPcFQ9/6ZYEyAps X-Received: by 2002:a05:6214:2628:b0:5b9:ff75:a011 with SMTP id gv8-20020a056214262800b005b9ff75a011mr21329280qvb.48.1679925534999; Mon, 27 Mar 2023 06:58:54 -0700 (PDT) X-Google-Smtp-Source: AKy350aWa08N2OzIRvtDmgtggOsKTeO7gI2bfjx+G3vI8zu2plP//u37pdUjY+5J9GyQTi9dIpBF5g== X-Received: by 2002:a05:6214:2628:b0:5b9:ff75:a011 with SMTP id gv8-20020a056214262800b005b9ff75a011mr21329248qvb.48.1679925534686; Mon, 27 Mar 2023 06:58:54 -0700 (PDT) Date: Mon, 27 Mar 2023 15:58:49 +0200 From: Stefano Garzarella To: Parav Pandit Cc: "mst@redhat.com" , "virtio-dev@lists.oasis-open.org" , "pasic@linux.ibm.com" , "cohuck@redhat.com" , "virtio-comment@lists.oasis-open.org" , Shahaf Shuler , Jiri Pirko Message-ID: References: <20230324010432.280330-1-parav@nvidia.com> <20230324010432.280330-5-parav@nvidia.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Subject: [virtio-dev] Re: [virtio-comment] [PATCH v6 4/8] transport-mmio: Refer to the vq by its number On Mon, Mar 27, 2023 at 01:41:33PM +0000, Parav Pandit wrote: >Hi Stefano, > >> From: Stefano Garzarella >> Sent: Monday, March 27, 2023 6:04 AM > >> Maybe we can also remove `index` from the last sentence in this section. >> I mean something like this: >> >> --- a/transport-mmio.tex >> +++ b/transport-mmio.tex >> @@ -113,8 +113,8 @@ \subsection{MMIO Device Register >> Layout}\label{sec:Virtio Transport Options / Vi >> following operations on \field{QueueSizeMax}, >> \field{QueueSize}, \field{QueueReady}, >> \field{QueueDescLow}, \field{QueueDescHigh}, \field{QueueDriverlLow}, >> \field{QueueDriverHigh}, >> - \field{QueueDeviceLow}, \field{QueueDeviceHigh} and \field{QueueReset} >> apply to. The index >> - number of the first queue is zero (0x0). >> + \field{QueueDeviceLow}, \field{QueueDeviceHigh} and \field{QueueReset} >> apply to. >> + The number of the first queue is zero (0x0). >> } >> \hline >> \mmioreg{QueueSizeMax}{Maximum virtual queue size}{0x034}{R}{% >> >> Thanks, >> Stefano >> >With Michael suggestion, the first patch describes the vq number range. I see. >I think we can drop this duplicate text from here all together. > Yep, I agree on that. Thanks, Stefano --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org