From: Jason Wang <jasowang@redhat.com>
To: Bjorn Helgaas <helgaas@kernel.org>, linux-kernel@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 2/2] virtio-mmio: Reject invalid IRQ 0 command line argument
Date: Thu, 2 Jul 2020 11:06:11 +0800 [thread overview]
Message-ID: <032d0424-4876-6322-76d2-d733db28addb@redhat.com> (raw)
In-Reply-To: <20200701221040.3667868-3-helgaas@kernel.org>
On 2020/7/2 上午6:10, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> The "virtio_mmio.device=" command line argument allows a user to specify
> the size, address, and IRQ of a virtio device. Previously the only
> requirement for the IRQ was that it be an unsigned integer.
>
> Zero is an unsigned integer but an invalid IRQ number, and after
> a85a6c86c25be ("driver core: platform: Clarify that IRQ 0 is invalid"),
> attempts to use IRQ 0 cause warnings.
>
> If the user specifies IRQ 0, return failure instead of registering a device
> with IRQ 0.
>
> Fixes: a85a6c86c25be ("driver core: platform: Clarify that IRQ 0 is invalid")
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: virtualization@lists.linux-foundation.org
> ---
> drivers/virtio/virtio_mmio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index 9d16aaffca9d..627ac0487494 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -641,11 +641,11 @@ static int vm_cmdline_set(const char *device,
> &vm_cmdline_id, &consumed);
>
> /*
> - * sscanf() must processes at least 2 chunks; also there
> + * sscanf() must process at least 2 chunks; also there
> * must be no extra characters after the last chunk, so
> * str[consumed] must be '\0'
> */
> - if (processed < 2 || str[consumed])
> + if (processed < 2 || str[consumed] || irq == 0)
> return -EINVAL;
>
> resources[0].flags = IORESOURCE_MEM;
Acked-by: Jason Wang <jasowang@redhat.com>
next prev parent reply other threads:[~2020-07-02 3:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200701221040.3667868-1-helgaas@kernel.org>
2020-07-01 22:10 ` [PATCH 2/2] virtio-mmio: Reject invalid IRQ 0 command line argument Bjorn Helgaas
2020-07-02 3:06 ` Jason Wang [this message]
2020-07-21 22:12 ` Bjorn Helgaas
2020-07-22 11:46 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=032d0424-4876-6322-76d2-d733db28addb@redhat.com \
--to=jasowang@redhat.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).