* [PATCH] drm/virtio: fix memory leak in virtio_gpu_cleanup_object()
@ 2020-07-22 5:18 Xin He
2020-08-07 12:43 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: Xin He @ 2020-07-22 5:18 UTC (permalink / raw)
To: airlied, kraxel, daniel
Cc: dri-devel, virtualization, linux-kernel, Xin He, Qi Liu
Before setting shmem->pages to NULL, kfree() should
be called.
Signed-off-by: Xin He <hexin.op@bytedance.com>
Reviewed-by: Qi Liu <liuqi.16@bytedance.com>
---
drivers/gpu/drm/virtio/virtgpu_object.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c
index 6ccbd01cd888..703b5cd51751 100644
--- a/drivers/gpu/drm/virtio/virtgpu_object.c
+++ b/drivers/gpu/drm/virtio/virtgpu_object.c
@@ -79,6 +79,7 @@ void virtio_gpu_cleanup_object(struct virtio_gpu_object *bo)
}
sg_free_table(shmem->pages);
+ kfree(shmem->pages);
shmem->pages = NULL;
drm_gem_shmem_unpin(&bo->base.base);
}
--
2.21.1 (Apple Git-122.3)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/virtio: fix memory leak in virtio_gpu_cleanup_object()
2020-07-22 5:18 [PATCH] drm/virtio: fix memory leak in virtio_gpu_cleanup_object() Xin He
@ 2020-08-07 12:43 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2020-08-07 12:43 UTC (permalink / raw)
To: Xin He; +Cc: airlied, linux-kernel, dri-devel, virtualization, daniel, Qi Liu
On Wed, Jul 22, 2020 at 01:18:51PM +0800, Xin He wrote:
> Before setting shmem->pages to NULL, kfree() should
> be called.
> sg_free_table(shmem->pages);
> + kfree(shmem->pages);
> shmem->pages = NULL;
Pushed to drm-misc-fixes.
thanks,
Gerd
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-07 12:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-22 5:18 [PATCH] drm/virtio: fix memory leak in virtio_gpu_cleanup_object() Xin He
2020-08-07 12:43 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).