From: Stefano Garzarella <sgarzare@redhat.com>
To: Yongji Xie <xieyongji@bytedance.com>
Cc: Jens Axboe <axboe@kernel.dk>, Jonathan Corbet <corbet@lwn.net>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
linux-aio@kvack.org, netdev@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>,
Matthew Wilcox <willy@infradead.org>,
virtualization@lists.linux-foundation.org,
Christoph Hellwig <hch@infradead.org>,
Bob Liu <bob.liu@oracle.com>,
bcrl@kvack.org, viro@zeniv.linux.org.uk,
Stefan Hajnoczi <stefanha@redhat.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC v3 03/11] vdpa: Remove the restriction that only supports virtio-net devices
Date: Mon, 1 Feb 2021 12:05:21 +0100 [thread overview]
Message-ID: <20210201110521.o3m6temcw3nmkiea@steredhat> (raw)
In-Reply-To: <CACycT3sTx+NGg1iB8gmFbOPfzCvnq5F0nd2ePGs2_BUeU=-2_Q@mail.gmail.com>
On Sat, Jan 30, 2021 at 07:33:08PM +0800, Yongji Xie wrote:
>On Fri, Jan 29, 2021 at 11:04 PM Stefano Garzarella <sgarzare@redhat.com> wrote:
>>
>> On Thu, Jan 28, 2021 at 11:11:49AM +0800, Jason Wang wrote:
>> >
>> >On 2021/1/27 下午4:57, Stefano Garzarella wrote:
>> >>On Wed, Jan 27, 2021 at 11:33:03AM +0800, Jason Wang wrote:
>> >>>
>> >>>On 2021/1/20 下午7:08, Stefano Garzarella wrote:
>> >>>>On Wed, Jan 20, 2021 at 11:46:38AM +0800, Jason Wang wrote:
>> >>>>>
>> >>>>>On 2021/1/19 下午12:59, Xie Yongji wrote:
>> >>>>>>With VDUSE, we should be able to support all kinds of virtio devices.
>> >>>>>>
>> >>>>>>Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
>> >>>>>>---
>> >>>>>> drivers/vhost/vdpa.c | 29 +++--------------------------
>> >>>>>> 1 file changed, 3 insertions(+), 26 deletions(-)
>> >>>>>>
>> >>>>>>diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
>> >>>>>>index 29ed4173f04e..448be7875b6d 100644
>> >>>>>>--- a/drivers/vhost/vdpa.c
>> >>>>>>+++ b/drivers/vhost/vdpa.c
>> >>>>>>@@ -22,6 +22,7 @@
>> >>>>>> #include <linux/nospec.h>
>> >>>>>> #include <linux/vhost.h>
>> >>>>>> #include <linux/virtio_net.h>
>> >>>>>>+#include <linux/virtio_blk.h>
>> >>>>>> #include "vhost.h"
>> >>>>>>@@ -185,26 +186,6 @@ static long
>> >>>>>>vhost_vdpa_set_status(struct vhost_vdpa *v, u8 __user
>> >>>>>>*statusp)
>> >>>>>> return 0;
>> >>>>>> }
>> >>>>>>-static int vhost_vdpa_config_validate(struct vhost_vdpa *v,
>> >>>>>>- struct vhost_vdpa_config *c)
>> >>>>>>-{
>> >>>>>>- long size = 0;
>> >>>>>>-
>> >>>>>>- switch (v->virtio_id) {
>> >>>>>>- case VIRTIO_ID_NET:
>> >>>>>>- size = sizeof(struct virtio_net_config);
>> >>>>>>- break;
>> >>>>>>- }
>> >>>>>>-
>> >>>>>>- if (c->len == 0)
>> >>>>>>- return -EINVAL;
>> >>>>>>-
>> >>>>>>- if (c->len > size - c->off)
>> >>>>>>- return -E2BIG;
>> >>>>>>-
>> >>>>>>- return 0;
>> >>>>>>-}
>> >>>>>
>> >>>>>
>> >>>>>I think we should use a separate patch for this.
>> >>>>
>> >>>>For the vdpa-blk simulator I had the same issues and I'm adding
>> >>>>a .get_config_size() callback to vdpa devices.
>> >>>>
>> >>>>Do you think make sense or is better to remove this check in
>> >>>>vhost/vdpa, delegating the boundaries checks to
>> >>>>get_config/set_config callbacks.
>> >>>
>> >>>
>> >>>A question here. How much value could we gain from
>> >>>get_config_size() consider we can let vDPA parent to validate the
>> >>>length in its get_config().
>> >>>
>> >>
>> >>I agree, most of the implementations already validate the length,
>> >>the only gain is an error returned since get_config() is void, but
>> >>eventually we can add a return value to it.
>> >
>> >
>> >Right, one problem here is that. For the virito path, its get_config()
>> >returns void. So we can not propagate error to virtio drivers. But it
>> >might not be a big issue since we trust kernel virtio driver.
>> >
>> >So I think it makes sense to change the return value in the vdpa config ops.
>>
>> Thanks for your feedback!
>>
>> @Xie do you plan to do this?
>>
>> Otherwise I can do in my vdpa-blk-sim series, where for now I used this
>> patch as is.
>>
>
>Hi Stefano, please do in your vdpa-blk-sim series. I have no plan for
>it now.
Okay, I'll do it.
Thanks,
Stefano
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-02-01 11:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210119045920.447-1-xieyongji@bytedance.com>
[not found] ` <20210119045920.447-5-xieyongji@bytedance.com>
2021-01-20 3:44 ` [RFC v3 04/11] vhost-vdpa: protect concurrent access to vhost device iotlb Jason Wang
[not found] ` <20210119045920.447-2-xieyongji@bytedance.com>
2021-01-20 4:24 ` [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases Jason Wang
[not found] ` <CACycT3sN0+dg-NubAK+N-DWf3UDXwWh=RyRX-qC9fwdg3QaLWA@mail.gmail.com>
2021-01-27 3:37 ` Jason Wang
[not found] ` <CACycT3sqDgccOfNcY_FNcHDqJ2DeMbigdFuHYm9DxWWMjkL7CQ@mail.gmail.com>
2021-01-28 3:04 ` Jason Wang
2021-01-28 3:08 ` Jens Axboe
[not found] ` <CACycT3u6Ayf_X8Mv4EvF+B=B4OzFSK8ygvJMRnO6CDgYF13Qnw@mail.gmail.com>
2021-01-28 4:31 ` Jason Wang
[not found] ` <20210119045920.447-6-xieyongji@bytedance.com>
2021-01-20 5:55 ` [RFC v3 05/11] vdpa: shared virtual addressing support Jason Wang
[not found] ` <CACycT3vXCaSc9Er3yzRAzf8-eEFgpQYmEaDy3129xPdb4AFdmA@mail.gmail.com>
2021-01-27 3:43 ` Jason Wang
[not found] ` <20210119045920.447-7-xieyongji@bytedance.com>
2021-01-20 6:24 ` [RFC v3 06/11] vhost-vdpa: Add an opaque pointer for vhost IOTLB Jason Wang
[not found] ` <CACycT3voF9x4o95XtLtkKF-i261JXMMsYR1PgssYFwg15jZXQA@mail.gmail.com>
2021-01-27 3:51 ` Jason Wang
[not found] ` <20210119050756.600-1-xieyongji@bytedance.com>
[not found] ` <20210119050756.600-2-xieyongji@bytedance.com>
2021-01-19 14:53 ` [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace Jonathan Corbet
2021-01-19 17:53 ` Randy Dunlap
2021-01-26 8:08 ` Jason Wang
[not found] ` <CACycT3uJtKqEp7CHBKhvmSL41gTrCcMrt_-tacGCbX1nabuG6w@mail.gmail.com>
2021-01-28 4:27 ` Jason Wang
[not found] ` <CACycT3upvTrkm5Cd6KzphSk=FYDjAVCbFJ0CLmha5sP_h=5KGg@mail.gmail.com>
2021-01-28 6:14 ` Jason Wang
2021-01-26 8:19 ` Jason Wang
[not found] ` <20210119050756.600-4-xieyongji@bytedance.com>
2021-01-26 8:09 ` [RFC v3 10/11] vduse: grab the module's references until there is no vduse device Jason Wang
[not found] ` <20210119050756.600-5-xieyongji@bytedance.com>
2021-01-26 8:17 ` [RFC v3 11/11] vduse: Introduce a workqueue for irq injection Jason Wang
[not found] ` <20210119045920.447-4-xieyongji@bytedance.com>
2021-01-20 3:46 ` [RFC v3 03/11] vdpa: Remove the restriction that only supports virtio-net devices Jason Wang
2021-01-20 11:08 ` Stefano Garzarella
2021-01-27 3:33 ` Jason Wang
2021-01-27 8:57 ` Stefano Garzarella
2021-01-28 3:11 ` Jason Wang
2021-01-29 15:03 ` Stefano Garzarella
[not found] ` <CACycT3sTx+NGg1iB8gmFbOPfzCvnq5F0nd2ePGs2_BUeU=-2_Q@mail.gmail.com>
2021-02-01 11:05 ` Stefano Garzarella [this message]
2021-01-27 8:59 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201110521.o3m6temcw3nmkiea@steredhat \
--to=sgarzare@redhat.com \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=bob.liu@oracle.com \
--cc=corbet@lwn.net \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=stefanha@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@infradead.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).