From: Cornelia Huck <cohuck@redhat.com>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: kvm@vger.kernel.org, mst@redhat.com,
virtualization@lists.linux-foundation.org, nitzanc@nvidia.com,
oren@nvidia.com
Subject: Re: [PATCH 1/3] virtio: update reset callback to return status
Date: Wed, 7 Apr 2021 15:44:44 +0200 [thread overview]
Message-ID: <20210407154444.04d6304b.cohuck@redhat.com> (raw)
In-Reply-To: <20210407120924.133294-1-mgurtovoy@nvidia.com>
On Wed, 7 Apr 2021 12:09:22 +0000
Max Gurtovoy <mgurtovoy@nvidia.com> wrote:
> The reset device operation, usually is an operation that might fail from
> various reasons. For example, the controller might be in a bad state and
> can't answer to any request. Usually, the paravirt SW based virtio
> devices always succeed in reset operation but this is not the case for
> HW based virtio devices.
>
> This commit is also a preparation for adding a timeout mechanism for
> resetting virtio devices.
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
> drivers/remoteproc/remoteproc_virtio.c | 3 ++-
> drivers/virtio/virtio.c | 22 +++++++++++++++-------
> drivers/virtio/virtio_mmio.c | 3 ++-
> drivers/virtio/virtio_pci_legacy.c | 3 ++-
> drivers/virtio/virtio_pci_modern.c | 3 ++-
> drivers/virtio/virtio_vdpa.c | 3 ++-
> include/linux/virtio_config.h | 5 +++--
> 7 files changed, 28 insertions(+), 14 deletions(-)
You missed drivers/s390/virtio/virtio_ccw.c.
virtio_ccw_reset() should probably return -ENOMEM on allocation failure
and forward the return code of ccw_io_helper().
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next parent reply other threads:[~2021-04-07 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210407120924.133294-1-mgurtovoy@nvidia.com>
2021-04-07 13:44 ` Cornelia Huck [this message]
[not found] ` <20210407120924.133294-2-mgurtovoy@nvidia.com>
2021-04-07 13:45 ` [PATCH 2/3] virito_pci: add timeout to reset device operation Michael S. Tsirkin
2021-04-07 17:51 ` [PATCH 1/3] virtio: update reset callback to return status kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407154444.04d6304b.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=nitzanc@nvidia.com \
--cc=oren@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).