From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yongji Xie <xieyongji@bytedance.com>
Cc: "Jens Axboe" <axboe@kernel.dk>,
kvm@vger.kernel.org, "Jonathan Corbet" <corbet@lwn.net>,
netdev@vger.kernel.org, "Randy Dunlap" <rdunlap@infradead.org>,
"Matthew Wilcox" <willy@infradead.org>,
virtualization@lists.linux-foundation.org,
"Christoph Hellwig" <hch@infradead.org>,
"Christian Brauner" <christian.brauner@canonical.com>,
bcrl@kvack.org, viro@zeniv.linux.org.uk,
"Stefan Hajnoczi" <stefanha@redhat.com>,
linux-fsdevel@vger.kernel.org,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Mika Penttilä" <mika.penttila@nextfour.com>
Subject: Re: Re: Re: [PATCH v6 03/10] vhost-vdpa: protect concurrent access to vhost device iotlb
Date: Mon, 12 Apr 2021 05:00:33 -0400 [thread overview]
Message-ID: <20210412045900-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACycT3v5Z8s9_pL79m0FY5jxx3fTRHHbtARfg0On3xTnNCOdkg@mail.gmail.com>
On Mon, Apr 12, 2021 at 10:29:17AM +0800, Yongji Xie wrote:
> On Mon, Apr 12, 2021 at 4:49 AM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Sun, Apr 11, 2021 at 01:36:18PM +0800, Yongji Xie wrote:
> > > On Sat, Apr 10, 2021 at 12:16 AM Michael S. Tsirkin <mst@redhat.com> wrote:
> > > >
> > > > On Wed, Mar 31, 2021 at 04:05:12PM +0800, Xie Yongji wrote:
> > > > > Use vhost_dev->mutex to protect vhost device iotlb from
> > > > > concurrent access.
> > > > >
> > > > > Fixes: 4c8cf318("vhost: introduce vDPA-based backend")
> > > > > Cc: stable@vger.kernel.org
> > > > > Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
> > > > > Acked-by: Jason Wang <jasowang@redhat.com>
> > > > > Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
> > > >
> > > > I could not figure out whether there's a bug there now.
> > > > If yes when is the concurrent access triggered?
> > > >
> > >
> > > When userspace sends the VHOST_IOTLB_MSG_V2 message concurrently?
> > >
> > > vhost_vdpa_chr_write_iter -> vhost_chr_write_iter ->
> > > vhost_vdpa_process_iotlb_msg()
> > >
> > > Thanks,
> > > Yongji
> >
> > And then what happens currently?
> >
>
> Then we might access vhost_vdpa_map() concurrently and cause
> corruption of the list and interval tree in struct vhost_iotlb.
>
> Thanks,
> Yongji
OK. Sounds like it's actually needed in this release if possible. Pls
add this info in the commit log and post it as a separate patch.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-04-12 9:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210331080519.172-1-xieyongji@bytedance.com>
[not found] ` <20210331080519.172-2-xieyongji@bytedance.com>
[not found] ` <20210331091545.lr572rwpyvrnji3w@wittgenstein>
2021-03-31 9:26 ` [PATCH v6 01/10] file: Export receive_fd() to modules Dan Carpenter
[not found] ` <20210331080519.172-8-xieyongji@bytedance.com>
2021-04-08 2:36 ` [PATCH v6 07/10] vdpa: Support transferring virtual addressing during DMA mapping Jason Wang
[not found] ` <20210331080519.172-9-xieyongji@bytedance.com>
2021-04-08 3:25 ` [PATCH v6 08/10] vduse: Implement an MMU-based IOMMU driver Jason Wang
[not found] ` <20210331080519.172-10-xieyongji@bytedance.com>
2021-04-08 6:57 ` [PATCH v6 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace Jason Wang
[not found] ` <CACycT3v_KFQXoxRbEj8c0Ve6iKn9RbibtBDgBFs=rf0ZOmTBBQ@mail.gmail.com>
2021-04-09 5:36 ` Jason Wang
[not found] ` <CACycT3vwATp4+Ao0fjuyeeLQN+xHH=dXF+JUyuitkn4k8hELnA@mail.gmail.com>
2021-04-12 7:16 ` Jason Wang
[not found] ` <CACycT3vxO21Yt6+px2c2Q8DONNUNehdo2Vez_RKQCKe76CM2TA@mail.gmail.com>
2021-04-12 9:37 ` Jason Wang
[not found] ` <CACycT3vbDhUKM0OX-zo02go09gh2+EEdyZ_YQuz8PXzo3EngXw@mail.gmail.com>
2021-04-13 3:35 ` Jason Wang
[not found] ` <CACycT3tHxtfgQhQgv0VyF_U523qASEv1Ydc4XuX43MFRzGVbfw@mail.gmail.com>
2021-04-14 8:18 ` Jason Wang
2021-04-16 3:24 ` Jason Wang
[not found] ` <20210331080519.172-4-xieyongji@bytedance.com>
2021-04-09 16:15 ` [PATCH v6 03/10] vhost-vdpa: protect concurrent access to vhost device iotlb Michael S. Tsirkin
[not found] ` <CACycT3tPWwpGBNEqiL4NPrwGZhmUtAVHUZMOdbSHzjhN-ytg_A@mail.gmail.com>
2021-04-11 20:48 ` Michael S. Tsirkin
[not found] ` <CACycT3v5Z8s9_pL79m0FY5jxx3fTRHHbtARfg0On3xTnNCOdkg@mail.gmail.com>
2021-04-12 9:00 ` Michael S. Tsirkin [this message]
2021-04-14 7:34 ` [PATCH v6 00/10] Introduce VDUSE - vDPA Device in Userspace Michael S. Tsirkin
2021-04-14 7:49 ` Jason Wang
[not found] ` <20210331080519.172-11-xieyongji@bytedance.com>
2021-04-08 7:18 ` [PATCH v6 10/10] Documentation: Add documentation for VDUSE Jason Wang
2021-04-14 14:14 ` Stefan Hajnoczi
[not found] ` <CACycT3uNR+nZY5gY0UhPkeOyi7Za6XkX4b=hasuDcgqdc7fqfg@mail.gmail.com>
2021-04-15 7:19 ` Stefan Hajnoczi
2021-04-15 8:36 ` Jason Wang
2021-04-15 9:04 ` Jason Wang
[not found] ` <CACycT3tL7URz3n-KhMAwYH+Sn1e1TSyfU+RKcc8jpPDJ7WcZ2w@mail.gmail.com>
2021-04-16 2:20 ` Jason Wang
[not found] ` <CACycT3tyksBYxgbQLFJ-mFCKkaWotucM5_ho_K3q4wMpR0P=gw@mail.gmail.com>
2021-04-16 3:02 ` Jason Wang
2021-04-15 14:38 ` Stefan Hajnoczi
2021-04-16 2:23 ` Jason Wang
[not found] ` <CACycT3u_qAE=D_ezLPU9SpXPMACErmpqpH5pMg0TZAb3CZVGdg@mail.gmail.com>
2021-04-16 5:39 ` Jason Wang
[not found] ` <CACycT3tRN1n_PJm1mu3=s1dK941Pac15cpaysqZZKLR6xKaXSg@mail.gmail.com>
2021-04-15 14:17 ` Re: " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412045900-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=christian.brauner@canonical.com \
--cc=corbet@lwn.net \
--cc=dan.carpenter@oracle.com \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mika.penttila@nextfour.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=stefanha@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@infradead.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).