virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Eli Cohen <elic@nvidia.com>,
	mst@redhat.com, parav@nvidia.com, si-wei.liu@oracle.com,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 3/5] vdpa/mlx5: Retrieve BAR address suitable any function
Date: Thu, 8 Apr 2021 17:45:22 +0800	[thread overview]
Message-ID: <67feb53c-91dc-f299-0c83-ce459cb0da5e@redhat.com> (raw)
In-Reply-To: <20210408091047.4269-4-elic@nvidia.com>


在 2021/4/8 下午5:10, Eli Cohen 写道:
> struct mlx5_core_dev has a bar_addr field that contains the correct bar
> address for the function regardless of whether it is pci function or sub
> function. Use it.
>
> Fixes: 1958fc2f0712 ("net/mlx5: SF, Add auxiliary device driver")
> Signed-off-by: Eli Cohen <elic@nvidia.com>
> Reviewed-by: Parav Pandit <parav@nvidia.com>


Acked-by: Jason Wang <jasowang@redhat.com>


> ---
>   drivers/vdpa/mlx5/core/resources.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/mlx5/core/resources.c b/drivers/vdpa/mlx5/core/resources.c
> index 96e6421c5d1c..6521cbd0f5c2 100644
> --- a/drivers/vdpa/mlx5/core/resources.c
> +++ b/drivers/vdpa/mlx5/core/resources.c
> @@ -246,7 +246,8 @@ int mlx5_vdpa_alloc_resources(struct mlx5_vdpa_dev *mvdev)
>   	if (err)
>   		goto err_key;
>   
> -	kick_addr = pci_resource_start(mdev->pdev, 0) + offset;
> +	kick_addr = mdev->bar_addr + offset;
> +
>   	res->kick_addr = ioremap(kick_addr, PAGE_SIZE);
>   	if (!res->kick_addr) {
>   		err = -ENOMEM;

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2021-04-08  9:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210408091047.4269-1-elic@nvidia.com>
2021-04-08  9:17 ` [PATCH 0/5] VDPA mlx5 fixes Greg KH
     [not found] ` <20210408091047.4269-3-elic@nvidia.com>
2021-04-08  9:44   ` [PATCH 2/5] vdpa/mlx5: Use the correct dma device when registering memory Jason Wang
     [not found] ` <20210408091047.4269-4-elic@nvidia.com>
2021-04-08  9:45   ` Jason Wang [this message]
     [not found] ` <20210408091047.4269-6-elic@nvidia.com>
2021-04-08  9:45   ` [PATCH 5/5] vdpa/mlx5: Fix suspend/resume index restoration Jason Wang
     [not found] ` <20210408091047.4269-5-elic@nvidia.com>
2021-04-08  9:46   ` [PATCH 4/5] vdpa/mlx5: Fix wrong use of bit numbers Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67feb53c-91dc-f299-0c83-ce459cb0da5e@redhat.com \
    --to=jasowang@redhat.com \
    --cc=elic@nvidia.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=parav@nvidia.com \
    --cc=si-wei.liu@oracle.com \
    --cc=stable@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).