* Re: [PATCH v1] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call
[not found] <20210112024648.31428-1-lulu@redhat.com>
@ 2021-01-12 3:17 ` Jason Wang
0 siblings, 0 replies; only message in thread
From: Jason Wang @ 2021-01-12 3:17 UTC (permalink / raw)
To: Cindy Lu, kvm, linux-kernel, virtualization, netdev, lingshan.zhu
On 2021/1/12 上午10:46, Cindy Lu wrote:
> in vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa.
Should be "In"
> this cb.private will finally use in vhost_vdpa_config_cb as
> vhost_vdpa.Fix this issue
An whitespace is needed before Fix and a full stop after "issue"
Fixes: 776f395004d82 ("vhost_vdpa: Support config interrupt in vdpa")
Acked-by: Jason Wang <jasowang@redhat.com>
Please post a V2 with the above fixed and cc stable.
Thanks
>
> Signed-off-by: Cindy Lu <lulu@redhat.com>
> ---
> drivers/vhost/vdpa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index ef688c8c0e0e..3fbb9c1f49da 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c
> @@ -319,7 +319,7 @@ static long vhost_vdpa_set_config_call(struct vhost_vdpa *v, u32 __user *argp)
> struct eventfd_ctx *ctx;
>
> cb.callback = vhost_vdpa_config_cb;
> - cb.private = v->vdpa;
> + cb.private = v;
> if (copy_from_user(&fd, argp, sizeof(fd)))
> return -EFAULT;
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-01-12 3:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210112024648.31428-1-lulu@redhat.com>
2021-01-12 3:17 ` [PATCH v1] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).