From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: wei.yang1@linux.alibaba.com,
Wu Zongyong <wuzongyong@linux.alibaba.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v2 4/5] vdpa: add new vdpa attribute VDPA_ATTR_DEV_F_VERSION_1
Date: Wed, 15 Sep 2021 16:06:57 +0800 [thread overview]
Message-ID: <CACGkMEtN0Z=rgMhaWNO=6h-KXGdosBuOdqoWoND-=Tf+afyUYw@mail.gmail.com> (raw)
In-Reply-To: <20210915033756-mutt-send-email-mst@kernel.org>
On Wed, Sep 15, 2021 at 3:38 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Wed, Sep 15, 2021 at 11:18:06AM +0800, Jason Wang wrote:
> > On Tue, Sep 14, 2021 at 8:58 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> > >
> > > On Tue, Sep 14, 2021 at 08:24:51PM +0800, Wu Zongyong wrote:
> > > > This new attribute advertises whether the vdpa device is legacy or not.
> > > > Users can pick right virtqueue size if the vdpa device is legacy which
> > > > doesn't support to change virtqueue size.
> > > >
> > > > Signed-off-by: Wu Zongyong <wuzongyong@linux.alibaba.com>
> > >
> > > So if we are bothering with legacy,
> >
> > I think we'd better not. I guess the following may work:
> >
> > 1) disable the driver on BE host
> > 2) present VERSION_1 with ACCESS_PLATFORM in get_features()
> > 3) extend the management to advertise max_queue_size and
> > min_queue_size, for ENI they are the same so management layer knows it
> > needs to set the queue_size correctly during launching qemu
> >
> > Thoughts?
> >
> > Thanks
>
> There are other subtle differences such as header size without
> mergeable buffers for net.
This can be solved by mandating the feature of a mergeable buffer?
Thanks
>
>
> > > I think there are
> > > several things to do when building the interface
> > > - support transitional devices, that is allow userspace
> > > to tell device it's in legacy mode
> > > - support reporting/setting supporting endian-ness
> > >
> > > > ---
> > > > drivers/vdpa/vdpa.c | 6 ++++++
> > > > drivers/virtio/virtio_vdpa.c | 7 ++++++-
> > > > include/uapi/linux/vdpa.h | 1 +
> > > > 3 files changed, 13 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
> > > > index 1dc121a07a93..533d7f589eee 100644
> > > > --- a/drivers/vdpa/vdpa.c
> > > > +++ b/drivers/vdpa/vdpa.c
> > > > @@ -12,6 +12,7 @@
> > > > #include <linux/slab.h>
> > > > #include <linux/vdpa.h>
> > > > #include <uapi/linux/vdpa.h>
> > > > +#include <uapi/linux/virtio_config.h>
> > > > #include <net/genetlink.h>
> > > > #include <linux/mod_devicetable.h>
> > > >
> > > > @@ -494,6 +495,7 @@ vdpa_dev_fill(struct vdpa_device *vdev, struct sk_buff *msg, u32 portid, u32 seq
> > > > u16 max_vq_size;
> > > > u32 device_id;
> > > > u32 vendor_id;
> > > > + u64 features;
> > > > void *hdr;
> > > > int err;
> > > >
> > > > @@ -508,6 +510,7 @@ vdpa_dev_fill(struct vdpa_device *vdev, struct sk_buff *msg, u32 portid, u32 seq
> > > > device_id = vdev->config->get_device_id(vdev);
> > > > vendor_id = vdev->config->get_vendor_id(vdev);
> > > > max_vq_size = vdev->config->get_vq_num_max(vdev);
> > > > + features = vdev->config->get_features(vdev);
> > > >
> > > > err = -EMSGSIZE;
> > > > if (nla_put_string(msg, VDPA_ATTR_DEV_NAME, dev_name(&vdev->dev)))
> > > > @@ -520,6 +523,9 @@ vdpa_dev_fill(struct vdpa_device *vdev, struct sk_buff *msg, u32 portid, u32 seq
> > > > goto msg_err;
> > > > if (nla_put_u16(msg, VDPA_ATTR_DEV_MAX_VQ_SIZE, max_vq_size))
> > > > goto msg_err;
> > > > + if (features & BIT_ULL(VIRTIO_F_VERSION_1) &&
> > > > + nla_put_flag(msg, VDPA_ATTR_DEV_VERSION_1))
> > > > + goto msg_err;
> > > >
> > > > genlmsg_end(msg, hdr);
> > > > return 0;
> > > > diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
> > > > index 72eaef2caeb1..1cba957c4cdc 100644
> > > > --- a/drivers/virtio/virtio_vdpa.c
> > > > +++ b/drivers/virtio/virtio_vdpa.c
> > > > @@ -7,6 +7,7 @@
> > > > *
> > > > */
> > > >
> > > > +#include "linux/virtio_config.h"
> > > > #include <linux/init.h>
> > > > #include <linux/module.h>
> > > > #include <linux/device.h>
> > > > @@ -145,6 +146,7 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index,
> > > > /* Assume split virtqueue, switch to packed if necessary */
> > > > struct vdpa_vq_state state = {0};
> > > > unsigned long flags;
> > > > + bool may_reduce_num = false;
> > > > u32 align, num;
> > > > int err;
> > > >
> > > > @@ -169,10 +171,13 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index,
> > > > goto error_new_virtqueue;
> > > > }
> > > >
> > > > + if (ops->get_features(vdpa) & BIT_ULL(VIRTIO_F_VERSION_1))
> > > > + may_reduce_num = true;
> > > > +
> > > > /* Create the vring */
> > > > align = ops->get_vq_align(vdpa);
> > > > vq = vring_create_virtqueue(index, num, align, vdev,
> > > > - true, true, ctx,
> > > > + true, may_reduce_num, ctx,
> > > > virtio_vdpa_notify, callback, name);
> > > > if (!vq) {
> > > > err = -ENOMEM;
> > > > diff --git a/include/uapi/linux/vdpa.h b/include/uapi/linux/vdpa.h
> > > > index 66a41e4ec163..ce0b74276a5b 100644
> > > > --- a/include/uapi/linux/vdpa.h
> > > > +++ b/include/uapi/linux/vdpa.h
> > > > @@ -32,6 +32,7 @@ enum vdpa_attr {
> > > > VDPA_ATTR_DEV_VENDOR_ID, /* u32 */
> > > > VDPA_ATTR_DEV_MAX_VQS, /* u32 */
> > > > VDPA_ATTR_DEV_MAX_VQ_SIZE, /* u16 */
> > > > + VDPA_ATTR_DEV_VERSION_1, /* flag */
> > > >
> > > > /* new attributes must be added above here */
> > > > VDPA_ATTR_MAX,
> > > > --
> > > > 2.31.1
> > >
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-09-15 8:07 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1631101392.git.wuzongyong@linux.alibaba.com>
[not found] ` <88701e88ab061f5d1b94bd046afcb9d3588414c3.1631101392.git.wuzongyong@linux.alibaba.com>
2021-09-09 2:53 ` [PATCH 3/6] vp_vdpa: add vq irq offloading support Jason Wang
[not found] ` <ebd83066e3897aae63e4b02f8729a73dd09931c6.1631101392.git.wuzongyong@linux.alibaba.com>
2021-09-09 2:55 ` [PATCH 5/6] vdpa: add get_vq_num_unchangeable callback in vdpa_config_ops Jason Wang
2021-09-09 9:18 ` Michael S. Tsirkin
2021-09-09 9:32 ` Jason Wang
[not found] ` <20210909080157.GA17383@L-PF27918B-1352.localdomain>
2021-09-09 9:28 ` Jason Wang
[not found] ` <20210909095726.GA17469@L-PF27918B-1352.localdomain>
2021-09-10 1:45 ` Jason Wang
[not found] ` <20210910073231.GA17715@L-PF27918B-1352.localdomain>
[not found] ` <CACLfguWeXwWJ9yd18vHbYicOk5=eMZJ0X=m86EKjmgHu35NdVA@mail.gmail.com>
[not found] ` <20210910092013.GA17783@L-PF27918B-1352.localdomain>
[not found] ` <CACLfguXFDra77Nqiv+ArUEOzTf9rzi0gLK4_r0ofCfJHSO056Q@mail.gmail.com>
2021-09-13 1:43 ` Jason Wang
[not found] ` <20210913025920.GB17820@L-PF27918B-1352.localdomain>
2021-09-13 3:13 ` Jason Wang
2021-09-09 3:05 ` [PATCH 0/6] vDPA driver for legacy virtio-pci device Jason Wang
2021-09-09 3:20 ` Jason Wang
2021-09-09 9:21 ` Michael S. Tsirkin
2021-09-09 9:31 ` Jason Wang
[not found] ` <20210909081211.GB17383@L-PF27918B-1352.localdomain>
2021-09-09 9:29 ` Jason Wang
[not found] ` <20210909125338.GA17535@L-PF27918B-1352.localdomain>
2021-09-10 1:44 ` Jason Wang
[not found] ` <8b084e5beb1111ad98bb64177ebd0e9845c178fa.1631101392.git.wuzongyong@linux.alibaba.com>
2021-09-09 13:57 ` [PATCH 6/6] vp_vdpa: introduce legacy virtio pci driver Michael S. Tsirkin
[not found] ` <20210910022818.GB17535@L-PF27918B-1352.localdomain>
2021-09-10 9:57 ` Michael S. Tsirkin
2021-10-22 9:37 ` Michael S. Tsirkin
[not found] ` <cover.1631621507.git.wuzongyong@linux.alibaba.com>
[not found] ` <834528d24c839080215b2e077f100e9ed5073edc.1631621507.git.wuzongyong@linux.alibaba.com>
2021-09-14 12:58 ` [PATCH v2 4/5] vdpa: add new vdpa attribute VDPA_ATTR_DEV_F_VERSION_1 Michael S. Tsirkin
2021-09-15 3:18 ` Jason Wang
2021-09-15 7:38 ` Michael S. Tsirkin
2021-09-15 8:06 ` Jason Wang [this message]
2021-09-15 11:08 ` Michael S. Tsirkin
2021-09-16 1:05 ` Jason Wang
[not found] ` <20210917023451.GA19669@L-PF27918B-1352.localdomain>
2021-09-17 7:51 ` Jason Wang
[not found] ` <20210915121234.GA19232@L-PF27918B-1352.localdomain>
2021-09-16 1:11 ` Jason Wang
[not found] ` <20210915032453.GA18793@L-PF27918B-1352.localdomain>
2021-09-15 7:30 ` Michael S. Tsirkin
2021-09-15 8:05 ` Jason Wang
2021-09-15 11:10 ` Michael S. Tsirkin
[not found] ` <f833e77685cd1dfadc5c3b6688d29a0d1383dbb9.1631621507.git.wuzongyong@linux.alibaba.com>
2021-09-14 22:37 ` [PATCH v2 1/5] virtio-pci: introduce legacy device module Randy Dunlap
[not found] ` <42c5a09aacae346449bcc7b7b54d63f9d265e622.1631621507.git.wuzongyong@linux.alibaba.com>
2021-09-15 3:15 ` [PATCH v2 2/5] vdpa: fix typo Jason Wang
[not found] ` <11a491e2200e17319989ff9043b8d58867610197.1631621507.git.wuzongyong@linux.alibaba.com>
2021-09-15 3:16 ` [PATCH v2 3/5] vp_vdpa: add vq irq offloading support Jason Wang
[not found] ` <20210915033102.GB18793@L-PF27918B-1352.localdomain>
2021-09-15 4:13 ` Jason Wang
[not found] ` <ab98427764198053b4277a127eaea3f32cd40ed5.1631621507.git.wuzongyong@linux.alibaba.com>
2021-09-14 22:35 ` [PATCH v2 5/5] eni_vdpa: add vDPA driver for Alibaba ENI Randy Dunlap
2021-09-15 3:14 ` Jason Wang
2021-09-15 13:36 ` kernel test robot
[not found] ` <cover.1632313398.git.wuzongyong@linux.alibaba.com>
[not found] ` <296014fa3b765f2088a3183bf04e09863651a584.1632313398.git.wuzongyong@linux.alibaba.com>
2021-09-26 2:24 ` [PATCH v3 7/7] " Jason Wang
[not found] ` <20210926032434.GA32570@L-PF27918B-1352.localdomain>
2021-09-26 4:18 ` Jason Wang
2021-09-27 10:36 ` Michael S. Tsirkin
2021-09-28 2:17 ` Jason Wang
2021-09-26 2:26 ` Jason Wang
[not found] ` <20210926032701.GA32606@L-PF27918B-1352.localdomain>
2021-09-26 4:19 ` Jason Wang
2021-09-29 12:54 ` kernel test robot
[not found] ` <cover.1632882380.git.wuzongyong@linux.alibaba.com>
[not found] ` <a068c730a0707d35afbbf72a5e0eb29f427f6045.1632882380.git.wuzongyong@linux.alibaba.com>
2021-10-11 3:00 ` [PATCH v4 1/7] virtio-pci: introduce legacy device module Jason Wang
2021-10-11 3:02 ` Jason Wang
[not found] ` <49dc74038cdfaa7af7dab1565ba5da5d6cc4ec7d.1632882380.git.wuzongyong@linux.alibaba.com>
2021-10-11 3:03 ` [PATCH v4 2/7] vdpa: fix typo Jason Wang
[not found] ` <451ce3c272ebd5d532db1ed19c2ab53c4609f7ad.1632882380.git.wuzongyong@linux.alibaba.com>
2021-10-11 3:04 ` [PATCH v4 4/7] vdpa: add new callback get_vq_num_min in vdpa_config_ops Jason Wang
[not found] ` <e971b011b9224a4da4fcab6e904fcee0b7393ac6.1632882380.git.wuzongyong@linux.alibaba.com>
2021-10-11 3:06 ` [PATCH v4 5/7] virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max,min} Jason Wang
[not found] ` <ab430c611c3d8074fddc6c4e0f747852678d6b3f.1632882380.git.wuzongyong@linux.alibaba.com>
2021-10-11 3:10 ` [PATCH v4 6/7] vdpa: add new attribute VDPA_ATTR_DEV_MIN_VQ_SIZE Jason Wang
[not found] ` <68d4ffac2ed9c21f352c272efbdf21e567d7d48e.1632882380.git.wuzongyong@linux.alibaba.com>
2021-10-11 3:18 ` [PATCH v4 7/7] eni_vdpa: add vDPA driver for Alibaba ENI Jason Wang
[not found] ` <cover.1634281805.git.wuzongyong@linux.alibaba.com>
[not found] ` <57a04a9e516ec4055cb887e9c7b24658ca5b0228.1634281805.git.wuzongyong@linux.alibaba.com>
2021-10-15 8:18 ` [PATCH v5 8/8] " Jason Wang
2021-10-15 19:13 ` Randy Dunlap
[not found] ` <17a38d70dd6f598f98eca68731746b6945a36d36.1634281805.git.wuzongyong@linux.alibaba.com>
2021-10-15 8:22 ` [PATCH v5 1/8] virtio-pci: introduce legacy device module Jason Wang
[not found] ` <25435d5cde12f298133196e866662b0ef2225205.1634281805.git.wuzongyong@linux.alibaba.com>
2021-10-15 8:22 ` [PATCH v5 4/8] vdpa: add new callback get_vq_num_min in vdpa_config_ops Jason Wang
[not found] ` <5b75093fc4a866a4502485ec208ca0e55440bdf7.1634281805.git.wuzongyong@linux.alibaba.com>
2021-10-15 8:24 ` [PATCH v5 5/8] vdpa: min vq num of vdpa device cannot be greater than max vq num Jason Wang
[not found] ` <4fae24ebd63ac4ec513bfe0688051469ea0588c0.1634281805.git.wuzongyong@linux.alibaba.com>
2021-10-15 8:30 ` [PATCH v5 6/8] virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max,min} Jason Wang
[not found] ` <cover.1634870456.git.wuzongyong@linux.alibaba.com>
[not found] ` <7bb4834a0638fabaf3ba1a585b607830392a088f.1634870456.git.wuzongyong@linux.alibaba.com>
2021-10-25 1:30 ` [PATCH v6 1/8] virtio-pci: introduce legacy device module Jason Wang
[not found] ` <7e4d859949fa37fce2289a4b287843cdeffcaf8a.1634870456.git.wuzongyong@linux.alibaba.com>
2021-10-25 2:17 ` [PATCH v6 4/8] vdpa: add new callback get_vq_num_min in vdpa_config_ops Jason Wang
[not found] ` <41e5d4e7d9e6f46429ce45a80f81f40fdb8e11cb.1634870456.git.wuzongyong@linux.alibaba.com>
2021-10-25 2:18 ` [PATCH v6 5/8] vdpa: min vq num of vdpa device cannot be greater than max vq num Jason Wang
[not found] ` <c75b4499f7ead922daa19bf67b32eed6f185d260.1634870456.git.wuzongyong@linux.alibaba.com>
2021-10-25 2:22 ` [PATCH v6 6/8] virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max, min} Jason Wang
[not found] ` <20211025024403.GA3684@L-PF27918B-1352.localdomain>
2021-10-25 4:45 ` [PATCH v6 6/8] virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max,min} Jason Wang
[not found] ` <20211025062454.GA4832@L-PF27918B-1352.localdomain>
2021-10-26 4:46 ` [PATCH v6 6/8] virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max, min} Jason Wang
[not found] ` <f3d36f0d7c9588aefaf6eeaa235b0a22fee23d56.1634870456.git.wuzongyong@linux.alibaba.com>
2021-10-25 2:23 ` [PATCH v6 7/8] vdpa: add new attribute VDPA_ATTR_DEV_MIN_VQ_SIZE Jason Wang
[not found] ` <6496b76a64303a3e23ea19e3e279644608de36fb.1634870456.git.wuzongyong@linux.alibaba.com>
2021-10-25 2:27 ` [PATCH v6 8/8] eni_vdpa: add vDPA driver for Alibaba ENI Jason Wang
[not found] ` <20211025032146.GC3684@L-PF27918B-1352.localdomain>
2021-10-25 4:40 ` Jason Wang
[not found] ` <20211027024700.GA23409@L-PF27918B-1352.localdomain>
2021-10-27 3:55 ` Jason Wang
[not found] ` <cover.1635493219.git.wuzongyong@linux.alibaba.com>
2021-11-01 3:31 ` [PATCH v7 0/9] " Jason Wang
[not found] ` <20211101062250.GA29814@L-PF27918B-1352.localdomain>
2021-11-01 7:02 ` Jason Wang
[not found] ` <20211101081159.GA4341@L-PF27918B-1352.localdomain>
2021-11-01 11:12 ` Michael S. Tsirkin
[not found] ` <0945b37f19b96ecadb79a4e1b01f486119a0b83a.1635493219.git.wuzongyong@linux.alibaba.com>
2021-11-01 8:18 ` [PATCH v7 9/9] eni_vdpa: alibaba: fix Kconfig typo Michael S. Tsirkin
2021-11-01 8:19 ` [PATCH v7 0/9] vDPA driver for Alibaba ENI Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACGkMEtN0Z=rgMhaWNO=6h-KXGdosBuOdqoWoND-=Tf+afyUYw@mail.gmail.com' \
--to=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.yang1@linux.alibaba.com \
--cc=wuzongyong@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).