From: Michael Kelley via Virtualization <virtualization@lists.linux-foundation.org>
To: Wei Liu <wei.liu@kernel.org>,
Linux on Hyper-V List <linux-hyperv@vger.kernel.org>
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
"pasha.tatashin@soleen.com" <pasha.tatashin@soleen.com>,
Lillian Grassin-Drake <Lillian.GrassinDrake@microsoft.com>,
"maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)"
<x86@kernel.org>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Nuno Das Neves <nunodasneves@linux.microsoft.com>,
Borislav Petkov <bp@alien8.de>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
Vineeth Pillai <viremana@linux.microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: RE: [PATCH v5 08/16] x86/hyperv: handling hypercall page setup for root
Date: Tue, 26 Jan 2021 00:49:41 +0000 [thread overview]
Message-ID: <MWHPR21MB159330C9B68EC00916FD1EC1D7BC9@MWHPR21MB1593.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20210120120058.29138-9-wei.liu@kernel.org>
From: Wei Liu <wei.liu@kernel.org> Sent: Wednesday, January 20, 2021 4:01 AM
>
> When Linux is running as the root partition, the hypercall page will
> have already been setup by Hyper-V. Copy the content over to the
> allocated page.
>
> Add checks to hv_suspend & co to bail early because they are not
> supported in this setup yet.
>
> Signed-off-by: Lillian Grassin-Drake <ligrassi@microsoft.com>
> Signed-off-by: Sunil Muthuswamy <sunilmut@microsoft.com>
> Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
> Co-Developed-by: Lillian Grassin-Drake <ligrassi@microsoft.com>
> Co-Developed-by: Sunil Muthuswamy <sunilmut@microsoft.com>
> Co-Developed-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> ---
> v3:
> 1. Use HV_HYP_PAGE_SIZE.
> 2. Add checks to hv_suspend & co.
> ---
> arch/x86/hyperv/hv_init.c | 37 ++++++++++++++++++++++++++++++++++---
> 1 file changed, 34 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
> index fc9941bd8653..ad8e77859b32 100644
> --- a/arch/x86/hyperv/hv_init.c
> +++ b/arch/x86/hyperv/hv_init.c
> @@ -25,6 +25,7 @@
> #include <linux/cpuhotplug.h>
> #include <linux/syscore_ops.h>
> #include <clocksource/hyperv_timer.h>
> +#include <linux/highmem.h>
>
> u64 hv_current_partition_id = ~0ull;
> EXPORT_SYMBOL_GPL(hv_current_partition_id);
> @@ -283,6 +284,9 @@ static int hv_suspend(void)
> union hv_x64_msr_hypercall_contents hypercall_msr;
> int ret;
>
> + if (hv_root_partition)
> + return -EPERM;
> +
> /*
> * Reset the hypercall page as it is going to be invalidated
> * accross hibernation. Setting hv_hypercall_pg to NULL ensures
> @@ -433,8 +437,35 @@ void __init hyperv_init(void)
>
> rdmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64);
> hypercall_msr.enable = 1;
> - hypercall_msr.guest_physical_address = vmalloc_to_pfn(hv_hypercall_pg);
> - wrmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64);
> +
> + if (hv_root_partition) {
> + struct page *pg;
> + void *src, *dst;
> +
> + /*
> + * For the root partition, the hypervisor will set up its
> + * hypercall page. The hypervisor guarantees it will not show
> + * up in the root's address space. The root can't change the
> + * location of the hypercall page.
> + *
> + * Order is important here. We must enable the hypercall page
> + * so it is populated with code, then copy the code to an
> + * executable page.
> + */
> + wrmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64);
> +
> + pg = vmalloc_to_page(hv_hypercall_pg);
> + dst = kmap(pg);
> + src = memremap(hypercall_msr.guest_physical_address << PAGE_SHIFT,
> PAGE_SIZE,
> + MEMREMAP_WB);
> + BUG_ON(!(src && dst));
> + memcpy(dst, src, HV_HYP_PAGE_SIZE);
> + memunmap(src);
> + kunmap(pg);
> + } else {
> + hypercall_msr.guest_physical_address = vmalloc_to_pfn(hv_hypercall_pg);
> + wrmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64);
> + }
>
> /*
> * Ignore any errors in setting up stimer clockevents
> @@ -577,6 +608,6 @@ EXPORT_SYMBOL_GPL(hv_is_hyperv_initialized);
>
> bool hv_is_hibernation_supported(void)
> {
> - return acpi_sleep_state_supported(ACPI_STATE_S4);
> + return !hv_root_partition && acpi_sleep_state_supported(ACPI_STATE_S4);
> }
> EXPORT_SYMBOL_GPL(hv_is_hibernation_supported);
> --
> 2.20.1
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-01-26 0:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210120120058.29138-1-wei.liu@kernel.org>
[not found] ` <20210120120058.29138-3-wei.liu@kernel.org>
2021-01-20 16:03 ` [PATCH v5 02/16] x86/hyperv: detect if Linux is the root partition Pavel Tatashin
2021-01-26 0:31 ` Michael Kelley via Virtualization
[not found] ` <20210120120058.29138-7-wei.liu@kernel.org>
2021-01-20 15:12 ` [PATCH v5 06/16] x86/hyperv: allocate output arg pages if required kernel test robot
2021-01-20 19:44 ` Pavel Tatashin
2021-01-26 0:41 ` Michael Kelley via Virtualization
[not found] ` <20210120120058.29138-2-wei.liu@kernel.org>
2021-01-20 15:57 ` [PATCH v5 01/16] asm-generic/hyperv: change HV_CPU_POWER_MANAGEMENT to HV_CPU_MANAGEMENT Pavel Tatashin
2021-01-26 0:25 ` Michael Kelley via Virtualization
[not found] ` <20210120120058.29138-4-wei.liu@kernel.org>
2021-01-20 16:06 ` [PATCH v5 03/16] Drivers: hv: vmbus: skip VMBus initialization if Linux is root Pavel Tatashin
2021-01-26 0:32 ` Michael Kelley via Virtualization
[not found] ` <20210120120058.29138-5-wei.liu@kernel.org>
2021-01-20 16:08 ` [PATCH v5 04/16] iommu/hyperv: don't setup IRQ remapping when running as root Pavel Tatashin
2021-01-26 0:33 ` Michael Kelley via Virtualization
[not found] ` <20210120120058.29138-6-wei.liu@kernel.org>
2021-01-20 16:13 ` [PATCH v5 05/16] clocksource/hyperv: use MSR-based access if " Pavel Tatashin
2021-01-26 0:34 ` Michael Kelley via Virtualization
[not found] ` <20210120120058.29138-8-wei.liu@kernel.org>
2021-01-26 0:48 ` [PATCH v5 07/16] x86/hyperv: extract partition ID from Microsoft Hypervisor if necessary Michael Kelley via Virtualization
[not found] ` <20210202150353.6npksy7tobrvfqlt@liuwe-devbox-debian-v2>
2021-02-04 16:33 ` Michael Kelley via Virtualization
[not found] ` <20210120120058.29138-9-wei.liu@kernel.org>
2021-01-26 0:49 ` Michael Kelley via Virtualization [this message]
[not found] ` <20210120120058.29138-10-wei.liu@kernel.org>
2021-01-26 1:20 ` [PATCH v5 09/16] x86/hyperv: provide a bunch of helper functions Michael Kelley via Virtualization
[not found] ` <20210120120058.29138-11-wei.liu@kernel.org>
2021-01-26 1:21 ` [PATCH v5 10/16] x86/hyperv: implement and use hv_smp_prepare_cpus Michael Kelley via Virtualization
[not found] ` <20210120120058.29138-12-wei.liu@kernel.org>
2021-01-26 1:22 ` [PATCH v5 11/16] asm-generic/hyperv: update hv_msi_entry Michael Kelley via Virtualization
[not found] ` <20210120120058.29138-13-wei.liu@kernel.org>
2021-01-26 1:23 ` [PATCH v5 12/16] asm-generic/hyperv: update hv_interrupt_entry Michael Kelley via Virtualization
[not found] ` <20210120120058.29138-14-wei.liu@kernel.org>
2021-01-26 1:26 ` [PATCH v5 13/16] asm-generic/hyperv: introduce hv_device_id and auxiliary structures Michael Kelley via Virtualization
[not found] ` <20210202170248.4hds554cyxpuayqc@liuwe-devbox-debian-v2>
[not found] ` <20210203132601.ftpwgs57qtok47cg@liuwe-devbox-debian-v2>
[not found] ` <CAK8P3a0m8jEij-RdP1PTcNcJW2+mXQ1dA4=s+JLXhnv+NyFiHw@mail.gmail.com>
[not found] ` <20210203140906.g35zr7366hh7p5f3@liuwe-devbox-debian-v2>
2021-02-04 16:46 ` Michael Kelley via Virtualization
[not found] ` <20210120120058.29138-15-wei.liu@kernel.org>
2021-01-26 1:27 ` [PATCH v5 14/16] asm-generic/hyperv: import data structures for mapping device interrupts Michael Kelley via Virtualization
[not found] ` <20210120120058.29138-16-wei.liu@kernel.org>
2021-01-27 5:47 ` [PATCH v5 15/16] x86/hyperv: implement an MSI domain for root partition Michael Kelley via Virtualization
[not found] ` <20210202173153.jkbvwck2vsjlbjbz@liuwe-devbox-debian-v2>
2021-02-02 18:15 ` Michael Kelley via Virtualization
[not found] ` <20210120120058.29138-17-wei.liu@kernel.org>
2021-01-27 5:47 ` [PATCH v5 16/16] iommu/hyperv: setup an IO-APIC IRQ remapping " Michael Kelley via Virtualization
[not found] ` <20210203124700.ugx5vd526455u7lb@liuwe-devbox-debian-v2>
2021-02-04 16:41 ` Michael Kelley via Virtualization
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR21MB159330C9B68EC00916FD1EC1D7BC9@MWHPR21MB1593.namprd21.prod.outlook.com \
--to=virtualization@lists.linux-foundation.org \
--cc=Lillian.GrassinDrake@microsoft.com \
--cc=bp@alien8.de \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=nunodasneves@linux.microsoft.com \
--cc=pasha.tatashin@soleen.com \
--cc=sthemmin@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=tglx@linutronix.de \
--cc=viremana@linux.microsoft.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).