From: Pierre Morel <pmorel@linux.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>
Cc: gor@linux.ibm.com, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, kvm@vger.kernel.org,
thomas.lendacky@amd.com, hca@linux.ibm.com, cohuck@redhat.com,
linuxram@us.ibm.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, pasic@linux.ibm.com,
borntraeger@de.ibm.com, david@gibson.dropbear.id.au
Subject: Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection
Date: Thu, 6 Aug 2020 16:19:23 +0200 [thread overview]
Message-ID: <ef819e0e-85c3-0b14-4f8e-0d2a6c452355@linux.ibm.com> (raw)
In-Reply-To: <e41d039c-5fe2-b9db-093b-c0dddcc2ad4f@linux.ibm.com>
On 2020-07-30 13:31, Pierre Morel wrote:
...snip...
>>>> What bothers me here is that arch code depends on virtio now.
>>>> It works even with a modular virtio when functions are inline,
>>>> but it seems fragile: e.g. it breaks virtio as an out of tree module,
>>>> since layout of struct virtio_device can change.
>>>
>>>
>>> The code was only called from virtio.c so it should be fine.
>>>
>>> And my understanding is that we don't need to care about the kABI issue
>>> during upstream development?
>>>
>>> Thanks
>>
>> No, but so far it has been convenient at least for me, for development,
>> to just be able to unload all of virtio and load a different version.
>>
>>
>>>
>>>>
>>>> I'm not sure what to do with this yet, will try to think about it
>>>> over the weekend. Thanks!
After reflection, I am not sure that this problem must be treated on the
architecture level or inside the VIRTIO transport.
Consequently, I will propose another patch series based on CCW transport.
This also should be more convenient for core development.
Regards,
Pierre
--
Pierre Morel
IBM Lab Boeblingen
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-08-06 14:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 8:31 [PATCH v7 0/2] s390: virtio: let arch validate VIRTIO features Pierre Morel
2020-07-15 8:31 ` [PATCH v7 1/2] " Pierre Morel
2020-07-15 8:31 ` [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection Pierre Morel
2020-07-15 9:50 ` Michael S. Tsirkin
2020-07-15 10:16 ` Jason Wang
2020-07-15 11:51 ` Michael S. Tsirkin
2020-07-16 11:19 ` Christian Borntraeger
2020-07-16 21:46 ` Michael S. Tsirkin
2020-07-22 11:48 ` Pierre Morel
[not found] ` <e41d039c-5fe2-b9db-093b-c0dddcc2ad4f@linux.ibm.com>
2020-08-06 14:19 ` Pierre Morel [this message]
2020-07-15 8:36 ` [PATCH v7 0/2] s390: virtio: let arch validate VIRTIO features Jason Wang
2020-07-15 9:20 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef819e0e-85c3-0b14-4f8e-0d2a6c452355@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=thomas.lendacky@amd.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).