From: Alberto Garcia <berto@igalia.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, armbru@redhat.com,
qemu-devel@nongnu.org, mreitz@redhat.com, den@openvz.org,
jsnow@redhat.com
Subject: Re: [PATCH v2 14/36] block: inline bdrv_child_*() permission functions calls
Date: Wed, 16 Dec 2020 18:16:12 +0100 [thread overview]
Message-ID: <w5136057jtv.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <20201127144522.29991-15-vsementsov@virtuozzo.com>
On Fri 27 Nov 2020 03:45:00 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> Each of them has only one caller. Open-coding simplifies further
> pemission-update system changes.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Berto
next prev parent reply other threads:[~2020-12-16 17:23 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 14:44 [PATCH v2 00/36] block: update graph permissions update Vladimir Sementsov-Ogievskiy
2020-11-27 14:44 ` [PATCH v2 01/36] tests/test-bdrv-graph-mod: add test_parallel_exclusive_write Vladimir Sementsov-Ogievskiy
2020-11-27 14:44 ` [PATCH v2 02/36] tests/test-bdrv-graph-mod: add test_parallel_perm_update Vladimir Sementsov-Ogievskiy
2021-01-18 14:05 ` Kevin Wolf
2021-01-18 17:13 ` Vladimir Sementsov-Ogievskiy
2020-11-27 14:44 ` [PATCH v2 03/36] block: bdrv_append(): don't consume reference Vladimir Sementsov-Ogievskiy
2021-01-18 14:18 ` Kevin Wolf
2021-01-18 17:21 ` Vladimir Sementsov-Ogievskiy
2021-01-18 17:59 ` Kevin Wolf
2020-11-27 14:44 ` [PATCH v2 04/36] block: bdrv_append(): return status Vladimir Sementsov-Ogievskiy
2020-12-14 15:49 ` Alberto Garcia
2021-01-18 14:32 ` Kevin Wolf
2020-11-27 14:44 ` [PATCH v2 05/36] block: add bdrv_parent_try_set_aio_context Vladimir Sementsov-Ogievskiy
2021-01-18 15:08 ` Kevin Wolf
2021-01-18 17:26 ` Vladimir Sementsov-Ogievskiy
2020-11-27 14:44 ` [PATCH v2 06/36] block: BdrvChildClass: add .get_parent_aio_context handler Vladimir Sementsov-Ogievskiy
2021-01-18 15:13 ` Kevin Wolf
2021-01-18 17:36 ` Vladimir Sementsov-Ogievskiy
2021-01-19 16:38 ` Kevin Wolf
2021-01-22 11:04 ` Vladimir Sementsov-Ogievskiy
2021-01-22 11:18 ` Kevin Wolf
2021-01-22 11:26 ` Vladimir Sementsov-Ogievskiy
2020-11-27 14:44 ` [PATCH v2 07/36] block: drop ctx argument from bdrv_root_attach_child Vladimir Sementsov-Ogievskiy
2020-11-27 14:44 ` [PATCH v2 08/36] block: make bdrv_reopen_{prepare, commit, abort} private Vladimir Sementsov-Ogievskiy via
2020-12-15 17:28 ` Alberto Garcia
2021-01-18 15:24 ` [PATCH v2 08/36] block: make bdrv_reopen_{prepare,commit,abort} private Kevin Wolf
2020-11-27 14:44 ` [PATCH v2 09/36] block: return value from bdrv_replace_node() Vladimir Sementsov-Ogievskiy
2020-12-15 17:30 ` Alberto Garcia
2021-01-18 15:40 ` Kevin Wolf
2020-11-27 14:44 ` [PATCH v2 10/36] util: add transactions.c Vladimir Sementsov-Ogievskiy
2021-01-18 16:50 ` Kevin Wolf
2021-01-18 17:41 ` Vladimir Sementsov-Ogievskiy
2020-11-27 14:44 ` [PATCH v2 11/36] block: bdrv_refresh_perms: check parents compliance Vladimir Sementsov-Ogievskiy
2021-01-19 17:42 ` Kevin Wolf
2021-01-19 18:10 ` Vladimir Sementsov-Ogievskiy
2020-11-27 14:44 ` [PATCH v2 12/36] block: refactor bdrv_child* permission functions Vladimir Sementsov-Ogievskiy
2021-01-19 18:09 ` Kevin Wolf
2021-01-19 18:30 ` Vladimir Sementsov-Ogievskiy
2021-01-20 9:09 ` Kevin Wolf
2021-01-20 9:56 ` Vladimir Sementsov-Ogievskiy
2021-01-20 10:06 ` Kevin Wolf
2020-11-27 14:44 ` [PATCH v2 13/36] block: rewrite bdrv_child_try_set_perm() using bdrv_refresh_perms() Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 14/36] block: inline bdrv_child_*() permission functions calls Vladimir Sementsov-Ogievskiy
2020-12-16 17:16 ` Alberto Garcia [this message]
2020-11-27 14:45 ` [PATCH v2 15/36] block: use topological sort for permission update Vladimir Sementsov-Ogievskiy
2021-01-27 18:38 ` Kevin Wolf
2021-01-28 9:34 ` Vladimir Sementsov-Ogievskiy
2021-01-28 17:13 ` Kevin Wolf
2021-01-28 18:04 ` Vladimir Sementsov-Ogievskiy
2021-02-03 18:38 ` Kevin Wolf
2021-02-04 7:16 ` Vladimir Sementsov-Ogievskiy
2021-03-10 11:08 ` Vladimir Sementsov-Ogievskiy
2021-03-10 11:55 ` Kevin Wolf
2020-11-27 14:45 ` [PATCH v2 16/36] block: add bdrv_drv_set_perm transaction action Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 17/36] block: add bdrv_list_* permission update functions Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 18/36] block: add bdrv_replace_child_safe() transaction action Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 19/36] block: fix bdrv_replace_node_common Vladimir Sementsov-Ogievskiy
2021-02-03 18:23 ` Kevin Wolf
2021-02-04 7:24 ` Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 20/36] block: add bdrv_attach_child_common() transaction action Vladimir Sementsov-Ogievskiy
2021-02-03 21:01 ` Kevin Wolf
2021-02-04 7:34 ` Vladimir Sementsov-Ogievskiy
2021-02-04 7:50 ` Kevin Wolf
2020-11-27 14:45 ` [PATCH v2 21/36] block: add bdrv_attach_child_noperm() " Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 22/36] block: split out bdrv_replace_node_noperm() Vladimir Sementsov-Ogievskiy
2021-02-03 21:16 ` Kevin Wolf
2020-11-27 14:45 ` [PATCH v2 23/36] block: adapt bdrv_append() for inserting filters Vladimir Sementsov-Ogievskiy
2021-02-03 21:33 ` Kevin Wolf
2021-02-04 8:30 ` Vladimir Sementsov-Ogievskiy
2021-02-04 9:05 ` Kevin Wolf
2021-02-04 11:54 ` Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 24/36] block: add bdrv_remove_backing transaction action Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 25/36] block: introduce bdrv_drop_filter() Vladimir Sementsov-Ogievskiy
2021-02-04 11:31 ` Kevin Wolf
2021-02-04 12:27 ` Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 26/36] block/backup-top: drop .active Vladimir Sementsov-Ogievskiy
2021-02-04 12:26 ` Kevin Wolf
2021-02-04 12:33 ` Vladimir Sementsov-Ogievskiy
2021-02-04 13:25 ` Kevin Wolf
2021-02-04 13:46 ` Vladimir Sementsov-Ogievskiy
2021-02-04 14:31 ` Kevin Wolf
2020-11-27 14:45 ` [PATCH v2 27/36] block: drop ignore_children for permission update functions Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 28/36] block: add bdrv_set_backing_noperm() transaction action Vladimir Sementsov-Ogievskiy
2021-02-05 14:00 ` Kevin Wolf
2021-02-05 16:06 ` Vladimir Sementsov-Ogievskiy
2021-02-05 16:30 ` Kevin Wolf
2021-03-11 18:29 ` Vladimir Sementsov-Ogievskiy
2021-02-05 16:26 ` Kevin Wolf
2021-02-08 9:34 ` Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 29/36] blockdev: qmp_x_blockdev_reopen: acquire all contexts Vladimir Sementsov-Ogievskiy
2021-02-05 16:01 ` Kevin Wolf
2021-02-05 16:16 ` Vladimir Sementsov-Ogievskiy
2021-02-05 16:36 ` Kevin Wolf
2020-11-27 14:45 ` [PATCH v2 30/36] block: bdrv_reopen_multiple: refresh permissions on updated graph Vladimir Sementsov-Ogievskiy
2021-02-05 17:57 ` Kevin Wolf
2021-02-08 11:21 ` Vladimir Sementsov-Ogievskiy
2021-02-10 14:13 ` Kevin Wolf
2021-02-10 14:38 ` Kevin Wolf
2020-11-27 14:45 ` [PATCH v2 31/36] block: drop unused permission update functions Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 32/36] block: inline bdrv_check_perm_common() Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 33/36] block: inline bdrv_replace_child() Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 34/36] block: refactor bdrv_child_set_perm_safe() transaction action Vladimir Sementsov-Ogievskiy
2021-02-10 14:51 ` Kevin Wolf
2020-11-27 14:45 ` [PATCH v2 35/36] block: rename bdrv_replace_child_safe() to bdrv_replace_child() Vladimir Sementsov-Ogievskiy
2020-11-27 14:45 ` [PATCH v2 36/36] block: refactor bdrv_node_check_perm() Vladimir Sementsov-Ogievskiy
2021-02-10 15:07 ` Kevin Wolf
2021-02-11 9:50 ` Vladimir Sementsov-Ogievskiy
2021-01-09 10:12 ` [PATCH v2 00/36] block: update graph permissions update Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w5136057jtv.fsf@maestria.local.igalia.com \
--to=berto@igalia.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.