Re: [Qemu-devel] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver

From: Alberto Garcia <berto@igalia.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver
Date: Thu, 22 Feb 2018 16:30:15 +0100	[thread overview]
Message-ID: <w51606p59fc.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <f2885948-d6b3-90a3-9960-6f8fd53e0177@redhat.com>

On Thu 22 Feb 2018 04:19:45 PM CET, Max Reitz wrote:
> On 2018-02-06 16:23, Alberto Garcia wrote:
>> On Mon 05 Feb 2018 04:18:27 PM CET, Max Reitz wrote:
>>> --- a/block/blkdebug.c
>>> +++ b/block/blkdebug.c
>>> @@ -886,6 +886,21 @@ static int blkdebug_reopen_prepare(BDRVReopenState *reopen_state,
>>>      return 0;
>>>  }
>>>  
>>> +static const char *const blkdebug_sgfnt_runtime_opts[] = {
>>> +    "config",
>>> +    "inject-error.",
>>> +    "set-state.",
>>> +    "suspend.",
>> 
>> Where did this "suspend." come from?
>
> Er, well, er.
>
> After having looked at it a couple of times now, I can't see anything.
> I guess I'll remove it and hope for the best...?

My interpretation is that you saw

enum {
    ACTION_INJECT_ERROR,
    ACTION_SET_STATE,
    ACTION_SUSPEND,
};

and assumed that "suspend" was an option (the other two are). I haven't
seen any string with the "suspend" text anywhere else in the code.

Berto