wireguard.lists.zx2c4.com archive mirror
 help / color / mirror / Atom feed
From: "Janne Heß" <janne@hess.ooo>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>, bird-users@network.cz
Cc: wireguard@lists.zx2c4.com
Subject: Re: Introduce Wireguard support to bird
Date: Sat, 6 Jul 2019 23:05:13 +0200	[thread overview]
Message-ID: <121dc434-986e-91a9-591d-47948289a34c@hess.ooo> (raw)
In-Reply-To: <87pnnp59a3.fsf@toke.dk>


On 6/8/19 12:18 AM, Toke Høiland-Jørgensen wrote:
> Janne Heß <janne@hess.ooo> writes:
> 
>> Hey everyone,
>>
>> as advertised, I have completed the Wireguard support.
>> You might see that I am not really a C expert, but I hope the code is good enough.
>> If you need me to change anything or have additional questions, just
>> let me know.
> 
> Hi Janne
> 
> Awesome that you have taken the time to implement this!
> 
> I'll let the Bird maintainers comment on the approach of embedding the
> wireguard netlink library; but I have two other concerns:
> 
> - As far as I can tell there's nothing preventing Bird from removing
>    AllowedIPs that it did not itself install from an interface, right?
> 
> - The algorithm is basically O(P*M*N) for inserting N routes on an
>    interface with P peers that each have M existing AllowedIPs. That is
>    not going to scale very far :/
> 
> -Toke
> 

Hi Toke,

thanks for your review.

Your first observation is correct. Due to differences in semantics, this 
cannot be implemented in the same way it is implemented in the KRT 
protocol because AllowedIPs don't have a notion of the proto field.

Addressing your second point, the WireGuard netlink interface and 
library only offer and understand the peers and allowed IPs as a linked 
list.
As we only get each route seperately, we cannot process multiple routes 
in one run. We're open to suggestions and patches.

Regards
Janne
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

  reply	other threads:[~2019-07-17 20:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-07 18:21 Introduce Wireguard support to bird Janne Heß
2019-06-07 21:57 ` Ondrej Zajicek
2019-06-07 22:20   ` Toke Høiland-Jørgensen
2019-06-07 22:18 ` Toke Høiland-Jørgensen
2019-07-06 21:05   ` Janne Heß [this message]
2019-07-08 11:36     ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=121dc434-986e-91a9-591d-47948289a34c@hess.ooo \
    --to=janne@hess.ooo \
    --cc=bird-users@network.cz \
    --cc=toke@toke.dk \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).