Wireguard andoird and Fire TV

Wireguard andoird and Fire TV

[Revath S Kumar]

[-- Attachment #1.1: Type: text/plain, Size: 413 bytes --]

Hello all,

I tried to side load the wireguard android on Fire TV stick.
I was successfully able to install and create a new config.
But once the config is created I was not able to enable the config.

The navigation using the FireTV remote never gets focus on config toggle
button.

Any plan to support TV sooner?

with regards,
Revath S Kumar,
JavaScripter / Rubyist / PHP

www.phprepo.in
blog.revathskumar.com

[-- Attachment #1.2: Type: text/html, Size: 811 bytes --]

[-- Attachment #2: Type: text/plain, Size: 148 bytes --]

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: Wireguard andoird and Fire TV

[Samuel Holland]

On 5/6/19 4:27 AM, Revath S Kumar wrote:
> Hello all,
> 
> I tried to side load the wireguard android on Fire TV stick.
> I was successfully able to install and create a new config.
> But once the config is created I was not able to enable the config.
> 
> The navigation using the FireTV remote never gets focus on config toggle button.
> 
> Any plan to support TV sooner?

See https://lists.zx2c4.com/pipermail/wireguard/2019-January/003768.html

It's possible to get it working with the remote, but that would require someone
to write (and test!) the code to do so. Right now there's nobody working on the
Android app.

> with regards,
> Revath S Kumar,
> JavaScripter / Rubyist / PHP

Cheers,
Samuel
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: Wireguard andoird and Fire TV

[Revath S Kumar]

[-- Attachment #1.1: Type: text/plain, Size: 1470 bytes --]

Hello Samuel,

Thanks for the reply. That tip helped me.
I am not a Andorid developer, but tried to look into the code to fix
this problem with help of some friends.
Seems like the issue is due to `
android:descendantFocusability="blocksDescendants"` in tunnel_list_item.xml
[1].

Is there any reason why the value is `blocksDecendants`?
When I remove that line it seems to work fine (gif link)[2].

I can send a patch if this is the only change needed.

[1]:
https://git.zx2c4.com/wireguard-android/tree/app/src/main/res/layout/tunnel_list_item.xml#n32
[2]: https://imgur.com/a/f3nbA7R

with regards,
Revath S Kumar,
JavaScripter / Rubyist

On Sun, May 12, 2019 at 5:37 PM Samuel Holland <samuel@sholland.org> wrote:

> On 5/6/19 4:27 AM, Revath S Kumar wrote:
> > Hello all,
> >
> > I tried to side load the wireguard android on Fire TV stick.
> > I was successfully able to install and create a new config.
> > But once the config is created I was not able to enable the config.
> >
> > The navigation using the FireTV remote never gets focus on config toggle
> button.
> >
> > Any plan to support TV sooner?
>
> See https://lists.zx2c4.com/pipermail/wireguard/2019-January/003768.html
>
> It's possible to get it working with the remote, but that would require
> someone
> to write (and test!) the code to do so. Right now there's nobody working
> on the
> Android app.
>
> > with regards,
> > Revath S Kumar,
> > JavaScripter / Rubyist / PHP
>
> Cheers,
> Samuel
>

[-- Attachment #1.2: Type: text/html, Size: 2569 bytes --]

[-- Attachment #2: Type: text/plain, Size: 148 bytes --]

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: Wireguard andoird and Fire TV

[Revath S Kumar]

[-- Attachment #1.1: Type: text/plain, Size: 1760 bytes --]

Hello Team,

I have send a patch to fix this issue.
Let me know if any more changes needed for the patch.


with regards,
Revath S Kumar

On Fri, May 17, 2019 at 4:34 PM Revath S Kumar <gmail@revathskumar.com>
wrote:

> Hello Samuel,
>
> Thanks for the reply. That tip helped me.
> I am not a Andorid developer, but tried to look into the code to fix
> this problem with help of some friends.
> Seems like the issue is due to `
> android:descendantFocusability="blocksDescendants"` in
> tunnel_list_item.xml [1].
>
> Is there any reason why the value is `blocksDecendants`?
> When I remove that line it seems to work fine (gif link)[2].
>
> I can send a patch if this is the only change needed.
>
> [1]:
> https://git.zx2c4.com/wireguard-android/tree/app/src/main/res/layout/tunnel_list_item.xml#n32
> [2]: https://imgur.com/a/f3nbA7R
>
> with regards,
> Revath S Kumar,
> JavaScripter / Rubyist
>
> On Sun, May 12, 2019 at 5:37 PM Samuel Holland <samuel@sholland.org>
> wrote:
>
>> On 5/6/19 4:27 AM, Revath S Kumar wrote:
>> > Hello all,
>> >
>> > I tried to side load the wireguard android on Fire TV stick.
>> > I was successfully able to install and create a new config.
>> > But once the config is created I was not able to enable the config.
>> >
>> > The navigation using the FireTV remote never gets focus on config
>> toggle button.
>> >
>> > Any plan to support TV sooner?
>>
>> See https://lists.zx2c4.com/pipermail/wireguard/2019-January/003768.html
>>
>> It's possible to get it working with the remote, but that would require
>> someone
>> to write (and test!) the code to do so. Right now there's nobody working
>> on the
>> Android app.
>>
>> > with regards,
>> > Revath S Kumar,
>> > JavaScripter / Rubyist / PHP
>>
>> Cheers,
>> Samuel
>>
>

[-- Attachment #1.2: Type: text/html, Size: 3332 bytes --]

[-- Attachment #2: Type: text/plain, Size: 148 bytes --]

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: Wireguard andoird and Fire TV

[Jason A. Donenfeld]

[-- Attachment #1.1: Type: text/plain, Size: 1972 bytes --]

Samuel,

Looks like you added that in
https://git.zx2c4.com/wireguard-android/commit/app/src/main/res/layout/config_list_item.xml?id=dc7363845b3edacc5bac7be85eb7fc63790e97af
. Remember why?

Jason

On Tue, May 21, 2019, 15:57 Revath S Kumar <gmail@revathskumar.com> wrote:

> Hello Samuel,
>
> Thanks for the reply. That tip helped me.
> I am not a Andorid developer, but tried to look into the code to fix
> this problem with help of some friends.
> Seems like the issue is due to `
> android:descendantFocusability="blocksDescendants"` in
> tunnel_list_item.xml [1].
>
> Is there any reason why the value is `blocksDecendants`?
> When I remove that line it seems to work fine (gif link)[2].
>
> I can send a patch if this is the only change needed.
>
> [1]:
> https://git.zx2c4.com/wireguard-android/tree/app/src/main/res/layout/tunnel_list_item.xml#n32
> [2]: https://imgur.com/a/f3nbA7R
>
> with regards,
> Revath S Kumar,
> JavaScripter / Rubyist
>
> On Sun, May 12, 2019 at 5:37 PM Samuel Holland <samuel@sholland.org>
> wrote:
>
>> On 5/6/19 4:27 AM, Revath S Kumar wrote:
>> > Hello all,
>> >
>> > I tried to side load the wireguard android on Fire TV stick.
>> > I was successfully able to install and create a new config.
>> > But once the config is created I was not able to enable the config.
>> >
>> > The navigation using the FireTV remote never gets focus on config
>> toggle button.
>> >
>> > Any plan to support TV sooner?
>>
>> See https://lists.zx2c4.com/pipermail/wireguard/2019-January/003768.html
>>
>> It's possible to get it working with the remote, but that would require
>> someone
>> to write (and test!) the code to do so. Right now there's nobody working
>> on the
>> Android app.
>>
>> > with regards,
>> > Revath S Kumar,
>> > JavaScripter / Rubyist / PHP
>>
>> Cheers,
>> Samuel
>>
> _______________________________________________
> WireGuard mailing list
> WireGuard@lists.zx2c4.com
> https://lists.zx2c4.com/mailman/listinfo/wireguard
>

[-- Attachment #1.2: Type: text/html, Size: 3838 bytes --]

[-- Attachment #2: Type: text/plain, Size: 148 bytes --]

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: Wireguard andoird and Fire TV

[Samuel Holland]

Revath,

On 5/21/19 5:45 AM, Revath S Kumar wrote:
> I have send a patch to fix this issue.
> Let me know if any more changes needed for the patch.

Thank you very much for the patch! I could have guessed at what to change, but I
wouldn't have been able to test it. I've merged your patch with a bit of
cleanup, so it'll be included in the next release.

> with regards,
> Revath S Kumar

Thanks,
Samuel
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: Wireguard andoird and Fire TV

[Samuel Holland]

Jason,

On 5/21/19 8:58 AM, Jason A. Donenfeld wrote:
> Looks like you added that in dc7363845b3edacc5bac7be85eb7fc63790e97af.
> Remember why?

Yes (after some digging). It's due to the fact that ListView's
OnItemClickListener won't fire if you have a focusable view (like a checkbox or
a switch) in your list item. That's no longer an issue since moving to
RecyclerView, since we add the listeners to each list item ourselves. To be
sure, I tested without blocksDescendants, and I couldn't notice any difference
on a touchscreen device.

> Jason
Cheers,
Samuel
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard