WireGuard Archive on lore.kernel.org
 help / color / Atom feed
* wireguard-go bug with IPv6-less kernels
@ 2018-09-07 16:12 Kent Friis
  0 siblings, 0 replies; only message in thread
From: Kent Friis @ 2018-09-07 16:12 UTC (permalink / raw)
  To: wireguard

I've been setting up wireguard-go on an old Linux kernel (no module),
and hit a bug with ipv6-less kernels. The create6() function returns 0
as the port number when an error occurs, so even though CreateBind
checks for EAFNOSUPPORT, it still ends up with port getting set to zero,
resulting in a random port.

I solved it by returning port instead of zero - as far as I can see
this shouldn't break anything, as CreateBind will return 0 anyway on
errors other than EAFNOSUPPORT.

I did not check whether the same bug exists in conn_default.go

- Kent

--- conn_linux.go.old	2018-09-05 23:11:19.407372785 +0200
+++ conn_linux.go	2018-09-07 16:58:28.971914271 +0200
@@ -335,7 +335,7 @@
 	)
 
 	if err != nil {
-		return -1, 0, err
+		return -1, port, err
 	}
 
 	addr := unix.SockaddrInet4{
@@ -366,7 +366,7 @@
 		return unix.Bind(fd, &addr)
 	}(); err != nil {
 		unix.Close(fd)
-		return -1, 0, err
+		return -1, port, err
 	}
 
 	return fd, uint16(addr.Port), err
@@ -383,7 +383,7 @@
 	)
 
 	if err != nil {
-		return -1, 0, err
+		return -1, port, err
 	}
 
 	// set sockopts and bind
@@ -425,7 +425,7 @@
 
 	}(); err != nil {
 		unix.Close(fd)
-		return -1, 0, err
+		return -1, port, err
 	}
 
 	return fd, uint16(addr.Port), err

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-07 16:12 wireguard-go bug with IPv6-less kernels Kent Friis

WireGuard Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/wireguard/0 wireguard/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 wireguard wireguard/ https://lore.kernel.org/wireguard \
		wireguard@lists.zx2c4.com zx2c4-wireguard@archiver.kernel.org
	public-inbox-index wireguard


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.zx2c4.lists.wireguard


AGPL code for this site: git clone https://public-inbox.org/ public-inbox