From: Bruno Wolff III <bruno@wolff.to>
To: Julian Orth <ju.orth@gmail.com>
Cc: wireguard@lists.zx2c4.com
Subject: Re: [PATCH 0/7] Allow changing the transit namespace
Date: Sat, 8 Sep 2018 08:39:06 -0500 [thread overview]
Message-ID: <20180908133906.GA20780@wolff.to> (raw)
In-Reply-To: <20180908121841.8372-1-ju.orth@gmail.com>
On Sat, Sep 08, 2018 at 14:18:34 +0200,
Julian Orth <ju.orth@gmail.com> wrote:
>
>wg set <device> transit-net <pid|file-path>
>
>The distinction is made based on the format of the argument. If it is an
>unsigned 32 bit integer, then it is interpreted as a process id.
>Otherwise it is interpreted as a file path. /proc does not need to be
>mounted to use the process id interpretation. To force the
>interpretation as a file-path, use a ./ prefix.
Ambiguity is generally not a good idea (especially for security applications).
It's not my decision, but I'd rather see the syntax make it clear what the type
of the parameter is supposed to be.
next prev parent reply other threads:[~2018-09-08 13:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 12:18 [PATCH 0/7] Allow changing the transit namespace Julian Orth
2018-09-08 12:18 ` [PATCH 1/7] device: protect socket_init with device_update_lock Julian Orth
2018-09-08 12:18 ` [PATCH 2/7] device: rename creating_net to transit_net Julian Orth
2018-09-08 12:18 ` [PATCH 3/7] device: store a copy of the device net Julian Orth
2018-09-08 12:18 ` [PATCH 4/7] socket: allow modification of transit_net Julian Orth
2018-09-08 12:18 ` [PATCH 5/7] netlink: allow setting of transit net Julian Orth
2018-09-08 14:03 ` Aaron Jones
2018-09-08 14:20 ` Julian Orth
2018-09-08 14:28 ` Aaron Jones
2018-09-08 12:18 ` [PATCH 6/7] tools: " Julian Orth
2018-09-08 14:04 ` Aaron Jones
2018-09-08 14:09 ` Aaron Jones
2018-09-08 14:18 ` Julian Orth
2018-09-08 14:25 ` Aaron Jones
2018-09-08 12:18 ` [PATCH 7/7] tests: add test for transit-net Julian Orth
2018-09-08 13:39 ` Bruno Wolff III [this message]
2018-09-08 13:49 ` [PATCH 0/7] Allow changing the transit namespace Julian Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180908133906.GA20780@wolff.to \
--to=bruno@wolff.to \
--cc=ju.orth@gmail.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).