[PATCH] wg-quick: Fix alternate routing table syntax on OpenBSD

[PATCH] wg-quick: Fix alternate routing table syntax on OpenBSD

[Ankur Kothari]

---
 src/tools/wg-quick/openbsd.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tools/wg-quick/openbsd.bash b/src/tools/wg-quick/openbsd.bash
index b234609..2cadeec 100755
--- a/src/tools/wg-quick/openbsd.bash
+++ b/src/tools/wg-quick/openbsd.bash
@@ -293,7 +293,7 @@ add_route() {
 	fi
 
 	if [[ -n $TABLE && $TABLE != auto ]]; then
-		cmd route -q -n add "-$family" -rdomain "$TABLE" "$1" -iface "$ifaceroute"
+		cmd route -q -n -T "$TABLE" add "-$family" "$1" -iface "$ifaceroute"
 	elif [[ $1 == */0 ]]; then
 		if [[ $1 == *:* ]]; then
 			AUTO_ROUTE6=1
-- 
2.22.0


Sent via Migadu.com, world's easiest email hosting
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: [PATCH] wg-quick: Fix alternate routing table syntax on OpenBSD

[Jason A. Donenfeld]

Hi Ankur,

Thanks for this. Could you provide your Signed-off-by line? Also, why
is this required? Is this a recent change in syntax? A new syntax? Was
the syntax always wrong? What's the deal?

Thanks,
Jason
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: [PATCH] wg-quick: Fix alternate routing table syntax on OpenBSD

[Janne Johansson]

[-- Attachment #1.1: Type: text/plain, Size: 911 bytes --]

According to "man route" on openbsd, the -T is how its supposed to be run:

     The other commands relating to adding, changing, or deleting routes
have

     the syntax:


     *route* [*-dnqtv*] [*-T* rtable] *add* [modifiers] destination gateway



The manpage for "route" doesn't even contain "rdomain" so I would assume
Ankur is correct in that diff.


Den mån 5 aug. 2019 kl 20:47 skrev Jason A. Donenfeld <Jason@zx2c4.com>:

> Hi Ankur,
>
> Thanks for this. Could you provide your Signed-off-by line? Also, why
> is this required? Is this a recent change in syntax? A new syntax? Was
> the syntax always wrong? What's the deal?
>
> Thanks,
> Jason
> _______________________________________________
> WireGuard mailing list
> WireGuard@lists.zx2c4.com
> https://lists.zx2c4.com/mailman/listinfo/wireguard
>


-- 
May the most significant bit of your life be positive.

[-- Attachment #1.2: Type: text/html, Size: 3797 bytes --]

[-- Attachment #2: Type: text/plain, Size: 148 bytes --]

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: [PATCH] wg-quick: Fix alternate routing table syntax on OpenBSD

[Jason A. Donenfeld]

Hi Janne,

Thanks. I wonder how I came up with the rdomain syntax in the first
place. Perhaps out of ifconfig.c incorrectly.

Jason
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

[PATCH v2] wg-quick: openbsd: fix alternate routing table syntax

[Ankur Kothari]

route(8) has always used the `-T` option to specify the
routing table; there is no `rdomain` option.

Signed-off-by: Ankur Kothari <ankur@lipidity.com>
---
 src/tools/wg-quick/openbsd.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tools/wg-quick/openbsd.bash b/src/tools/wg-quick/openbsd.bash
index b234609..2cadeec 100755
--- a/src/tools/wg-quick/openbsd.bash
+++ b/src/tools/wg-quick/openbsd.bash
@@ -293,7 +293,7 @@ add_route() {
 	fi
 
 	if [[ -n $TABLE && $TABLE != auto ]]; then
-		cmd route -q -n add "-$family" -rdomain "$TABLE" "$1" -iface "$ifaceroute"
+		cmd route -q -n -T "$TABLE" add "-$family" "$1" -iface "$ifaceroute"
 	elif [[ $1 == */0 ]]; then
 		if [[ $1 == *:* ]]; then
 			AUTO_ROUTE6=1
-- 
2.22.0


Sent via Migadu.com, world's easiest email hosting
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: [PATCH v2] wg-quick: openbsd: fix alternate routing table syntax

[Jason A. Donenfeld]

Thanks, applied.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard