WireGuard Archive on lore.kernel.org
 help / color / Atom feed
From: Tore Anderson <tore@fud.no>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: "Tomcsanyi, Domonkos" <domi@tomcsanyi.net>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH] Adding support for reloading configuration via systemd
Date: Mon, 27 Jul 2020 22:04:17 +0200
Message-ID: <27652e0971672a8fab30f59ff053cf65feaa711f.camel@fud.no> (raw)
In-Reply-To: <CAHmME9p+tVyEm_+ALbsCWhshrt5yR97enjBcuUdVhTAWTf-MwA@mail.gmail.com>

* Jason A. Donenfeld

> But it doesn't sync Address=, DNS=, or any routing particulars. That
> seems like a problem if it's to become a bona fide "reload" subcommand
> of wg-quick, since it's not doing what it should be. On the other
> hand, adding it to the systemd unit seems far enough away from core
> code that we can kind of say, "eh, this sort of works," which might be
> good enough. If even _that_ causes problems for users too, we'd have
> to talk about removing it from the systemd unit. But hopefully it
> stays under the radar and people don't have overly high expectations.

Absolutely, a 'wg syncconf' wrapper is unable to fully implement every
conceivable change to the wg-quick config file. That said, 99.9% of my
configuration changes are additions/removal of [Peer] sections that 'wg
syncconf' do handle perfectly. Being able to add and remove individual
VPN users without disrupting the traffic of other unrelated users is a
really big win for me. I would imagine this to ability be highly
desirable for most other VPN server operators as well – even for those
that do not use systemd.

I do use systemd, so I am personally fine with what just got merged. I
do have to wonder, though, if I committed some sort of faux pas and/or
violated some contribution guideline in posting my initial submission,
considering that it was consistently ignored for months even though it
implemented essentially the same thing as what ended up being merged
just now.

Anyway. I would, if you are interested in that, be happy update my
patch to rename the new wg-quick action «syncconf» instead of «reload»,
in order to more clearly indicate that this action will only change the
parameters that 'wg syncconf' can change.

Tore


  reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <VI1PR02MB52169D6F055314DCD03746EDE6760@VI1PR02MB5216.eurprd02.prod.outlook.com>
2020-07-23 14:10 ` Tomcsanyi, Domonkos
2020-07-24  9:14   ` Jason A. Donenfeld
2020-07-24  9:25     ` Garrit Franke
2020-07-24  9:27       ` Garrit Franke
2020-07-24  9:29       ` Jason A. Donenfeld
2020-07-24 13:09         ` Tomcsányi, Domonkos
2020-07-24 14:26           ` Jason A. Donenfeld
2020-07-24 14:46             ` Dominique Martinet
2020-07-24 14:49               ` Jason A. Donenfeld
2020-07-24  9:54       ` Matthias Urlichs
2020-07-24 10:52         ` Stefan Tatschner
2020-07-24 11:00           ` Matthias Urlichs
2020-07-25 12:16     ` Tore Anderson
2020-07-27 15:51       ` Jason A. Donenfeld
2020-07-27 20:04         ` Tore Anderson [this message]
2020-07-28  9:03           ` Jason A. Donenfeld
2020-07-28  9:54             ` Tore Anderson
2020-07-28 11:55               ` Jason A. Donenfeld
2020-07-28 12:17                 ` Tore Anderson
2020-07-28 12:17                   ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27652e0971672a8fab30f59ff053cf65feaa711f.camel@fud.no \
    --to=tore@fud.no \
    --cc=Jason@zx2c4.com \
    --cc=domi@tomcsanyi.net \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

WireGuard Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/wireguard/0 wireguard/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 wireguard wireguard/ https://lore.kernel.org/wireguard \
		wireguard@lists.zx2c4.com
	public-inbox-index wireguard

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.zx2c4.lists.wireguard


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git