From: 刘海潮 <liuhaichao@bytedance.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: Re: [PATCH] tun: darwin: fix panic: close of closed channel
Date: Mon, 26 Aug 2019 11:29:05 +0800 [thread overview]
Message-ID: <3AEA86B2-D5B9-46ED-ADD0-6557F8BD471F@bytedance.com> (raw)
In-Reply-To: <CAHmME9rDLvQQNd0VO5_rrNMakxaXuYt9hKij+tqOJ5aOur3gQQ@mail.gmail.com>
I used the previous version, so this bug was triggered. But why should we close tun.events in two places.
> 在 2019年8月25日，23:22，Jason A. Donenfeld <Jason@zx2c4.com> 写道：
>
> I was under the impression this was fixed with
> https://git.zx2c4.com/wireguard-go/commit/?id=6d78f895579b114c93bd493ad8d61316fc5dd15a
>
> What precisely is the bug you're seeing?
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
prev parent reply other threads:[~2019-08-26 3:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 9:25 [PATCH] tun: darwin: fix panic: close of closed channel liuhaichao
2019-08-25 15:22 ` Jason A. Donenfeld
2019-08-26 3:29 ` 刘海潮 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA86B2-D5B9-46ED-ADD0-6557F8BD471F@bytedance.com \
--to=liuhaichao@bytedance.com \
--cc=Jason@zx2c4.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).