From: D Neiroukh <officiallazerl0rd@gmail.com>
To: "wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>
Subject: BUG: When building on RHEL 8, duplicate function
Date: Wed, 8 May 2019 20:13:21 +0100 [thread overview]
Message-ID: <5cd32a51.1c69fb81.6fcd6.4f9d@mx.google.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1542 bytes --]
I insmod’d the UDP tunnel module for both IPv4 and IPv6 then...
During a build on RHEL 8 I came across this:
In file included from <command-line>:
/home/****/WireGuard/src/compat/compat.h:815:20: error: redefinition of ‘skb_mark_not_on_list’
static inline void skb_mark_not_on_list(struct sk_buff *skb)
^~~~~~~~~~~~~~~~~~~~
In file included from /home/****/WireGuard/src/compat/compat.h:777,
from <command-line>:
./include/linux/skbuff.h:1362:20: note: previous definition of ‘skb_mark_not_on_list’ was here
static inline void skb_mark_not_on_list(struct sk_buff *skb)
^~~~~~~~~~~~~~~~~~~~
make[2]: *** [scripts/Makefile.build:316: /home/s34cr/WireGuard/src/main.o] Error 1
make[1]: *** [Makefile:1528: _module_/home/s34cr/WireGuard/src] Error 2
make: *** [Makefile:37: module] Error 2
I nullified the first definition:
#if 0
static inline void skb_mark_not_on_list(struct sk_buff *skb)
{
skb->next = NULL;
}
#endif
And left the second (the include):
#if LINUX_VERSION_CODE < KERNEL_VERSION(5, 1, 0)
#include <linux/skbuff.h>
#define skb_probe_transport_header(a) skb_probe_transport_header(a, 0)
#endif
In order to build. I would like to state RHEL 8 builds with GCC 8.2.1 if that’s any help too. Seems I cannot connect, however. Will try removing the include in the second one.
Seems somewhere in between the RHEL kernel upgrade to 4.18 that function got added in.
[-- Attachment #1.2: Type: text/html, Size: 3647 bytes --]
[-- Attachment #2: Type: text/plain, Size: 148 bytes --]
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
reply other threads:[~2019-05-11 13:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cd32a51.1c69fb81.6fcd6.4f9d@mx.google.com \
--to=officiallazerl0rd@gmail.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).