From: Shuah Khan <skhan@linuxfoundation.org>
To: Li Zhijian <lizhijian@cn.fujitsu.com>,
rjw@rjwysocki.net, viresh.kumar@linaro.org, shuah@kernel.org,
Jason@zx2c4.com, masahiroy@kernel.org,
linux-kselftest@vger.kernel.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
wireguard@lists.zx2c4.com, netdev@vger.kernel.org,
Philip Li <philip.li@intel.com>,
kernel test robot <lkp@intel.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: cleanup config
Date: Wed, 25 Aug 2021 13:31:28 -0600 [thread overview]
Message-ID: <6547d239-56b7-71c0-70c9-20a67bdad1dd@linuxfoundation.org> (raw)
In-Reply-To: <20210825050948.10339-1-lizhijian@cn.fujitsu.com>
On 8/24/21 11:09 PM, Li Zhijian wrote:
> - DEBUG_PI_LIST was renamed to DEBUG_PLIST since 8e18faeac3 ("lib/plist: rename DEBUG_PI_LIST to DEBUG_PLIST")
> - SYNC was removed since aff9da10e21 ("staging/android: make sync_timeline internal to sw_sync")
>
Please write a complete commit log explaining the change
and tell us what happens if we don't do this.
> $ for k in $(grep ^CONFIG $(find tools/testing/selftests/ -name config) | awk -F'=' '{print$1}' | awk -F':' '{print $2}' | sort | uniq); do k=${k#CONFIG_}; git grep -qw -e "menuconfig $k" -e "config $k" || echo "$k is missing"; done;
> DEBUG_PI_LIST is missing
> SYNC is missing
>
> CC: Philip Li <philip.li@intel.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---
> tools/testing/selftests/cpufreq/config | 2 +-
> tools/testing/selftests/sync/config | 1 -
> tools/testing/selftests/wireguard/qemu/debug.config | 2 +-
> 3 files changed, 2 insertions(+), 3 deletions(-)
>
Please split this into 3 patches
thanks,
-- Shuah
prev parent reply other threads:[~2021-08-25 19:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 5:09 [PATCH] selftests: cleanup config Li Zhijian
2021-08-25 19:31 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6547d239-56b7-71c0-70c9-20a67bdad1dd@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=Jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lizhijian@cn.fujitsu.com \
--cc=lkp@intel.com \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=philip.li@intel.com \
--cc=rjw@rjwysocki.net \
--cc=shuah@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).