WireGuard Archive on lore.kernel.org
 help / color / Atom feed
From: Janne Johansson <icepic.dz@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH] wg-quick: Fix alternate routing table syntax on OpenBSD
Date: Mon, 5 Aug 2019 21:13:45 +0200
Message-ID: <CAA6-MF9hxZk5b8W-5SoYOwXO1F9hWxUydcYKt75EtwaVc37AkA@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9pGLM9a3Ww-MNy7mNT6JEQQXv4qLF0LDrAqVFUbDDPrsg@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 911 bytes --]

According to "man route" on openbsd, the -T is how its supposed to be run:

     The other commands relating to adding, changing, or deleting routes
have

     the syntax:


     *route* [*-dnqtv*] [*-T* rtable] *add* [modifiers] destination gateway



The manpage for "route" doesn't even contain "rdomain" so I would assume
Ankur is correct in that diff.


Den mån 5 aug. 2019 kl 20:47 skrev Jason A. Donenfeld <Jason@zx2c4.com>:

> Hi Ankur,
>
> Thanks for this. Could you provide your Signed-off-by line? Also, why
> is this required? Is this a recent change in syntax? A new syntax? Was
> the syntax always wrong? What's the deal?
>
> Thanks,
> Jason
> _______________________________________________
> WireGuard mailing list
> WireGuard@lists.zx2c4.com
> https://lists.zx2c4.com/mailman/listinfo/wireguard
>


-- 
May the most significant bit of your life be positive.

[-- Attachment #1.2: Type: text/html, Size: 3797 bytes --]

<div dir="ltr"><div dir="ltr">According to &quot;man route&quot; on openbsd, the -T is how its supposed to be run:<div><br><div>





<p class="gmail-p1" style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><span class="gmail-Apple-converted-space">     </span>The other commands relating to adding, changing, or deleting routes have</span></p>
<p class="gmail-p1" style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><span class="gmail-Apple-converted-space">     </span>the syntax:</span></p>
<p class="gmail-p2" style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0);min-height:13px"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"></span><br></p>
<p class="gmail-p1" style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"><span class="gmail-Apple-converted-space">     </span><b>route</b> [<b>-dnqtv</b>] [<b>-T</b> </span><span class="gmail-s2" style="text-decoration-line:underline;font-variant-ligatures:no-common-ligatures">rtable</span><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures">] <b>add</b> [</span><span class="gmail-s2" style="text-decoration-line:underline;font-variant-ligatures:no-common-ligatures">modifiers</span><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures">] </span><span class="gmail-s2" style="text-decoration-line:underline;font-variant-ligatures:no-common-ligatures">destination</span><span class="gmail-s1" style="font-variant-ligatures:no-common-ligatures"> </span><span class="gmail-s2" style="text-decoration-line:underline;font-variant-ligatures:no-common-ligatures">gateway</span></p><p class="gmail-p1" style="margin:0px;font-variant-numeric:normal;font-variant-east-asian:normal;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(0,0,0)"><br></p></div></div></div><br><div class="gmail_quote"><div class="gmail_attr">The manpage for &quot;route&quot; doesn&#39;t even contain &quot;rdomain&quot; so I would assume Ankur is correct in that diff.</div><div class="gmail_attr"><br></div><div dir="ltr" class="gmail_attr"><br></div><div dir="ltr" class="gmail_attr">Den mån 5 aug. 2019 kl 20:47 skrev Jason A. Donenfeld &lt;<a href="mailto:Jason@zx2c4.com">Jason@zx2c4.com</a>&gt;:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Ankur,<br>
<br>
Thanks for this. Could you provide your Signed-off-by line? Also, why<br>
is this required? Is this a recent change in syntax? A new syntax? Was<br>
the syntax always wrong? What&#39;s the deal?<br>
<br>
Thanks,<br>
Jason<br>
_______________________________________________<br>
WireGuard mailing list<br>
<a href="mailto:WireGuard@lists.zx2c4.com" target="_blank">WireGuard@lists.zx2c4.com</a><br>
<a href="https://lists.zx2c4.com/mailman/listinfo/wireguard" rel="noreferrer" target="_blank">https://lists.zx2c4.com/mailman/listinfo/wireguard</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature">May the most significant bit of your life be positive.<br></div></div>

[-- Attachment #2: Type: text/plain, Size: 148 bytes --]

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-20 12:20 Ankur Kothari
2019-08-05 18:46 ` Jason A. Donenfeld
2019-08-05 19:13   ` Janne Johansson [this message]
2019-08-05 19:38     ` Jason A. Donenfeld
2019-08-05 22:57   ` [PATCH v2] wg-quick: openbsd: fix alternate routing table syntax Ankur Kothari
2019-08-07  8:41     ` Jason A. Donenfeld

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA6-MF9hxZk5b8W-5SoYOwXO1F9hWxUydcYKt75EtwaVc37AkA@mail.gmail.com \
    --to=icepic.dz@gmail.com \
    --cc=Jason@zx2c4.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

WireGuard Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/wireguard/0 wireguard/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 wireguard wireguard/ https://lore.kernel.org/wireguard \
		wireguard@lists.zx2c4.com zx2c4-wireguard@archiver.kernel.org
	public-inbox-index wireguard


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.zx2c4.lists.wireguard


AGPL code for this site: git clone https://public-inbox.org/ public-inbox