From: Sebastien LEBEAU <sebcbi1@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>, wireguard@lists.zx2c4.com
Subject: Re: [PATCH] Change "Deselect All" to "Toggle All" in Excluded apps settings
Date: Sun, 16 Feb 2020 17:54:12 +0200 [thread overview]
Message-ID: <CAE+b=LQYkqiuF0bBFvsYGY7ta+J1hvyDhge2SsQ1A6DjfbKPcQ@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9qAnHWuS9Xk6Tka5PBF2uqjDxEZaPhScWziWd9j9oPS5g@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 4044 bytes --]
Signed-off-by: Sébastien LEBEAU <sebcbi1@gmail.com>
---
.../com/wireguard/android/fragment/AppListDialogFragment.java | 4 ++--
app/src/main/res/values-it/strings.xml | 2 +-
app/src/main/res/values-ru/strings.xml | 2 +-
app/src/main/res/values/strings.xml | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git
a/app/src/main/java/com/wireguard/android/fragment/AppListDialogFragment.java
b/app/src/main/java/com/wireguard/android/fragment/AppListDialogFragment.java
index 67059c7..c513d47 100644
---
a/app/src/main/java/com/wireguard/android/fragment/AppListDialogFragment.java
+++
b/app/src/main/java/com/wireguard/android/fragment/AppListDialogFragment.java
@@ -98,7 +98,7 @@ public class AppListDialogFragment extends DialogFragment
{
alertDialogBuilder.setPositiveButton(R.string.set_exclusions,
(dialog, which) -> setExclusionsAndDismiss());
alertDialogBuilder.setNegativeButton(R.string.cancel, (dialog,
which) -> dialog.dismiss());
- alertDialogBuilder.setNeutralButton(R.string.deselect_all,
(dialog, which) -> {
+ alertDialogBuilder.setNeutralButton(R.string.toggle_all, (dialog,
which) -> {
});
binding.setFragment(this);
@@ -109,7 +109,7 @@ public class AppListDialogFragment extends
DialogFragment {
final AlertDialog dialog = alertDialogBuilder.create();
dialog.setOnShowListener(d ->
dialog.getButton(DialogInterface.BUTTON_NEUTRAL).setOnClickListener(view ->
{
for (final ApplicationData app : appData)
- app.setExcludedFromTunnel(false);
+ app.setExcludedFromTunnel(!app.isExcludedFromTunnel());
}));
return dialog;
}
diff --git a/app/src/main/res/values-it/strings.xml
b/app/src/main/res/values-it/strings.xml
index 2aba5f8..b37d792 100644
--- a/app/src/main/res/values-it/strings.xml
+++ b/app/src/main/res/values-it/strings.xml
@@ -66,7 +66,7 @@
<string name="dark_theme_summary_on">Stai usando il tema scuro
(notte)</string>
<string name="dark_theme_title">Usa tema scuro</string>
<string name="delete">Elimina</string>
- <string name="deselect_all">Deseleziona tutto</string>
+ <string name="toggle_all">Inverti tutto</string>
<string name="dns_servers">Server DNS</string>
<string name="edit">Modifica</string>
<string name="endpoint">Endpoint</string>
diff --git a/app/src/main/res/values-ru/strings.xml
b/app/src/main/res/values-ru/strings.xml
index 2f2c03b..00b96fb 100644
--- a/app/src/main/res/values-ru/strings.xml
+++ b/app/src/main/res/values-ru/strings.xml
@@ -66,7 +66,7 @@
<string name="dark_theme_summary_on">В данный момент используется
темная (ночная) тема</string>
<string name="dark_theme_title">Использовать темную тему</string>
<string name="delete">Удалить</string>
- <string name="deselect_all">Снять выделенное</string>
+ <string name="toggle_all">Инвертировать все</string>
<string name="dns_servers">DNS-серверы</string>
<string name="edit">Редактировать</string>
<string name="endpoint">Конечная точка</string>
diff --git a/app/src/main/res/values/strings.xml
b/app/src/main/res/values/strings.xml
index 336cd4e..89a32c0 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -66,7 +66,7 @@
<string name="dark_theme_summary_on">Currently using dark (night)
theme</string>
<string name="dark_theme_title">Use dark theme</string>
<string name="delete">Delete</string>
- <string name="deselect_all">Deselect All</string>
+ <string name="toggle_all">Toggle All</string>
<string name="dns_servers">DNS servers</string>
<string name="edit">Edit</string>
<string name="endpoint">Endpoint</string>
--
2.25.0
[-- Attachment #1.2: Type: text/html, Size: 5005 bytes --]
[-- Attachment #2: Type: text/plain, Size: 148 bytes --]
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
prev parent reply other threads:[~2020-02-16 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 17:30 [PATCH] Change "Deselect All" to "Toggle All" in Excluded apps settings sebcbi1
2020-02-14 11:00 ` Jason A. Donenfeld
2020-02-16 15:54 ` Sebastien LEBEAU [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE+b=LQYkqiuF0bBFvsYGY7ta+J1hvyDhge2SsQ1A6DjfbKPcQ@mail.gmail.com' \
--to=sebcbi1@gmail.com \
--cc=Jason@zx2c4.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).