WireGuard Archive on lore.kernel.org
 help / color / Atom feed
From: Yousong Zhou <yszhou4tech@gmail.com>
To: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: compilation error on centos 7 kernels
Date: Mon, 30 Jul 2018 11:26:46 +0800
Message-ID: <CAECwjAjdHujDmgKURVf1jG=Pg4vu3XLje619GvtH2G5kGWLm3A@mail.gmail.com> (raw)

Yesterday I tried compiling openvswitch-dkms on 2 centos 7 systems,
both failed out of box because of the compat conditional compilation
code

Both system has LINUX_VERSION_CODE 199168, i.e. 3.10.0.  The 1st runs
kernel 3.10.0-514.26.2.el7.x86_64, and the second runs
3.10.0-693.2.2.el7.x86_64.  They both lacks skb_reset_tc,
our_pskb_put(), genl_family_attrbuf(), skb_put_data().  And the
3.10.0-514 kernel also lacks ipv6_mod_enabled() so I had to prepare
different dkms patches for them ;( . The bright side is that currently
both systems work fine ;)

It's partially caused by commit 401453 ("compat: handle RHEL 7.5's
recent backports"), but I think the code will be very hard to read and
maintain if we continue to use the current macro detection logic.  I
remembered openvswitch linux kernel datapath module was already in
such an state.  Maybe compile test will do better.

                yousong

             reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30  3:26 Yousong Zhou [this message]
2018-07-30  3:27 ` Yousong Zhou
2018-07-30  3:29   ` Jason A. Donenfeld
2018-07-30  3:34     ` Yousong Zhou
2018-07-30  7:42       ` Greg KH
2018-07-30  8:27         ` Yousong Zhou

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAECwjAjdHujDmgKURVf1jG=Pg4vu3XLje619GvtH2G5kGWLm3A@mail.gmail.com' \
    --to=yszhou4tech@gmail.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

WireGuard Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/wireguard/0 wireguard/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 wireguard wireguard/ https://lore.kernel.org/wireguard \
		wireguard@lists.zx2c4.com zx2c4-wireguard@archiver.kernel.org
	public-inbox-index wireguard


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.zx2c4.lists.wireguard


AGPL code for this site: git clone https://public-inbox.org/ public-inbox