[PATCH 1012/1012] Support for unicode interface names: only '%', ':' and '/' must be avoided

[PATCH 1012/1012] Support for unicode interface names: only '%', ':' and '/' must be avoided

[Jorge AC]

---
 src/tools/wg-quick/linux.bash | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/tools/wg-quick/linux.bash b/src/tools/wg-quick/linux.bash
index 48ce163..4317907 100755
--- a/src/tools/wg-quick/linux.bash
+++ b/src/tools/wg-quick/linux.bash
@@ -39,9 +39,9 @@ die() {
 parse_options() {
        local interface_section=0 line key value stripped
        CONFIG_FILE="$1"
-       [[ $CONFIG_FILE =~ ^[a-zA-Z0-9_=+.-]{1,15}$ ]] &&
CONFIG_FILE="/etc/wireguard/$CONFIG_FILE.conf"
+       [[ -e $CONFIG_FILE ]] || CONFIG_FILE="/etc/wireguard/$CONFIG_FILE.conf"
        [[ -e $CONFIG_FILE ]] || die "\`$CONFIG_FILE' does not exist"
-       [[ $CONFIG_FILE =~ (^|/)([a-zA-Z0-9_=+.-]{1,15})\.conf$ ]] ||
die "The config file must be a valid interface name, followed by
.conf"
+       [[ $CONFIG_FILE =~ (^|/)([^%:/]+)\.conf$ ]] || die "The config
file must be a valid interface name, followed by .conf"
        CONFIG_FILE="$(readlink -f "$CONFIG_FILE")"
        ((($(stat -c '0%#a' "$CONFIG_FILE") & $(stat -c '0%#a'
"${CONFIG_FILE%/*}") & 0007) == 0)) || echo "Warning: \`$CONFIG_FILE'
is world accessible" >&2
        INTERFACE="${BASH_REMATCH[2]}"
-- 
2.11.0

Re: [PATCH 1012/1012] Support for unicode interface names: only '%', ':' and '/' must be avoided

[Jason A. Donenfeld]

Indeed it looks like we could be slightly more permissive. From net/core/dev.c:

/**
*      dev_valid_name - check if name is okay for network device
*      @name: name string
*
*      Network device names need to be valid file names to
*      to allow sysfs to work.  We also disallow any kind of
*      whitespace.
*/
bool dev_valid_name(const char *name)
{
       if (*name == '\0')
               return false;
       if (strnlen(name, IFNAMSIZ) == IFNAMSIZ)
               return false;
       if (!strcmp(name, ".") || !strcmp(name, ".."))
               return false;

       while (*name) {
               if (*name == '/' || *name == ':' || isspace(*name))
                       return false;
               name++;
       }
       return true;
}

And earlier in the callstack, %d is checked for, which indeed adds %
to the blacklist, as your commit indicates.

But should wg-quick enable insane dev names?

Re: [PATCH 1012/1012] Support for unicode interface names: only '%', ':' and '/' must be avoided

[Jorge AC]

Thank you for checking my regex with the kernel code lines :-)

Definetly is insanity what drives me, I enjoy naming interfaces with
unicodes like =E2=98=A2.

Nevertheless, thinking about a legit use, it could be a nice gesture
for those non-latin1 people who wants to use their language.

On Sat, Aug 25, 2018 at 7:26 AM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> Indeed it looks like we could be slightly more permissive. From net/core/=
dev.c:
>
> /**
> *      dev_valid_name - check if name is okay for network device
> *      @name: name string
> *
> *      Network device names need to be valid file names to
> *      to allow sysfs to work.  We also disallow any kind of
> *      whitespace.
> */
> bool dev_valid_name(const char *name)
> {
>        if (*name =3D=3D '\0')
>                return false;
>        if (strnlen(name, IFNAMSIZ) =3D=3D IFNAMSIZ)
>                return false;
>        if (!strcmp(name, ".") || !strcmp(name, ".."))
>                return false;
>
>        while (*name) {
>                if (*name =3D=3D '/' || *name =3D=3D ':' || isspace(*name)=
)
>                        return false;
>                name++;
>        }
>        return true;
> }
>
> And earlier in the callstack, %d is checked for, which indeed adds %
> to the blacklist, as your commit indicates.
>
> But should wg-quick enable insane dev names?

Re: [PATCH 1012/1012] Support for unicode interface names: only '%', ':' and '/' must be avoided

[Jordan Glover]

=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me=
ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90
On August 25, 2018 5:50 PM, Jorge AC <jorgeanton@gmail.com> wrote:

> Thank you for checking my regex with the kernel code lines :-)
>
> Definetly is insanity what drives me, I enjoy naming interfaces with
> unicodes like =E2=98=A2.
>
> Nevertheless, thinking about a legit use, it could be a nice gesture
> for those non-latin1 people who wants to use their language.
>

Wireguard aims to be simple and secure. The name of device is used to
identify it, not to make a gestures to anyone. All wg/wg-quick commands
are in latin (english). I don't see much benefit of executing commands
like 'wg showconf =E2=98=A2' instead of 'wg showconf abc123' other than som=
eone's
egoistic pleasure.

Jordan

Re: [PATCH 1012/1012] Support for unicode interface names: only '%', ':' and '/' must be avoided

[Jorge AC]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Roger that.

Anyone who may want/need it can use "ip link" directly without "wc-quick",
anyway.

Thanks again!

On Sun, Aug 26, 2018 at 1:18 PM Jordan Glover <Golden_Miller83@protonmail.ch>
wrote:

>
> Wireguard aims to be simple and secure. The name of device is used to
> identify it, not to make a gestures to anyone. All wg/wg-quick commands
> are in latin (english).
>
>

[-- Attachment #2: Type: text/html, Size: 753 bytes --]