From: Shengjing Zhu <i@zhsj.me>
To: wireguard@lists.zx2c4.com
Cc: "Jason A. Donenfeld" <jason@zx2c4.com>
Subject: Re: [PATCH wireguard-go] tun/netstack: bump to latest gvisor
Date: Tue, 30 Aug 2022 00:04:48 +0800 [thread overview]
Message-ID: <CAG+qr1ENbpPACPSfzAwHGxgksiMFZpHx-HTLnA+Ab3Zkfcu4xA@mail.gmail.com> (raw)
In-Reply-To: <Ywzia/T9qQIATX0J@zx2c4.com>
Hi,
On Mon, Aug 29, 2022 at 11:59 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> Hi Shengjing,
>
> Thanks for the patch. I'll apply this. But one question:
>
> On Fri, Aug 19, 2022 at 01:27:28AM +0800, Shengjing Zhu wrote:
> > dev := &netTun{
> > + ep: channel.New(1024, uint32(mtu), ""),
>
> How did you come up with 1024 here?
>
I simply copied from gvisor,
https://github.com/google/gvisor/blob/c8f981f9/pkg/tcpip/link/tun/device.go#L38
> And more generally, how's performance of this compare to what was there
> before?
Sorry, I didn't take a performance test.
--
Best regards,
Shengjing Zhu
prev parent reply other threads:[~2022-08-29 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 17:27 [PATCH wireguard-go] tun/netstack: bump to latest gvisor Shengjing Zhu
2022-08-29 15:59 ` Jason A. Donenfeld
2022-08-29 16:04 ` Shengjing Zhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG+qr1ENbpPACPSfzAwHGxgksiMFZpHx-HTLnA+Ab3Zkfcu4xA@mail.gmail.com \
--to=i@zhsj.me \
--cc=jason@zx2c4.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).