WireGuard Archive on lore.kernel.org
 help / color / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Eric Kuck <eric@bluelinelabs.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: Android app whitelist/blacklist feature
Date: Thu, 5 Jul 2018 15:23:38 +0200
Message-ID: <CAHmME9oa5khgLAYT_KnhcOjP7mwmdoZ8JC5tn49H_W+VuYKmEQ@mail.gmail.com> (raw)
In-Reply-To: <CAMj-8hSEgJv=TSfWBEhRTrbiQbtJauLed6miZcFtS03jDPOBZA@mail.gmail.com>

Hey Eric,

On cursory glance, this looks really good; well done. It might be
desirable to have an easy toolbar icon for deselecting all apps. Great
that you managed to use RecyclerView. We'd like to use that on the
main tunnel list fragment, but haven't done so yet [1] (if you feel so
inclined and want to give it a spin.)

I'll let Samuel do a proper of the code.

Regards,
Jason

[1] https://docs.google.com/document/d/15i0Z750eL_OlUyrypUFLF7Hoi5eoF-dTFWj-Rs4RXGI/edit

  reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 20:35 Eric Kuck
2018-07-02 21:43 ` Samuel Holland
2018-07-03  0:22   ` Eric Kuck
2018-07-03  2:21     ` Jason A. Donenfeld
2018-07-03  2:27       ` Eric Kuck
2018-07-03  2:31         ` Jason A. Donenfeld
2018-07-03 18:12           ` Samuel Holland
2018-07-03 18:17             ` Jason A. Donenfeld
2018-07-04 22:19               ` Eric Kuck
2018-07-05 13:23                 ` Jason A. Donenfeld [this message]
2018-07-05 13:24                   ` Jason A. Donenfeld

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9oa5khgLAYT_KnhcOjP7mwmdoZ8JC5tn49H_W+VuYKmEQ@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=eric@bluelinelabs.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

WireGuard Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/wireguard/0 wireguard/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 wireguard wireguard/ https://lore.kernel.org/wireguard \
		wireguard@lists.zx2c4.com zx2c4-wireguard@archiver.kernel.org
	public-inbox-index wireguard


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.zx2c4.lists.wireguard


AGPL code for this site: git clone https://public-inbox.org/ public-inbox