From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Ryan Whelan <rcwhelan@gmail.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: Wireguard Bug?
Date: Fri, 14 Jun 2019 13:56:33 +0200 [thread overview]
Message-ID: <CAHmME9qM1xrUcC2Am+RsNr=4dXJKsUiOPmsgisn8hM-QjHLvjw@mail.gmail.com> (raw)
In-Reply-To: <CAM3m09Q3LCCFRJEe6J1UO0mtTiuVOYEiiyhEJJppDnuDnZZTwA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 141 bytes --]
Hey Ryan,
If you still have a reliable test rig for the bug, would you try
running with you kernel compiled with the attached patch?
Jason
[-- Attachment #2: willitwork.diff --]
[-- Type: text/x-patch, Size: 455 bytes --]
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index d8a2084b88db..3860c09d6ac1 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -1454,6 +1454,9 @@ bool queue_work_on(int cpu, struct workqueue_struct *wq,
local_irq_save(flags);
+ /* Pair with the smp_wmb() in set_work_pool_and_clear_pending. */
+ smp_rmb();
+
if (!test_and_set_bit(WORK_STRUCT_PENDING_BIT, work_data_bits(work))) {
__queue_work(cpu, wq, work);
ret = true;
[-- Attachment #3: Type: text/plain, Size: 148 bytes --]
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
next prev parent reply other threads:[~2019-06-14 11:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 13:44 Wireguard Bug? Ryan Whelan
2019-05-12 15:41 ` Jason A. Donenfeld
2019-05-12 23:02 ` Lonnie Abelbeck
2019-06-14 11:56 ` Jason A. Donenfeld [this message]
2019-05-17 6:34 WireGuard Bug? . .
2019-05-18 17:03 ` Lucian Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9qM1xrUcC2Am+RsNr=4dXJKsUiOPmsgisn8hM-QjHLvjw@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=rcwhelan@gmail.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).