WireGuard Archive on lore.kernel.org
 help / color / Atom feed
* remove an unnecessary call to unset_dns
@ 2019-10-31 23:40 Arjen Runsink
  2019-11-27 12:44 ` Jason A. Donenfeld
  0 siblings, 1 reply; 2+ messages in thread
From: Arjen Runsink @ 2019-10-31 23:40 UTC (permalink / raw)
  To: wireguard

The below patch removes an unnecessary call to unset_dns. It is already 
called in del_if and causes an error message since the interface does 
not exist anymore when called here.
Regards, Arjen


diff --git a/src/tools/wg-quick/linux.bash 
b/src/tools/wg-quick/linux.bash
index e690944..d2c7753 100755
--- a/src/tools/wg-quick/linux.bash
+++ b/src/tools/wg-quick/linux.bash
@@ -300,7 +300,6 @@ cmd_down() {
    execute_hooks "${PRE_DOWN[@]}"
    [[ $SAVE_CONFIG -eq 0 ]] || save_config
    del_if
- unset_dns
    execute_hooks "${POST_DOWN[@]}"
 }




_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: remove an unnecessary call to unset_dns
  2019-10-31 23:40 remove an unnecessary call to unset_dns Arjen Runsink
@ 2019-11-27 12:44 ` Jason A. Donenfeld
  0 siblings, 0 replies; 2+ messages in thread
From: Jason A. Donenfeld @ 2019-11-27 12:44 UTC (permalink / raw)
  To: Arjen Runsink; +Cc: WireGuard mailing list

del_if only hits it if it was previously set by the same process.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-31 23:40 remove an unnecessary call to unset_dns Arjen Runsink
2019-11-27 12:44 ` Jason A. Donenfeld

WireGuard Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/wireguard/0 wireguard/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 wireguard wireguard/ https://lore.kernel.org/wireguard \
		wireguard@lists.zx2c4.com
	public-inbox-index wireguard

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.zx2c4.lists.wireguard


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git