From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Lev Stipakov <lstipakov@gmail.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: Volatile in Wintun
Date: Sat, 24 Aug 2019 14:41:33 +0200 [thread overview]
Message-ID: <CAHmME9qfSPiWusZMddv8zwUSLQ5UvUqHSyr32FUo0-C=PYhTiQ@mail.gmail.com> (raw)
In-Reply-To: <CAGyAFMUYDP3fXx4tvaCW+SLvPYSWeRV-+gUNc=9HBsWweCOOTQ@mail.gmail.com>
Hi Lev,
I spent a while squinting at assembly diffs and reviewing how the
linux kernel does things. Voila:
https://git.zx2c4.com/wintun/commit/?id=c072f4f3c4b540c7cfebec563b0fb5d7ba932b6f
> Does it mean that hardware reordering
I'm mostly concerned here with the compiler reordering accesses,
actually. With regards to hardware memory barriers, I haven't seen
places yet where we'd need an explicit smp_mb() or similar that's not
already provided by the various locks. But let me know if your
analysis concludes differently.
Jason
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
prev parent reply other threads:[~2019-08-24 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 7:26 Volatile in Wintun Lev Stipakov
2019-08-19 18:15 ` Jason A. Donenfeld
2019-08-21 13:14 ` Lev Stipakov
2019-08-24 12:41 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9qfSPiWusZMddv8zwUSLQ5UvUqHSyr32FUo0-C=PYhTiQ@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=lstipakov@gmail.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).