WireGuard Archive on lore.kernel.org
 help / color / Atom feed
From: Harsh Shandilya <me@msfjarvis.dev>
To: Eiji Tanioka <tanioka404@gmail.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH wireguard-android] Explicit indexing for 'import_partial_success'
Date: Wed, 25 Mar 2020 20:24:34 +0530
Message-ID: <CALpmF+GcKO3VZ_GBhWgyJWw6=NmOPXd_rOO+dYFx+ziGypPHKQ@mail.gmail.com> (raw)
In-Reply-To: <CAA2ss9EmcPW=z9kRhGjDandHx=yGj6-UWx39EHsZx9qnfmCi1Q@mail.gmail.com>

On Wed, 25 Mar 2020 at 18:26, Eiji Tanioka <tanioka404@gmail.com> wrote:
>
> Or is it possible to apply this fix only to Japanese in crowdin?

There's no need to do that, this fix is applicable to all languages
including the default English.

> 2020年3月25日(水) 21:19 Eiji Tanioka <tanioka404@gmail.com>:
> >
> > When translate it to Japanese, values are exchanged.
> > For example, '1 of 10' is '10 個中の 1'.
> >
> > So this string should be explicit indexed.
> >
> > Signed-off-by: Eiji Tanioka <tanioka404@gmail.com>
> > ---
> >  ui/src/main/res/values/strings.xml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/ui/src/main/res/values/strings.xml b/ui/src/main/res/values/strings.xml
> > index 70d92c3..74c5be6 100644
> > --- a/ui/src/main/res/values/strings.xml
> > +++ b/ui/src/main/res/values/strings.xml
> > @@ -13,8 +13,8 @@
> >          <item quantity="other">%d tunnels selected</item>
> >      </plurals>
> >      <plurals name="import_partial_success">
> > -        <item quantity="one">Imported %d of %d tunnels</item>
> > -        <item quantity="other">Imported %d of %d tunnels</item>
> > +        <item quantity="one">Imported %1$d of %2$d tunnels</item>
> > +        <item quantity="other">Imported %1$d of %2$d tunnels</item>
> >      </plurals>
> >      <plurals name="import_total_success">
> >          <item quantity="one">Imported %d tunnel</item>
> > --
> > 2.25.2
> >

Applied, thanks!

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 12:16 Eiji Tanioka
2020-03-25 12:55 ` Eiji Tanioka
2020-03-25 14:54   ` Harsh Shandilya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALpmF+GcKO3VZ_GBhWgyJWw6=NmOPXd_rOO+dYFx+ziGypPHKQ@mail.gmail.com' \
    --to=me@msfjarvis.dev \
    --cc=tanioka404@gmail.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

WireGuard Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/wireguard/0 wireguard/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 wireguard wireguard/ https://lore.kernel.org/wireguard \
		wireguard@lists.zx2c4.com
	public-inbox-index wireguard

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.zx2c4.lists.wireguard


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git