From: Ben Burkert <ben@benburkert.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: wireguard-go data race in Peer.SendBuffer()
Date: Wed, 27 Nov 2019 09:47:29 -0800 [thread overview]
Message-ID: <CAMi2xeT1xO_1Co4SYRYpe48NAGTMO-wXFTUq1Eg+5+eJBBW1jQ@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9rhLSieSQ-Co7KKR6hfC-RGyaLA_TGpmYPObzJYMe5rDQ@mail.gmail.com>
Thanks, unfortunately I'm getting a build error now. Looks like the
patch needs to switch "sync.Lock" to "sync.Mutex". I'm testing this
change and haven't hit any race conditions yet, I'll let you know if I
see any more issues.
On Wed, Nov 27, 2019 at 4:40 AM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> Thanks for the report. Does this fix it for you?
>
> https://git.zx2c4.com/wireguard-go/commit/?id=cd26ba8ee4a523437aba3b489422127f1293a16f
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
next prev parent reply other threads:[~2019-11-27 17:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 19:58 wireguard-go data race in Peer.SendBuffer() Ben Burkert
2019-11-27 12:40 ` Jason A. Donenfeld
2019-11-27 17:47 ` Ben Burkert [this message]
2019-11-28 10:09 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMi2xeT1xO_1Co4SYRYpe48NAGTMO-wXFTUq1Eg+5+eJBBW1jQ@mail.gmail.com \
--to=ben@benburkert.com \
--cc=Jason@zx2c4.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).