WireGuard Archive on lore.kernel.org
 help / color / Atom feed
From: Eric Kuck <eric@bluelinelabs.com>
To: "Jason A. Donenfeld" <jason@zx2c4.com>,
	Samuel Holland <samuel@sholland.org>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: Android app whitelist/blacklist feature
Date: Wed, 4 Jul 2018 18:19:36 -0400
Message-ID: <CAMj-8hSEgJv=TSfWBEhRTrbiQbtJauLed6miZcFtS03jDPOBZA@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9qAUveJi6of9TMb_Owffsy-SX+4pQyDMHaz=6COE2CYxQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1669 bytes --]

A first pass that only works with GoBackend has just been pushed. Feel free
to make suggestions or requests. This is the first time I’ve used
databinding for more than just a findViewById substitute, so it’s very
possible I didn’t do something canonically.


On July 3, 2018 at 1:17:27 PM, Jason A. Donenfeld (jason@zx2c4.com) wrote:

On Tue, Jul 3, 2018 at 8:12 PM Samuel Holland <samuel@sholland.org> wrote:
> Right, trying to make it a global setting requires either some sort of
> out-of-band way to pass the information to wg-quick, or rewriting the
> configuration file every time the tunnel is brought up.
>
> Since from netd's point of view, this is a per-network setting anyway, I
agree
> it makes sense to configure it per-tunnel. ExemptedApplications works as
a
> configuration key, though I prefer ExcludedApplications--the application
isn't
> just not required to use the tunnel, it's not allowed to use the tunnel.
>
> In that case, here are my UI suggestions:
> - Add a button in the editor that switches to a fragment or pops up a
Dialog
> similar to a MultiSelectListPreference.
> - For consistency, checked means excluded -- everything defaults to
unchecked.
> - The package names of excluded apps are put in the
> com.wireguard.config.Interface, and wg-quick handles package name to uid
> translation.
>
> How does that sound?

All of that sounds right-on to me, and I think you're right that
ExcludedApplications is the better key.

(This also provides a good basis for later adding a
"ExcludeLocalNetwork" option.)

Eric's git access should be all setup now, so we can watch the
commits coming on in.

[-- Attachment #2: Type: text/html, Size: 2403 bytes --]

<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap:break-word"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">A first pass that only works with GoBackend has just been pushed. Feel free to make suggestions or requests. This is the first time I’ve used databinding for more than just a findViewById substitute, so it’s very possible I didn’t do something canonically.</div> <br> <div id="bloop_sign_1530741231598432000" class="bloop_sign"></div> <br><p class="airmail_on">On July 3, 2018 at 1:17:27 PM, Jason A. Donenfeld (<a href="mailto:jason@zx2c4.com">jason@zx2c4.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>On Tue, Jul 3, 2018 at 8:12 PM Samuel Holland &lt;<a href="mailto:samuel@sholland.org">samuel@sholland.org</a>&gt; wrote:
<br>&gt; Right, trying to make it a global setting requires either some sort of
<br>&gt; out-of-band way to pass the information to wg-quick, or rewriting the
<br>&gt; configuration file every time the tunnel is brought up.
<br>&gt;
<br>&gt; Since from netd&#39;s point of view, this is a per-network setting anyway, I agree
<br>&gt; it makes sense to configure it per-tunnel. ExemptedApplications works as a
<br>&gt; configuration key, though I prefer ExcludedApplications--the application isn&#39;t
<br>&gt; just not required to use the tunnel, it&#39;s not allowed to use the tunnel.
<br>&gt;
<br>&gt; In that case, here are my UI suggestions:
<br>&gt; - Add a button in the editor that switches to a fragment or pops up a Dialog
<br>&gt; similar to a MultiSelectListPreference.
<br>&gt; - For consistency, checked means excluded -- everything defaults to unchecked.
<br>&gt; - The package names of excluded apps are put in the
<br>&gt; com.wireguard.config.Interface, and wg-quick handles package name to uid
<br>&gt; translation.
<br>&gt;
<br>&gt; How does that sound?
<br>
<br>All of that sounds right-on to me, and I think you&#39;re right that
<br>ExcludedApplications is the better key.
<br>
<br>(This also provides a good basis for later adding a
<br>&quot;ExcludeLocalNetwork&quot; option.)
<br>
<br> Eric&#39;s git access should be all setup now, so we can watch the
<br>commits coming on in.
<br></div></div></span></blockquote></body></html>

  reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 20:35 Eric Kuck
2018-07-02 21:43 ` Samuel Holland
2018-07-03  0:22   ` Eric Kuck
2018-07-03  2:21     ` Jason A. Donenfeld
2018-07-03  2:27       ` Eric Kuck
2018-07-03  2:31         ` Jason A. Donenfeld
2018-07-03 18:12           ` Samuel Holland
2018-07-03 18:17             ` Jason A. Donenfeld
2018-07-04 22:19               ` Eric Kuck [this message]
2018-07-05 13:23                 ` Jason A. Donenfeld
2018-07-05 13:24                   ` Jason A. Donenfeld

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMj-8hSEgJv=TSfWBEhRTrbiQbtJauLed6miZcFtS03jDPOBZA@mail.gmail.com' \
    --to=eric@bluelinelabs.com \
    --cc=jason@zx2c4.com \
    --cc=samuel@sholland.org \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

WireGuard Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/wireguard/0 wireguard/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 wireguard wireguard/ https://lore.kernel.org/wireguard \
		wireguard@lists.zx2c4.com zx2c4-wireguard@archiver.kernel.org
	public-inbox-index wireguard


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.zx2c4.lists.wireguard


AGPL code for this site: git clone https://public-inbox.org/ public-inbox