WireGuard Archive on lore.kernel.org
 help / color / Atom feed
From: Eric Kuck <eric@bluelinelabs.com>
To: "Jason A. Donenfeld" <jason@zx2c4.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: Android app whitelist/blacklist feature
Date: Mon, 2 Jul 2018 22:27:02 -0400
Message-ID: <CAMj-8hSnvCpY7sZ6xcH=2_Va33M1YsZ97H66PrDSo5=BV9vyOw@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9qcXm65jFbGv24m-Pzx9c+nq2-D4y4kBkXk7W6u8HZLiw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]

I was originally thinking the new fragment would be a per-tunnel thing (set
when you create the tunnel or edit it), but you’re right - making it a
general setting likely makes a whole lot more sense. I can’t think of any
use-cases for different tunnels handling different apps.

On July 2, 2018 at 9:21:23 PM, Jason A. Donenfeld (jason@zx2c4.com) wrote:

Hey Eric,

Sorry for not responding earlier when you sent this to me directly.
I'm glad you sent it here and Samuel caught it, so your nice idea
won't go to waste.

On Tue, Jul 3, 2018 at 2:22 AM Eric Kuck <eric@bluelinelabs.com> wrote:
> If I were to do the work I initially proposed (new fragment + GoBackend
implementation), would this be enough to get merged?

No, but I can write the C part and just provide you with some sane
interface for passing off the relevant information to wg-quick. Send
me offlist an SSH key, and I'll give you commit access to branches
that begin with `ek/`.

> My proposal is to add another Fragment that’s just a list of all apps
installed on the phone with check boxes next to them.

How would one get to the Fragment? From the overflow menu, or from the
settings? I suspect the settings would be a more natural place for it.
Or were you thinking that this would actually be part of each
individual tunnel profile, stored within the configuration for the
tunnel somehow?

Regards,
Jason

[-- Attachment #2: Type: text/html, Size: 2069 bytes --]

<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap:break-word"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">I was originally thinking the new fragment would be a per-tunnel thing (set when you create the tunnel or edit it), but you’re right - making it a general setting likely makes a whole lot more sense. I can’t think of any use-cases for different tunnels handling different apps.</div> <div id="bloop_sign_1530584671369398016" class="bloop_sign"></div> <br><p class="airmail_on">On July 2, 2018 at 9:21:23 PM, Jason A. Donenfeld (<a href="mailto:jason@zx2c4.com">jason@zx2c4.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>Hey Eric,
<br>
<br>Sorry for not responding earlier when you sent this to me directly.
<br>I&#39;m glad you sent it here and Samuel caught it, so your nice idea
<br>won&#39;t go to waste.
<br>
<br>On Tue, Jul 3, 2018 at 2:22 AM Eric Kuck &lt;<a href="mailto:eric@bluelinelabs.com">eric@bluelinelabs.com</a>&gt; wrote:
<br>&gt; If I were to do the work I initially proposed (new fragment + GoBackend implementation), would this be enough to get merged?
<br>
<br>No, but I can write the C part and just provide you with some sane
<br>interface for passing off the relevant information to wg-quick. Send
<br>me offlist an SSH key, and I&#39;ll give you commit access to branches
<br>that begin with `ek/`.
<br>
<br>&gt; My proposal is to add another Fragment that’s just a list of all apps installed on the phone with check boxes next to them.
<br>
<br>How would one get to the Fragment? From the overflow menu, or from the
<br>settings? I suspect the settings would be a more natural place for it.
<br>Or were you thinking that this would actually be part of each
<br>individual tunnel profile, stored within the configuration for the
<br>tunnel somehow?
<br>
<br>Regards,
<br>Jason
<br></div></div></span></blockquote></body></html>

  reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 20:35 Eric Kuck
2018-07-02 21:43 ` Samuel Holland
2018-07-03  0:22   ` Eric Kuck
2018-07-03  2:21     ` Jason A. Donenfeld
2018-07-03  2:27       ` Eric Kuck [this message]
2018-07-03  2:31         ` Jason A. Donenfeld
2018-07-03 18:12           ` Samuel Holland
2018-07-03 18:17             ` Jason A. Donenfeld
2018-07-04 22:19               ` Eric Kuck
2018-07-05 13:23                 ` Jason A. Donenfeld
2018-07-05 13:24                   ` Jason A. Donenfeld

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMj-8hSnvCpY7sZ6xcH=2_Va33M1YsZ97H66PrDSo5=BV9vyOw@mail.gmail.com' \
    --to=eric@bluelinelabs.com \
    --cc=jason@zx2c4.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

WireGuard Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/wireguard/0 wireguard/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 wireguard wireguard/ https://lore.kernel.org/wireguard \
		wireguard@lists.zx2c4.com zx2c4-wireguard@archiver.kernel.org
	public-inbox-index wireguard


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.zx2c4.lists.wireguard


AGPL code for this site: git clone https://public-inbox.org/ public-inbox